Thanks to visit codestin.com
Credit goes to github.com

Skip to content

_StandardBottomSheet doesn't remove its status listener from foreign AnimationController's #167899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bungeefan opened this issue Apr 27, 2025 · 0 comments · Fixed by #167900
Closed

_StandardBottomSheet doesn't remove its status listener from foreign AnimationController's #167899

Bungeefan opened this issue Apr 27, 2025 · 0 comments · Fixed by #167900
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@Bungeefan
Copy link
Contributor

_StandardBottomSheetState registers a listener via addStatusListener on the passed in AnimationController but never removes it.

flutter/packages/flutter/lib/src/material/scaffold.dart

Lines 3267 to 3278 in cabb97b

@override
void initState() {
super.initState();
assert(widget.animationController.isForwardOrCompleted);
widget.animationController.addStatusListener(_handleStatusChange);
}
@override
void dispose() {
widget.onDispose?.call();
super.dispose();
}

Bungeefan added a commit to Bungeefan/flutter that referenced this issue Apr 27, 2025
@Bungeefan
Add missing removeStatusListener for bottom sheets (flutter#167899)
a6b2279
@Bungeefan Bungeefan mentioned this issue Apr 27, 2025
Merged
9 tasks
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. team-design Owned by Design Languages team and removed in triage Presently being triaged by the triage team labels Apr 28, 2025
@dkwingsmt dkwingsmt added P2 Important issues not at the top of the work list triaged-design Triaged by Design Languages team labels Apr 30, 2025
Bungeefan added a commit to Bungeefan/flutter that referenced this issue May 2, 2025
@Bungeefan
Add missing removeStatusListener for bottom sheets (flutter#167899)
e9bb791
github-merge-queue bot pushed a commit that referenced this issue May 2, 2025
@Bungeefan
Add missing removeStatusListener for bottom sheets (#167899) (#167900)
f839918 
Fixes the missing `removeStatusListener` in `_StandardBottomSheetState`.

* Fixes: #167899

I was unsure about the test regarding this change and I couldn't find
any similar tests, so I improvised with a custom controller class.
Feel free to request/make changes to the test as required.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@danagbemava-nc danagbemava-nc added the r: fixed Issue is closed as already fixed in a newer version label May 5, 2025
mboetger pushed a commit to mboetger/flutter that referenced this issue May 6, 2025
@Bungeefan @mboetger
Add missing removeStatusListener for bottom sheets (flutter#167899) (…
825d880 
…flutter#167900)

Fixes the missing `removeStatusListener` in `_StandardBottomSheetState`.

* Fixes: flutter#167899

I was unsure about the test regarding this change and I couldn't find
any similar tests, so I improvised with a custom controller class.
Feel free to request/make changes to the test as required.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing removeStatusListener for bottom sheets (#167899) Bungeefan/flutter
3 participants
@dkwingsmt @Bungeefan @danagbemava-nc