Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Does linux_fuchsia need to run as a release builder? #168089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matanlurey opened this issue Apr 30, 2025 · 2 comments · Fixed by #168094, #168146 or #168154
Closed

Does linux_fuchsia need to run as a release builder? #168089

matanlurey opened this issue Apr 30, 2025 · 2 comments · Fixed by #168094, #168146 or #168154
Assignees
@matanlurey
Labels
fyi-engine For the attention of Engine team infra: release Release-related requests and tooling P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team

Comments

@matanlurey
Copy link
Contributor

See parent issue: #168083.

For example, Linux Production Engine Drone (linux_fuchsia).

To my knowledge, these builds are being used in google3, but are not part of our normal release process (that is, the beta and stable branches, for example, do not publish these artifacts). Could we save resources (and release build time) by making these release_build: "false"?

(We do something similar for DDM: #168088)
@matanlurey matanlurey added fyi-engine For the attention of Engine team infra: release Release-related requests and tooling P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team labels Apr 30, 2025
@matanlurey matanlurey self-assigned this Apr 30, 2025
@zanderso
Copy link
Member

I believe we don't need these artifacts available on the beta and stable channels, no. They are no longer requested by the Flutter CLI.

@matanlurey
Copy link
Contributor Author

Sweet, will send a PR.

@matanlurey matanlurey mentioned this issue Apr 30, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue May 1, 2025
@matanlurey
Remove linux_fuchsia builds from release_build: "true". (#168094)
1a1d005 
Closes #168089.

These builds are not required in the MQ/part of `beta` or `stable`
branches, and are not requested by the Flutter CLI.

Notably, this deletes the line instead of `release_build: "false"`,
because that is broken:
#168088.
@auto-submit auto-submit bot mentioned this issue May 1, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue May 1, 2025
@auto-submit
Reverts "Remove linux_fuchsia builds from release_build: "true". (#…
fe60a2b 
…168094)" (#168146)

<!-- start_original_pr_link -->
Reverts: #168094
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: I guess it is used.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Closes #168089.

These builds are not required in the MQ/part of `beta` or `stable`
branches, and are not requested by the Flutter CLI.

Notably, this deletes the line instead of `release_build: "false"`,
because that is broken:
#168088.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
@matanlurey matanlurey reopened this May 1, 2025
@matanlurey matanlurey mentioned this issue May 1, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue May 1, 2025
@matanlurey
Only build and download Fuchsia artifacts on master (#168154)
e7a4ef0 
Closes #168089.

/cc @zanderso
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this issue May 1, 2025
@matanlurey
Only build and download Fuchsia artifacts on master (flutter#168154)
a3a04aa 
Closes flutter#168089.

/cc @zanderso
@matanlurey matanlurey mentioned this issue May 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matanlurey matanlurey

Labels
fyi-engine For the attention of Engine team infra: release Release-related requests and tooling P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
2 participants
@matanlurey @zanderso