Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Slimpeller needs to use different paths for ci/android_release_slimpeller_arm64 #168180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jtmcdole opened this issue May 1, 2025 · 0 comments
Open

Slimpeller needs to use different paths for ci/android_release_slimpeller_arm64 #168180

jtmcdole opened this issue May 1, 2025 · 0 comments
Labels
P1 High-priority issues at the top of the work list slimpeller Engine binary size reduction. go/slimpeller team-engine Owned by Engine team

Comments

@jtmcdole
Copy link
Member

jtmcdole commented May 1, 2025

ci/android_release_slimpeller_arm64 maps to the same GCS paths as android-arm64-release and thus can step on binary outputs of other builders.

flutter/engine/src/flutter/ci/builders/linux_android_aot_engine.json

Lines 167 to 174 in 5bd0fb7

"base_path": "out/ci/android_release_slimpeller_arm64/zip_archives/",
"include_paths": [
"out/ci/android_release_slimpeller_arm64/zip_archives/android-arm64-release/artifacts.zip",
"out/ci/android_release_slimpeller_arm64/zip_archives/android-arm64-release/linux-x64.zip",
"out/ci/android_release_slimpeller_arm64/zip_archives/android-arm64-release/symbols.zip",
"out/ci/android_release_slimpeller_arm64/zip_archives/android-arm64-release/analyze-snapshot-linux-x64.zip",
"out/ci/android_release_slimpeller_arm64/zip_archives/download.flutter.io"
],

Mitigating by removing the config in #168178

See this comment for suggested fix: #168178 (comment)
@jtmcdole jtmcdole added team-engine Owned by Engine team slimpeller Engine binary size reduction. go/slimpeller labels May 1, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Slimpeller May 1, 2025
@jtmcdole jtmcdole added e: scenario-app The `testing/scenario_app` fixture in the engine P1 High-priority issues at the top of the work list and removed e: scenario-app The `testing/scenario_app` fixture in the engine labels May 1, 2025
jason-simmons added a commit to jason-simmons/flutter that referenced this issue May 2, 2025
@jason-simmons
Check for duplicate archive paths in the engine build configuration J…
1e21bf0 
…SON files

The intent is to catch issues like flutter#168180 where multiple builders are uploading artifacts to the same paths on cloud storage.
@jason-simmons jason-simmons mentioned this issue May 2, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue May 5, 2025
@jason-simmons
Check for duplicate archive paths in the engine build configuration J…
0f769d3 
…SON files (#168248)

The intent is to catch issues like
#168180 where multiple builders
are uploading artifacts to the same paths on cloud storage.
mboetger pushed a commit to mboetger/flutter that referenced this issue May 6, 2025
@jason-simmons @mboetger
Check for duplicate archive paths in the engine build configuration J…
e676459 
…SON files (flutter#168248)

The intent is to catch issues like
flutter#168180 where multiple builders
are uploading artifacts to the same paths on cloud storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 High-priority issues at the top of the work list slimpeller Engine binary size reduction. go/slimpeller team-engine Owned by Engine team
Projects
Slimpeller
Status: Needs Triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtmcdole