[web:a11y] reconsider applying role="dialog" to arbitrary routes #168247
Assignees
Labels
a: accessibility
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)
customer: castaway
fyi-accessibility
For the attention of Framework Accessibility team
P2
Important issues not at the top of the work list
platform-web
Web applications specifically
team-web
Owned by Web platform team
triaged-web
Triaged by Web platform team
Comments
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
May 8, 2025
…ass (#168345) **Description** This pull request removes the unnecessary setAriaRole('dialog') fallback in the SemanticRoute class within the Flutter web engine. This line was an old fallback and is no longer needed **Before** https://dialog-0505-before.web.app/ **After** https://dialog-050502-after.web.app/ **Issue Fixed** This PR addresses GitHub Issue #168247, which proposes reconsidering the application of role="dialog" to arbitrary routes. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the web engine applies
role="dialog"as a default fallback for all routes. This logic predatesSemanticsRole.dialogandSemanticsRole.alertDialog. Because the engine couldn't tell if a route is a dialog it used the dialog role just in case. This seems no longer necessary now that we have the formal roles, so perhaps it is time to remove this fallback. Basically, the proposal is to remove this line:flutter/engine/src/flutter/lib/web_ui/lib/src/engine/semantics/route.dart
Line 108 in 7448418
The text was updated successfully, but these errors were encountered: