Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Impeller] libImpeller: Make the impeller.hpp classes non-final. #168394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chinmaygarde opened this issue May 6, 2025 · 0 comments · May be fixed by #168397
Open

[Impeller] libImpeller: Make the impeller.hpp classes non-final. #168394

chinmaygarde opened this issue May 6, 2025 · 0 comments · May be fixed by #168397
Labels
e: impeller Impeller rendering backend issues and features requests e: libimpeller The standalone Impeller library with a single-header API. engine flutter/engine repository. See also e: labels. team-engine Owned by Engine team

Comments

@chinmaygarde
Copy link
Member

When these were first written, it was assumed that the classes would be used purely from C++. However, bindings to environments like Python can be easily written against the C++ API. But the classes being final makes it hard to add environment specific functionality. Bindings authors could use composition but that requires all callsites to annotated differently which makes the whole process more tedious.

The C++ classes are also just wrappers over a handle to the underlying Impeller type.
@chinmaygarde chinmaygarde added e: impeller Impeller rendering backend issues and features requests e: libimpeller The standalone Impeller library with a single-header API. labels May 6, 2025
@github-project-automation github-project-automation bot moved this to In Triage in libImpeller May 6, 2025
@chinmaygarde chinmaygarde linked a pull request May 6, 2025 that will close this issue
Open
chinmaygarde added a commit to chinmaygarde/flutter that referenced this issue May 6, 2025
@chinmaygarde
[Impeller] libImpeller: Usability improvements for WASM and python bi…
af8f55c 
…ndings.

Fixes flutter#168393
Fixes flutter#168394
@chinmaygarde chinmaygarde moved this from In Triage to Todo in libImpeller May 6, 2025
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team engine flutter/engine repository. See also e: labels. team-engine Owned by Engine team and removed in triage Presently being triaged by the triage team labels May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e: impeller Impeller rendering backend issues and features requests e: libimpeller The standalone Impeller library with a single-header API. engine flutter/engine repository. See also e: labels. team-engine Owned by Engine team
Projects
libImpeller
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Impeller] libImpeller: Usability improvements for WASM and python bindings. chinmaygarde/flutter
2 participants
@chinmaygarde @danagbemava-nc