Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[google_maps_flutter] getActivityHashCode in GoogleMapController.java might return -1 if the activity is in the background #69128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyanglaz opened this issue Oct 27, 2020 · 1 comment · Fixed by flutter/plugins#3213
Labels
c: regression It was better in the past than it is now p: maps Google Maps plugin P2 Important issues not at the top of the work list platform-android Android applications specifically

Comments

@cyanglaz
Copy link
Contributor

cyanglaz commented Oct 27, 2020

This is a regression introduced in flutter/plugins#2488
The getActivityHashCode is unnecessary, we should revert back to how it was before flutter/plugins#2488: caching the hashCode when initialize the map and always use the cached value.

Also, V2 embedding does not use the activityHashCode, which makes another point that we can remove getActivityHashCode and use a cached value for V1 embedding.

Also see https://github.com/flutter/plugins/pull/3206/files#r512392320 for more details

@cyanglaz cyanglaz added platform-android Android applications specifically p: maps Google Maps plugin P2 Important issues not at the top of the work list c: regression It was better in the past than it is now labels Oct 27, 2020
math1man added a commit to math1man/plugins that referenced this issue Oct 27, 2020
math1man added a commit to math1man/plugins that referenced this issue Oct 27, 2020
math1man added a commit to math1man/plugins that referenced this issue Oct 27, 2020
…nnot be accessed. Updating this behavior will be tracked in flutter/flutter#69128"

This reverts commit c63a437
math1man added a commit to math1man/plugins that referenced this issue Oct 27, 2020
math1man added a commit to math1man/plugins that referenced this issue Oct 27, 2020
math1man added a commit to math1man/plugins that referenced this issue Oct 27, 2020
…nnot be accessed. Updating this behavior will be tracked in flutter/flutter#69128"

This reverts commit c63a437
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: regression It was better in the past than it is now p: maps Google Maps plugin P2 Important issues not at the top of the work list platform-android Android applications specifically
Projects
None yet
1 participant