Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[video_player] android: add tests to make sure playing local assets is successful #69209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cyanglaz opened this issue Oct 28, 2020 · 3 comments
Closed

[video_player] android: add tests to make sure playing local assets is successful #69209

cyanglaz opened this issue Oct 28, 2020 · 3 comments
Labels
p: video_player The Video Player plugin P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically

Comments

@cyanglaz
Copy link
Contributor

cyanglaz commented Oct 28, 2020 •
edited
Loading

We should add tests to make sure the local assets could be loaded by the video player plugin.

Issue: flutter/plugins#3123

This PR fixed the issue, but was landed without tests: flutter/plugins#3123

There is already a test available in the plugin, we just couldn't enable it on CI due to some issues. https://github.com/flutter/plugins/blob/master/packages/video_player/video_player/example/test_driver/video_player_test.dart#L17
@cyanglaz cyanglaz added p: video_player The Video Player plugin p: first party platform-android Android applications specifically P1 High-priority issues at the top of the work list and removed P2 labels Oct 28, 2020
@cyanglaz
Copy link
Contributor Author

Since it's been a while, we might need to re-investigate the test to see if we can enable it now https://github.com/flutter/plugins/blob/master/packages/video_player/video_player/example/test_driver/video_player_test.dart#L17

@cyanglaz cyanglaz mentioned this issue Oct 28, 2020
Closed
13 tasks
@KyleFin
Copy link

KyleFin commented Apr 15, 2021

This should've been closed when flutter/plugins#3219 was merged, right?

@github-actions
Copy link

github-actions bot commented Aug 3, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
p: video_player The Video Player plugin P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[video_player] re-enable test for playing video with assets cyanglaz/plugins
3 participants
@cyanglaz @KyleFin @pedromassangocode