Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ios_platform_images] missing integration tests #82208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stuartmorgan-g opened this issue May 10, 2021 · 1 comment · Fixed by flutter/packages#4920
Closed

[ios_platform_images] missing integration tests #82208

stuartmorgan-g opened this issue May 10, 2021 · 1 comment · Fixed by flutter/packages#4920
Labels
p: ios_platform_images Plugin for loading images from the native bundle P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team

Comments

@stuartmorgan-g
Copy link
Contributor

We should have an end-to-end test that it's actually getting image data.

For now it's being explicitly excluded from the test run since it's missing tests.
stuartmorgan-g added a commit to stuartmorgan-g/plugins that referenced this issue May 10, 2021
@stuartmorgan-g
Exclude ios_platform_images from integration tests
ce8dd1c 
It does not currently have an integration test, so must be explicitly
excluded due to recent tooling changes.

See flutter/flutter#82208
@stuartmorgan-g stuartmorgan-g mentioned this issue May 10, 2021
Merged
11 tasks
stuartmorgan-g added a commit to flutter/plugins that referenced this issue May 10, 2021
@stuartmorgan-g
Exclude some missing integration tests (#3872)
0474ef8 
ios_platform_images does not currently have an integration test, and file_chooser does not have a web integration test, so both must be explicitly excluded due to recent tooling changes.

See:
flutter/flutter#82208
flutter/flutter#82211
@stuartmorgan-g stuartmorgan-g added the P2 Important issues not at the top of the work list label May 10, 2021
@stuartmorgan-g stuartmorgan-g added the p: ios_platform_images Plugin for loading images from the native bundle label May 19, 2021
@stuartmorgan-g stuartmorgan-g added the platform-ios iOS applications specifically label Jun 13, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this issue Sep 13, 2021
@stuartmorgan-g @fotiDim
Exclude some missing integration tests (flutter#3872)
07f8069 
ios_platform_images does not currently have an integration test, and file_chooser does not have a web integration test, so both must be explicitly excluded due to recent tooling changes.

See:
flutter/flutter#82208
flutter/flutter#82211
@cadenkriese cadenkriese mentioned this issue Feb 11, 2022
Closed
11 tasks
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
@Hixie Hixie removed the plugin label Jul 6, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team labels Jul 8, 2023
stuartmorgan-g added a commit to stuartmorgan-g/packages that referenced this issue Sep 13, 2023
@stuartmorgan-g
[ci] Enable ios_platform_images tests
6e49b48 
flutter#4899 added integration tests,
but I forgot that they were being excluded in CI. This enables them.

Fixes flutter/flutter#82208
@stuartmorgan-g stuartmorgan-g mentioned this issue Sep 13, 2023
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this issue Sep 14, 2023
@stuartmorgan-g
[ci] Enable ios_platform_images tests (#4920)
0a86513 
#4899 added integration tests, but I forgot that they were being excluded in CI. This enables them.

Fixes flutter/flutter#82208
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
p: ios_platform_images Plugin for loading images from the native bundle P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ci] Enable ios_platform_images tests stuartmorgan-g/packages
3 participants
@stuartmorgan-g @Hixie @mamuseferha