Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[in_app_purchase] not updated README for 2.0.0 #94977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erperejildo opened this issue Dec 9, 2021 · 6 comments · Fixed by flutter/plugins#4597
Closed

[in_app_purchase] not updated README for 2.0.0 #94977

erperejildo opened this issue Dec 9, 2021 · 6 comments · Fixed by flutter/plugins#4597
Labels
p: in_app_purchase Plugin for in-app purchase P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels.

Comments

@erperejildo
Copy link

erperejildo commented Dec 9, 2021 •
edited
Loading

I've moved from 1.0.9 to 2.0.0 (next version) and many breaking changes were introduced. In changelog (https://pub.dev/packages/in_app_purchase/changelog) I read this:

Deprecates the InAppPurchaseAndroidPlatformAddition.enablePendingPurchases()
but in README (https://pub.dev/packages/in_app_purchase) we have this:

if (defaultTargetPlatform == TargetPlatform.android) {
    InAppPurchaseAndroidPlatformAddition.enablePendingPurchases();
  }

Also it became extremely complex to be integrated now with so many files when I only needed this before:

class PaymentQueueDelegate implements SKPaymentQueueDelegateWrapper {
  @override
  bool shouldContinueTransaction(
      SKPaymentTransactionWrapper transaction, SKStorefrontWrapper storefront) {
    return true;
  }

  @override
  bool shouldShowPriceConsent() {
    return false;
  }
}

I only have a paid version and a subscription.

Also wanted to mentioned that I find these issues related to documentation quite often for important packages like this one or for google_mobile_ads:
googleads/googleads-mobile-flutter#461
#93316 (comment)
#89950

Changes on these 2 can modify earnings and cause bad reviews from users if that affects their accounts.
@stuartmorgan-g stuartmorgan-g mentioned this issue Dec 10, 2021
Merged
11 tasks
@stuartmorgan-g
Copy link
Contributor

There was already a PR to fix this, it's just going through review: flutter/plugins#4597

Also wanted to mentioned that I find these issues related to documentation quite often for important packages like this one

Please continue to provide feedback (or PRs) when you do; that's how things get fixed.

or for google_mobile_ads: googleads/googleads-mobile-flutter#461 #93316 (comment)

I'm not sure of the relevance here; the Flutter team doesn't control the documentation for plugins that aren't part of the Flutter project.

Changes on these 2 can modify earnings and cause bad reviews from users if that affects their accounts.

Calling this deprecated method is a no-op, and cannot affect earnings or user experience.

@stuartmorgan-g stuartmorgan-g added P2 Important issues not at the top of the work list p: first party p: in_app_purchase Plugin for in-app purchase labels Dec 10, 2021
@erperejildo
Copy link
Author

There was already a PR to fix this, it's just going through review: flutter/plugins#4597

But why are not documentation and code changes merged together? 2.0.0 was released 8 days ago.

I'm not sure of the relevance here; the Flutter team doesn't control the documentation for plugins that aren't part of the Flutter project.

I'm talking about this one: https://pub.dev/packages/google_mobile_ads
Screenshot 2021-12-10 at 10 55 41
https://youtu.be/m0d_pbgeeG8?t=493

Not sure why is that on a different repo though.

Calling this deprecated method is a no-op, and cannot affect earnings or user experience.

I was referring more about the documentation not reflecting the exact changes we have to make. For this example I shared #89950 I didn't know that part was failing. Definitely my fault because I didn't test it properly again after update it, but when reading the docs I didn't think I had to. So if that creates problems with purchases I can either have or bad reviews (if the user made a purchase and he's not retrieving a paid version) or less earnings (if he cannot make purchases).

stuartmorgan-g pushed a commit to flutter/plugins that referenced this issue Dec 10, 2021
@dw2kim
[in_app-purchase] Updated the ReadMe to remove the deprecated `InAppP…
b78018a 
…urchaseAndroidPlatformAddition.enablePendingPurchases ` method (#4597)

This will resolve flutter/flutter#93837 & this work is just the follow-up from #4527 PR.

We need to update the documentation in the README.md of the in_app_purchase package to remove the instruction of initialization with the deprecated `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases` method.

Fixes flutter/flutter#94977
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Dec 10, 2021 •
edited
Loading

There was already a PR to fix this, it's just going through review: flutter/plugins#4597

But why are not documentation and code changes merged together? 2.0.0 was released 8 days ago.

Because updating documentation is a manual process, and mistakes can happen.

I'm not sure of the relevance here; the Flutter team doesn't control the documentation for plugins that aren't part of the Flutter project.

I'm talking about this one: https://pub.dev/packages/google_mobile_ads
Screenshot 2021-12-10 at 10 55 41

I'm not sure where the screenshot you've included is from, but it's not that package. flutter.dev is not the publisher of google_mobile_ads.

Not sure why is that on a different repo though.

Because it's not part of the Flutter project.

@erperejildo
Copy link
Author

erperejildo commented Dec 10, 2021 •
edited
Loading

Because updating documentation is a manual process, and mistakes can happen.

Oh yeah, I totally understand that, but so do the code. What I mean is why not merging both together, code and info? (not sure if the process has to be like that for some reasons tbh)

I'm not sure where the screenshot you've included is from, but it's not that package. flutter.dev is not the publisher of google_mobile_ads.

Hmm... maybe I had some other package open and took it from there, you're right sorry, it's from google.dev, not flutter.dev (didn't notice this difference until now).

Just curious, what's the difference here? I thought all packages for Flutter made by Google were from flutter.dev.
Because, at least to me, ads and purchases are quite connected to each other being both the only ways to make money from our apps, and here there is a different team (I guess) supporting the other package.

Don't want to go too off-topic specially if that belongs to other team (or let me know and I'll remove it), but since this was related to README/documentation I wanted to mention that I find myself sometimes a bit lost trying to follow best approaches. admob_firebase deprecated by google_mobile_ads, Admob, mediation, AdSense, AdManager (which we can be also used now in that package), native or banners... The documentation changes too much between all of these and I can understand that some devs move to 3rd party companies to show their ads (which also translates to less profit for Google). Where is the best place to get support from all of this?

Back in the days, one of the reasons I started with Angular for example, was the documentation. It's pointless to use a better framework if at the end I'm going to struggle with the documentation.
Normally Google/Flutter's packages are the most documented ones but also the most complicated one to setup properly. Is there any common place where we can gather all of this and try to put questions together?

More examples:
googleads/googleads-mobile-flutter#461 (comment)
googleads/googleads-mobile-flutter#463

@stuartmorgan-g
Copy link
Contributor

Because updating documentation is a manual process, and mistakes can happen.

Oh yeah, I totally understand that, but so do the code. What I mean is why not merging both together, code and info?

Because we forgot the README needed to be updated for that change. Again, mistakes happen. I'm not sure what more you are looking for here.

I thought all packages for Flutter made by Google were from flutter.dev.

No, only packages maintained by the Flutter project are published by flutter.dev.

Because, at least to me, ads and purchases are quite connected to each other

The team responsible for Google Mobile Ads is not involved with Apple Pay (unsurprisingly) or Google Play, which are the SDKs wrapped by in_app_purchase.

google_mobile_ads, Admob, mediation, AdSense, AdManager (which we can be also used now in that package), native or banners... [...] Where is the best place to get support from all of this?

I can't advise you on the best place to get support on things that aren't part of the Flutter project.

amantoux pushed a commit to amantoux/plugins that referenced this issue Dec 11, 2021
@dw2kim @amantoux
[in_app-purchase] Updated the ReadMe to remove the deprecated `InAppP…
7d5a69e 
…urchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter#4597)

This will resolve flutter/flutter#93837 & this work is just the follow-up from flutter#4527 PR.

We need to update the documentation in the README.md of the in_app_purchase package to remove the instruction of initialization with the deprecated `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases` method.

Fixes flutter/flutter#94977
KyleFin pushed a commit to KyleFin/plugins that referenced this issue Dec 21, 2021
@dw2kim @KyleFin
[in_app-purchase] Updated the ReadMe to remove the deprecated `InAppP…
fab8137 
…urchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter#4597)

This will resolve flutter/flutter#93837 & this work is just the follow-up from flutter#4527 PR.

We need to update the documentation in the README.md of the in_app_purchase package to remove the instruction of initialization with the deprecated `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases` method.

Fixes flutter/flutter#94977
@erperejildo erperejildo mentioned this issue Dec 23, 2021
Closed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
ValentinVignal pushed a commit to ValentinVignal/flutter__packages that referenced this issue Feb 23, 2023
@dw2kim
[in_app-purchase] Updated the ReadMe to remove the deprecated `InAppP…
fd16b6f 
…urchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter#4597)

This will resolve flutter/flutter#93837 & this work is just the follow-up from flutter#4527 PR.

We need to update the documentation in the README.md of the in_app_purchase package to remove the instruction of initialization with the deprecated `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases` method.

Fixes flutter/flutter#94977
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
p: in_app_purchase Plugin for in-app purchase P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels.
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan-g @erperejildo