This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app-purchase] Updated the ReadMe to remove the deprecated InAppPurchaseAndroidPlatformAddition.enablePendingPurchases method
#4597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvanbeusekom Hello, I am wondering if you could review this and merge it in so that the new plugin user won't get confused by the ReadMe 😸 |
mvanbeusekom
suggested changes
Dec 9, 2021
mvanbeusekom
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
LGTM, however there seems to be an issue with the CLA. It looks like you pushed commit 8cf9680 with a different email address.
Oh that's why haha. Thank you! will do |
stuartmorgan-g
suggested changes
Dec 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 10, 2021
… `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter/plugins#4597)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 11, 2021
… `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter/plugins#4597)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 11, 2021
… `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter/plugins#4597)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 11, 2021
… `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter/plugins#4597)
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
…urchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter#4597) This will resolve flutter/flutter#93837 & this work is just the follow-up from flutter#4527 PR. We need to update the documentation in the README.md of the in_app_purchase package to remove the instruction of initialization with the deprecated `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases` method. Fixes flutter/flutter#94977
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2021
… `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter/plugins#4597)
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
…urchaseAndroidPlatformAddition.enablePendingPurchases ` method (flutter#4597) This will resolve flutter/flutter#93837 & this work is just the follow-up from flutter#4527 PR. We need to update the documentation in the README.md of the in_app_purchase package to remove the instruction of initialization with the deprecated `InAppPurchaseAndroidPlatformAddition.enablePendingPurchases` method. Fixes flutter/flutter#94977
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve flutter/flutter#93837 & this work is just the follow-up from #4527 PR.
We need to update the documentation in the README.md of the in_app_purchase package to remove the instruction of initialization with the deprecated
InAppPurchaseAndroidPlatformAddition.enablePendingPurchasesmethod.Fixes flutter/flutter#94977
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.