Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add splashColor property for ListTile widget #100652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 31, 2022
Merged

Add splashColor property for ListTile widget #100652

merged 9 commits into from
Aug 31, 2022

Conversation

M97Chahboun
Copy link
Contributor

Adds a splashColor property to ListTile widget & test it,

Fixes #99898

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.
    I can't pass all existing tests because my Mac slow, but I passed ListTile test.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 23, 2022
@M97Chahboun
Copy link
Contributor Author

@HansMuller
Check this PR & Thank you.

HansMuller
HansMuller reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty close, just needs some small tweaks.

packages/flutter/test/material/list_tile_test.dart Outdated
final Widget buildApp = MaterialApp(
home: Material(
child: Center(
child: StatefulBuilder(builder: (BuildContext context, StateSetter setState) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This StatefulBuilder isn't needed.

packages/flutter/test/material/list_tile_test.dart Outdated
@@ -1294,6 +1294,33 @@ void main() {
);
});

testWidgets('ListTile can be splashed and has correct splash color', (WidgetTester tester) async {
final Widget buildApp = MaterialApp(
home: Material(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two-space indent

packages/flutter/test/material/list_tile_test.dart Outdated
home: Material(
child: Center(
child: StatefulBuilder(builder: (BuildContext context, StateSetter setState) {
return Container(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This container doesn't appear to be needed either.

@M97Chahboun
Copy link
Contributor Author

Thank you for your help 👍🏾👏🏾

@M97Chahboun M97Chahboun requested a review from HansMuller March 27, 2022 13:54
@M97Chahboun M97Chahboun force-pushed the add_splashColor_for_ListTile_widget branch from 5433721 to 92439d4 Compare March 27, 2022 16:47
@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@guidezpl
Copy link
Member

guidezpl commented Jun 3, 2022

Another merge should do the trick, also it looks like you're missing the CLA.

@M97Chahboun M97Chahboun force-pushed the add_splashColor_for_ListTile_widget branch from 1c014f0 to 7311c9a Compare June 3, 2022 11:53
@HansMuller
Copy link
Contributor

This PR looks like a reasonable and narrowly focused change however it has failed many presubmit tests. It may be possible to get it going by rebasing with the latest code.

@M97Chahboun
Copy link
Contributor Author

OK Thank you I will try to rebase it

HansMuller
HansMuller approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 31, 2022

auto label is removed for flutter/flutter, pr: 100652, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 31, 2022

auto label is removed for flutter/flutter, pr: 100652, due to Validations Fail.

@guidezpl guidezpl added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2022
@auto-submit auto-submit bot merged commit e0a83e6 into flutter:master Aug 31, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2022
@engine-flutter-autoroll
e0a83e6 Add splashColor property for ListTile widget (flutter/flutter…
10fb550 
…#100652)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 1, 2022
@engine-flutter-autoroll
e0a83e6 Add splashColor property for ListTile widget (flutter/flutter…
dd934a7 
…#100652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal] Allow customization of ListTile Splash
3 participants
@M97Chahboun @guidezpl @HansMuller