Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add variable font axes to TextStyle #100978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2022
Merged

Add variable font axes to TextStyle #100978

merged 1 commit into from
Apr 12, 2022

Conversation

jason-simmons
Copy link
Member

See #87291

@jason-simmons jason-simmons requested a review from dnfield March 29, 2022 16:47
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Mar 29, 2022
dnfield
dnfield reviewed Mar 29, 2022
View reviewed changes
packages/flutter/lib/src/painting/text_style.dart
/// Some fonts are variable fonts that can generate multiple font faces based
/// on the values of customizable attributes. For example, a variable font
/// may have a weight axis that can be set to a value between 1 and 1000.
/// [FontVariation]s can be used to select the values of these design axes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a doc comment example that shows using this API for some commonly available font.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an example

dnfield
dnfield approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM.

If we want to land this to make branch cut I think it's probably fine, we could follow up on docs/examples in a separate PR. But adding an example would really help here and shouldn't be too complicated.

@jason-simmons jason-simmons force-pushed the variable_fonts branch 2 times, most recently from fbbc2b6 to ba56034 Compare March 29, 2022 23:26
@fluttergithubbot fluttergithubbot merged commit 8824603 into flutter:master Apr 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
8824603 Add variable font axes to TextStyle (flutter/flutter#100978)
cdff3fa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
8824603 Add variable font axes to TextStyle (flutter/flutter#100978)
41cd00d
This was referenced Apr 18, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-simmons @dnfield @fluttergithubbot