-
Notifications
You must be signed in to change notification settings - Fork 28.5k
Add update packages roller #100982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update packages roller #100982
Conversation
74cfcb7
to
c88aeb7
Compare
c88aeb7
to
be4dea5
Compare
4fc9a86
to
c7beb18
Compare
static const String hostname = 'github.com'; | ||
|
||
static const String prBody = ''' | ||
This PR was generated by `flutter update-packages --force-upgrade`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Flutter update-packages going to call this conductor logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flow will be:
luci recipe -> dart packages_autoroller.dart -> flutter update-packages --force-upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using the conductor codebase because it has abstractions for cloning the flutter/flutter repo in a somewhat hermetic environment, and there's both unit test and integration test infrastructure already set up.
|
||
Future<void> updatePackages({ | ||
bool verbose = true, | ||
String author = 'flutter-packages-autoroller <[email protected]>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a google group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the only member of which is the tools team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't imagine anyone will be grepping the commit message and then emailing the address other than bots and recruiters though.
First part of #106371
Once this merges, it will still not be productionized. Next steps will be to create a builder config, a recipe, and add it to .ci.yaml.