-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Make hybrid_android_views_integration_test fail the build #101066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just F.Y.I. we should wait for the bot to deflake after potential fix is validated in recent 50 runs. |
This test has never been flaky before. I intentionally disabled it just to avoid a potential tree closure because an issue couldn't be reproduced locally. |
Oh, I see. Thanks for the explanation! |
This pull request is not suitable for automatic merging in its current state.
|
This pull request is not suitable for automatic merging in its current state.
|
b4dffeb
to
125d1ee
Compare
This pull request is not suitable for automatic merging in its current state.
|
Fixes #100991
This test is consistently passing after the latest changes https://ci.chromium.org/p/flutter/builders/prod/Linux_android%20hybrid_android_views_integration_test