Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make hybrid_android_views_integration_test fail the build #101066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

blasten
Copy link

@blasten blasten commented Mar 30, 2022

@blasten blasten requested a review from zanderso March 30, 2022 18:24
@blasten blasten requested a review from keyonghan as a code owner March 30, 2022 18:24
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan
Copy link
Contributor

Just F.Y.I. we should wait for the bot to deflake after potential fix is validated in recent 50 runs.

@blasten
Copy link
Author

blasten commented Mar 30, 2022

This test has never been flaky before. I intentionally disabled it just to avoid a potential tree closure because an issue couldn't be reproduced locally.

@keyonghan
Copy link
Contributor

This test has never been flaky before. I intentionally disabled it just to avoid a potential tree closure because an issue couldn't be reproduced locally.

Oh, I see. Thanks for the explanation!

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Apr 7, 2022
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 9b6e4f0 into flutter:master Apr 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make hybrid_android_views_integration_test fail the build
5 participants