-
Notifications
You must be signed in to change notification settings - Fork 28.9k
removed obsolete timelineArgumentsIndicatingLandmarkEvent #101382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed obsolete timelineArgumentsIndicatingLandmarkEvent #101382
Conversation
e5b70b4
to
814c154
Compare
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM if it LGT @kenzieschmoll
I'm assuming this is fine to remove based on my read of devtools - if that's wrong we should definitely add some kind of test that would fail in this repository for it. |
From triage: Even though the "Google testing" check didn't seem to update, it looks like this is causing some legit failures in google3 (see "details" link of the check):
@gaaclarke Can you take a look and maybe create a g3fix? |
/cc @jiahaog fyi |
We could potentially keep that field around but make it nullable and giving it a "deprecated" annotation. I'd rather just delete it since people shouldn't be using it. It was leaking dart implementation details all the way into the framework API so it was a bad idea to begin with. Forward fix put up for review. |
Thanks, the forward fix looks good |
The forward fix for google has landed. |
There may be merge conflicts from #101602. |
Sorry about Google Testing being blocked! Feel free to submit this as is, or if you want to verify this with google3 presubmit you can push an empty commit. |
97aac48
to
b50267c
Compare
fixes #101313
When this feature was landed in flutter it created a 15% performance regression (#12058 (comment))
From my local testing with our build_bench.dart microbenchmarks I'm seeing similar results with
debugProfileBuildsEnabled
turned on. The parameters were added for a feature in the Dart observatory that no longer exists.test-exempt: no added logic, removed logic for performance reasons
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.