Set template and migrate apps to iOS 11 minimum #101963

jmagman · 2022-04-15T04:17:42Z

Change templates to IPHONEOS_DEPLOYMENT_TARGET, MinimumOSVersion, and Podfile platform :ios to 11.0.
Add migrator for Podfile part to migrate platform :ios, '9.0' -> platform :ios, '11.0'
Compile with -miphoneos-version-min=11.0
Run migrator on all example apps and integration tests.

Note this does not change the plugin minimum support version, tracked separately in #101961

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2022-04-15T04:18:47Z

packages/flutter_tools/lib/src/flutter_plugins.dart

@@ -759,7 +759,7 @@ Future<void> _writeIOSPluginRegistrant(FlutterProject project, List<Plugin> plug
  final List<Map<String, Object?>> iosPlugins = _extractPlatformMaps(methodChannelPlugins, IOSPlugin.kConfigKey);
  final Map<String, Object> context = <String, Object>{
    'os': 'ios',
-    'deploymentTarget': '9.0',
+    'deploymentTarget': '11.0',


This is not used for published plugins, it's generated for app and modules that need to import plugins.

jmagman · 2022-04-15T04:19:16Z

packages/flutter_tools/lib/src/ios/migrations/deployment_target_migration.dart

+    const String deploymentTargetOriginal9 = 'IPHONEOS_DEPLOYMENT_TARGET = 9.0;';
+
+    // Podfile changes.
+    const String podfilePlatformVersionOriginal = "platform :ios, '9.0'";


New Podfile migration logic.

-platform :ios, '9.0' +platform :ios, '11.0'

jmagman · 2022-04-15T17:16:52Z

I can split the integration test/examples out into their own review if this is too many files, hopefully they are easy to review since those diffs are all the same, and very small.

cyanglaz

LGTM

cyanglaz · 2022-04-15T17:46:10Z

packages/flutter_tools/lib/src/ios/migrations/deployment_target_migration.dart

+
+    if (line.contains(deploymentTargetOriginal8)
+        || line.contains(deploymentTargetOriginal9)
+        || line.contains(podfilePlatformVersionOriginal)) {
      if (!migrationRequired) {


This is existing code, but I'm a little confused and try to understand this. Why do we still migrate if !migrationRequired.

Ahh, because .migrateLine() is being for each line in processFileLines, and if .migrateLine() returns non-null (as it does in this codepath), it will set migrationRequired = true, so that print will not show for subsequent lines.

Exactly, the next line is // Only print for the first discovered change found.

Ah ok. Sounds familiar, I probably asked the same question before and forgot about it.

When looking at the whole file, it makes sense but it might be a little confusing when doing inline reviewing like this.

christopherfujino

LGTM

…ter#101963)

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also #62902 and #85174 and #101963 Fixes #136060

Reverts #140478 Initiated by: loic-sharma This change reverts the following previous change: Original Description: 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also #62902 and #85174 and #101963 Fixes #136060

Reland #140478 with `ios_content_validation_test` test fix. ``` [ios_content_validation_test] Process terminated with exit code 0. Task result: { "success": true, "data": null, "detailFiles": [], "benchmarkScoreKeys": [], "reason": "success" } ``` __________ 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also #62902 and #85174 and #101963 Fixes #136060

Reland flutter#140478 with `ios_content_validation_test` test fix. ``` [ios_content_validation_test] Process terminated with exit code 0. Task result: { "success": true, "data": null, "detailFiles": [], "benchmarkScoreKeys": [], "reason": "success" } ``` __________ 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also: * flutter#62902 * flutter#85174 * flutter#101963 * flutter#140478 Issue:

1. Update ios_deployment_target from 12.0 to 13.0. 2. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 3. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 4. Compile with `-miphoneos-version-min=12.0` 5. Run the migrator on all example apps and integration tests. See also (ios_deployment_target): * flutter/buildroot#808 * flutter/buildroot#574 See also (template, migrator): * flutter#62902 * flutter#85174 * flutter#101963 * flutter#140478 Issue: flutter#167735

This updates the Flutter minimum iOS version from 12.0 to 13.0, adds a migrator for existing apps, and updates our own examples, tests, and benchmark apps to 13.0. A follow-up patch will drop iOS 13 `@available` checks in the embedder. This is required in order to use Swift in the embedder and not need to bundle the Swift runtime libs in every app that uses Flutter. Swift stable ABI As of March 2025, usage of iOS is well below 1%, see example public usage data here: https://telemetrydeck.com/survey/apple/iOS/majorSystemVersions/ This patch makes the following changes: 1. Updates ios_deployment_target from 12.0 to 13.0. 2. Changes templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 3. Adds migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 4. Compiles with `-miphoneos-version-min=12.0` 5. Runs the migrator on all example apps and integration tests. 6. Updates examples, tests to iOS 13 deployment target It also updates `verify_exported.dart`: * iOS 13 introduces stricter separation of const and non-const global symbols. Previously, these were declared in the Mach-O `__DATA` section which may be mapped read-write, but now they're in a dedicated `__DATA_CONST` section which is mapped read-only. This adds `(__DATA_CONST,__const)` to the allowlist with the same enforcement on exported symbol naming as before. See also (ios_deployment_target): * flutter/buildroot#808 * flutter/buildroot#574 See also (template, migrator): * #62902 * #85174 * #101963 * #140478 Issue: #167735 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Set template and migrate apps to iOS 11 minimum

84a244b

jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Apr 15, 2022

jmagman self-assigned this Apr 15, 2022

flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 15, 2022

jmagman commented Apr 15, 2022

View reviewed changes

jmagman requested review from cyanglaz and christopherfujino April 15, 2022 17:15

jmagman requested a review from zanderso April 15, 2022 17:17

cyanglaz approved these changes Apr 15, 2022

View reviewed changes

christopherfujino approved these changes Apr 15, 2022

View reviewed changes

jmagman added the waiting for tree to go green label Apr 15, 2022

fluttergithubbot merged commit 1756ccc into flutter:master Apr 15, 2022

jmagman deleted the migrate-ios11 branch April 15, 2022 18:50

engine-flutter-autoroll mentioned this pull request Apr 15, 2022

Roll Flutter from 329ceaef666f to ec8289c3f90c (26 revisions) flutter/plugins#5283

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 15, 2022

1756ccc Set template and migrate apps to iOS 11 minimum (flutter/flut…

d070567

…ter#101963)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022

1756ccc Set template and migrate apps to iOS 11 minimum (flutter/flut…

353e0eb

…ter#101963)

nickdowell mentioned this pull request May 3, 2022

[PLAT-8405] Change minimum supported iOS version to 9.0 bugsnag/bugsnag-cocoa#1352

Merged

jmagman mentioned this pull request Jul 15, 2022

Increase app minimum supported macOS version from 10.11 to 10.13 #107689

Merged

8 tasks

jmagman mentioned this pull request Feb 27, 2023

[camera] Update minimum Flutter version to 3.3 and iOS 11 flutter/packages#3296

Merged

11 tasks

jmagman mentioned this pull request Mar 15, 2023

Set plugin template minimum iOS version to 11.0 #122625

Merged

8 tasks

jmagman mentioned this pull request Dec 20, 2023

Set template and migrate apps to iOS 12 minimum #140478

Merged

8 tasks

auto-submit bot mentioned this pull request Jan 2, 2024

Reverts "Set template and migrate apps to iOS 12 minimum" #140822

Merged

8 tasks

jmagman mentioned this pull request Jan 2, 2024

Set template and migrate apps to iOS 12 minimum #140823

Merged

8 tasks

cbracken mentioned this pull request Apr 24, 2025

iOS: Update minimum iOS version to 13.0 #167737

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set template and migrate apps to iOS 11 minimum #101963

Set template and migrate apps to iOS 11 minimum #101963

jmagman commented Apr 15, 2022 •

edited

Loading

jmagman Apr 15, 2022

jmagman Apr 15, 2022

jmagman commented Apr 15, 2022

cyanglaz left a comment

cyanglaz Apr 15, 2022

christopherfujino Apr 15, 2022

jmagman Apr 15, 2022

cyanglaz Apr 15, 2022

christopherfujino left a comment

Set template and migrate apps to iOS 11 minimum #101963

Set template and migrate apps to iOS 11 minimum #101963

Conversation

jmagman commented Apr 15, 2022 • edited Loading

Pre-launch Checklist

jmagman Apr 15, 2022

Choose a reason for hiding this comment

jmagman Apr 15, 2022

Choose a reason for hiding this comment

jmagman commented Apr 15, 2022

cyanglaz left a comment

Choose a reason for hiding this comment

cyanglaz Apr 15, 2022

Choose a reason for hiding this comment

christopherfujino Apr 15, 2022

Choose a reason for hiding this comment

jmagman Apr 15, 2022

Choose a reason for hiding this comment

cyanglaz Apr 15, 2022

Choose a reason for hiding this comment

christopherfujino left a comment

Choose a reason for hiding this comment

jmagman commented Apr 15, 2022 •

edited

Loading