Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add matcher to find at least a given number of widgets (#102081) #102342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2022
Merged

Add matcher to find at least a given number of widgets (#102081) #102342

merged 1 commit into from
Apr 22, 2022

Conversation

DanielCardonaRojas
Copy link
Contributor

Adds matcher to support finding N or more widgets in widget tests

Closes #102081

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Apr 21, 2022
@google-cla
Copy link

google-cla bot commented Apr 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@gspencergoog gspencergoog requested a review from chunhtai April 22, 2022 21:50
chunhtai
chunhtai approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit a3a9a23 into flutter:master Apr 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
725aa9d 
…81) (flutter/flutter#102342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
d25a2f2 
…81) (flutter/flutter#102342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
9184273 
…81) (flutter/flutter#102342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
ffa7f81 
…81) (flutter/flutter#102342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
ec2c087 
…81) (flutter/flutter#102342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
3c45ddc 
…81) (flutter/flutter#102342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
86e7313 
…81) (flutter/flutter#102342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
26f8985 
…81) (flutter/flutter#102342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
68d9355 
…81) (flutter/flutter#102342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
2e1ad3f 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
4c14b2d 
…81) (flutter/flutter#102342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
12175c1 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
ef3d7f8 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
0c41600 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
94addc6 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
f2b0a79 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
971fb85 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
96b9591 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
48d82ae 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
fb8b441 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
62bcc66 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
4297a7a 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
b67b60b 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
8f475be 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
9b4f361 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
8a6ec51 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
7e1a80f 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
93752a2 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
7903e8a 
…81) (flutter/flutter#102342)
@DanielCardonaRojas DanielCardonaRojas deleted the fix_102081 branch April 27, 2022 14:31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
c6818c4 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
4f8eade 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
de10071 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
1c9be8d 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
64848fc 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
d5e6147 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
7472112 
…81) (flutter/flutter#102342)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
a3a9a23 Add matcher to find at least a given number of widgets (#1020…
a62c60f 
…81) (flutter/flutter#102342)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@DanielCardonaRojas @egramond
Add matcher to find at least a given number of widgets (flutter#102081)…
00433c8 
… (flutter#102342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support finding N or more widgets in widget tests
4 participants
@DanielCardonaRojas @cbracken @chunhtai @fluttergithubbot