Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[gen_l10n] Better blank lines in the header of generated files #103414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 12, 2022
Merged

[gen_l10n] Better blank lines in the header of generated files #103414

merged 5 commits into from
May 12, 2022

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented May 10, 2022 •
edited
Loading

Improve the generated localization files by removing useless blank lines in the header.

localizations_*.dart:

Before After
image image

localizations.dart:

Before After
image image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 10, 2022
AlexV525
AlexV525 commented May 10, 2022
View reviewed changes
packages/flutter_tools/lib/src/localizations/gen_l10n_templates.dart
/// Callers can lookup localized strings with an instance of @(class) returned
/// by `@(class).of(context)`.
/// Callers can lookup localized strings with an instance of @(class)
/// returned by `@(class).of(context)`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are document changes.

@AlexV525 AlexV525 marked this pull request as ready for review May 10, 2022 14:14
@AlexV525
Copy link
Member Author

Or maybe we can run the format for the content?

christopherfujino
christopherfujino approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goderbauer
goderbauer approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit aa39fa5 into flutter:master May 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 12, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
b8b628f 
flutter/flutter#103414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
e28d61e 
flutter/flutter#103414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
093b6ea 
flutter/flutter#103414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
398d19b 
flutter/flutter#103414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
4572b07 
flutter/flutter#103414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
b155ffe 
flutter/flutter#103414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
298842e 
flutter/flutter#103414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
f98c4f8 
flutter/flutter#103414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
12b732f 
flutter/flutter#103414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
1e8c276 
flutter/flutter#103414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
dd6f4e0 
flutter/flutter#103414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
1250452 
flutter/flutter#103414)
@AlexV525 AlexV525 deleted the gen-l10n-better-blank-lines-in-headers branch May 14, 2022 06:59
@AlexV525 AlexV525 mentioned this pull request Jul 28, 2022
Closed
8 tasks
@AlexV525 AlexV525 mentioned this pull request Aug 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
7c784d8 
flutter/flutter#103414)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
aa39fa5 [gen_l10n] Better blank lines in the header of generated files (
609a095 
flutter/flutter#103414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexV525 @goderbauer @christopherfujino @fluttergithubbot