Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Material 3 PopupMenuButton example and update CheckedPopupMenuItem example #103627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Material 3 PopupMenuButton example and update CheckedPopupMenuItem example #103627

wants to merge 1 commit into from

Conversation

TahaTesser
Copy link
Member

fixes #103623
part of #101048
related to #103606

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 12, 2022
@darrenaustin darrenaustin self-requested a review May 13, 2022 21:19
@TahaTesser TahaTesser changed the title Add Material 3 PopupMenuButton and update CheckedPopupMenuItem example Add Material 3 PopupMenuButton example and update CheckedPopupMenuItem example May 24, 2022
@TahaTesser TahaTesser force-pushed the popup_menu_examples branch from 76996c7 to 733099f Compare July 18, 2022 07:33
@TahaTesser TahaTesser force-pushed the popup_menu_examples branch from 733099f to 4fbcaff Compare July 18, 2022 08:39
@TahaTesser
Copy link
Member Author

Just resolved super conflicts.

@TahaTesser TahaTesser requested review from gspencergoog and removed request for darrenaustin and gspencergoog July 25, 2022 11:05
@TahaTesser TahaTesser closed this Jul 25, 2022
@TahaTesser TahaTesser deleted the popup_menu_examples branch July 25, 2022 11:07
@TahaTesser TahaTesser restored the popup_menu_examples branch July 25, 2022 11:09
@TahaTesser TahaTesser deleted the popup_menu_examples branch July 25, 2022 11:09
@TahaTesser
Copy link
Member Author

When #103606 lands, I plan to rewrite these code samples to match the official guidelines screenshot where PopupMenuButton is located in the AppBar. This looks far better to me than these examples with ListTile.

Similar to this

Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CheckedPopupMenuItem example
1 participant
@TahaTesser