Scribble mixin #104128

justinmc · 2022-05-18T23:49:56Z

This PR separates the handwriting text input feature from TextInputClient. The main point of the PR is to minimize breaking changes when working with platform APIs in the framework.

Design doc.
PR to make TextInputClient a mixin too: #104291

Depends on engine PR flutter/engine#36642.

Background

PR #75472 added scribble support directly to the abstract class TextInputClient, and this broke users (specifically, super_editor), which had implemented TextInputClient. This kicked off a discussion on how to add, change, and expand platform API support without causing these kinds of breaking changes.

How to minimize these breaking changes

The solution that I'm proposing with this PR is:

Use separate method channels as much as is reasonable.
Prefer mixins used with the with keyword instead of abstract classes.
Mix into widgets narrowly focused on bringing this platform functionality to the framework instead of making EditableTextState a catch-all.

1. Prefer separate method channels

Scribble is closely related to text input, but there are no direct dependencies, so I've created a separate MethodChannel for it in this PR (SystemChannels.scribble) instead of reusing SystemChannels.textInput. This comes along with a separate class to manage the channel (Scribble) similar to the existing TextInput class.

2. Prefer mixins and `with`

Similar to TextInputClient, I've also created a separate ScribbleClient, but it is a mixin instead of an abstract class. ScribbleClient is then mixed in using with.

3. Prefer new composable widgets to an EditableText catch-all

ScribbleClient is mixed into a new widget's state, _ScribbleFocusableState, not EditableTextState. This helps us separate concerns in our widgets as well by utilizing one of Flutter's core principles, composability.

The result

This approach would not have broken implementers of TextInputClient if it had been used originally. Also, any future changes to TextInputClient or to ScribbleClient will not affect users of the other class. Users can hack the platform text input and handwriting API support with less fear of breaking changes.

Migration guide

Users that were using TextInputClient for its own features and not for handwriting support likely had empty methods for showToolbar, insertTextPlaceholder, and removeTextPlaceholder. They may get warnings if they were using @override annotations, but shouldn't be broken by this change. Either way, they should remove the empty methods:

class MyEditorState extends State<MyEditor> implements TextInputClient {
  // If you had empty implementations of these methods just to prevent
  // compiler errors, you should remove them now. They are no longer
  // part of TextInputClient.
  /*
  @override
  void showToolbar() {}

  @override
  void insertTextPlaceholder(Size size) {}

  @override
  void removeTextPlaceholder() {}
  */

  // The rest of the class...
}

Users that had implemented their own handwriting feature using these methods will receive the @override warnings if they're using them, and their handwriting functionality will stop working. They should mix in ScribbleClient to regain the connection to the platform methods for scribble.

// If you had implemented your own custom handwriting functionality, mix
// in ScribbleClient like this to keep it working.
class MyEditorState extends State<MyEditor> with ScribbleClient implements TextInputClient {
  @override
  void showToolbar() {
    // Custom implementation...
  }

  @override
  void insertTextPlaceholder(Size size) {
    // Custom implementation...
  }

  @override
  void removeTextPlaceholder() 
    // Custom implementation...
  }

  // The rest of the class...
}

nilsreichardt · 2022-05-19T19:45:41Z

I don't know if this intended but the design doc is not public 😢

justinmc · 2022-05-24T22:16:59Z

@nilsreichardt Thanks for pointing that out! Updated.

justinmc · 2022-05-24T22:18:08Z

CC @fbcouch

flutter-dashboard · 2022-06-22T00:05:34Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

LongCatIsLooong · 2022-06-23T22:19:40Z

packages/flutter/lib/src/services/binding.dart

@@ -38,6 +39,7 @@ mixin ServicesBinding on BindingBase, SchedulerBinding {
    SystemChannels.lifecycle.setMessageHandler(_handleLifecycleMessage);
    SystemChannels.platform.setMethodCallHandler(_handlePlatformMessage);
    TextInput.ensureInitialized();
+    Scribble.ensureInitialized();


With scribble in a separated object you don't need to eagerly initialize TextInput I think?

LongCatIsLooong · 2022-06-23T22:29:48Z

packages/flutter/lib/src/services/scribble.dart

+  }
+}
+
+/// An interface to receive focus from the engine.


This class seems to have more responsibilities than just receiving focus?

LongCatIsLooong · 2022-06-23T22:31:10Z

packages/flutter/lib/src/services/scribble.dart

+
+/// An interface to receive focus from the engine.
+///
+/// This is currently only used to handle UIIndirectScribbleInteraction.


we probably want to explain what UIIndirectScribbleInteraction is and why it is special.

LongCatIsLooong · 2022-06-23T22:32:30Z

packages/flutter/lib/src/services/scribble.dart

+  /// Called by the engine when the [ScribbleClient] should receive focus.
+  ///
+  /// For example, this method is called during a UIIndirectScribbleInteraction.
+  void onScribbleFocus(Offset offset);


The documentation didn't explain offset?

No, but I'll add something about it.

LongCatIsLooong · 2022-06-23T22:33:44Z

packages/flutter/lib/src/services/scribble.dart

+  /// Requests that the client show the editing toolbar, for example when the
+  /// platform changes the selection through a non-flutter method such as
+  /// scribble.
+  void showToolbar();


This is now specifically for scribble.

LongCatIsLooong · 2022-06-23T22:34:05Z

packages/flutter/lib/src/services/scribble.dart

+  void onScribbleFocus(Offset offset);
+
+  /// Tests whether the [ScribbleClient] overlaps the given rectangle bounds.
+  bool isInScribbleRect(Rect rect);


nit: specify coordinate space.

LongCatIsLooong · 2022-06-23T22:37:09Z

packages/flutter/lib/src/widgets/editable_text.dart

-      _handleSelectionChanged(value.selection, (_textInputConnection?.scribbleInProgress ?? false) ? SelectionChangedCause.scribble : SelectionChangedCause.keyboard);
+      _handleSelectionChanged(
+        value.selection,
+        Scribble.scribbleInProgress


The change makes the line a bit different. Scribble could be in progress while there's no active connection.

Is that handled by the part above that was added for autofill?

if (!_shouldCreateInputConnection) { return; }

The change can still come from the keyboard when scribble is in progress (especially when there's a connected hardware keyboard). But since it's already there I'm fine with keeping this as is.

Sounds good, let's keep an eye out if any issues are filed about typing with a keyboard while doing handwriting.

LongCatIsLooong · 2022-06-23T22:39:30Z

packages/flutter/lib/src/widgets/editable_text.dart

+  }
+
+  void _removeTextPlaceholder() {
+    if (!widget.scribbleEnabled) {


shouldn't the same check be performed in other methods as well?

In _onPlaceholderLocationChanged and _onScribbleFocus, the _ScribbleFocusable widget prevents them from being called when scribble is disabled. Should I add the check (or an assert) just as a double check you think?

LongCatIsLooong · 2022-06-23T22:43:05Z

packages/flutter/lib/src/widgets/editable_text.dart

  _ScribbleFocusableState(): _elementIdentifier = (_nextElementIdentifier++).toString();

  @override
  void initState() {
    super.initState();
+    Scribble.client = this;


Is this right? The documentation states:

/// Set the given [ScribbleClient] as the single active client.
///
/// This is usually based on the [ScribbleClient] receiving focus.

Good call, the docs are right, it should be set on focus. I'll fix that and add a test.

justinmc · 2022-07-01T18:41:21Z

@LongCatIsLooong Ready for re-review.

LongCatIsLooong · 2022-07-01T23:10:30Z

packages/flutter/lib/src/widgets/editable_text.dart

-      _handleSelectionChanged(value.selection, (_textInputConnection?.scribbleInProgress ?? false) ? SelectionChangedCause.scribble : SelectionChangedCause.keyboard);
+      _handleSelectionChanged(
+        value.selection,
+        Scribble.scribbleInProgress


The change can still come from the keyboard when scribble is in progress (especially when there's a connected hardware keyboard). But since it's already there I'm fine with keeping this as is.

LongCatIsLooong · 2022-07-01T23:11:17Z

packages/flutter/lib/src/widgets/editable_text.dart

@@ -2976,7 +2981,9 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
        }
        return true;
      }).map<SelectionRect>((SelectionRect? selectionRect) => selectionRect!).toList();
-      _textInputConnection!.setSelectionRects(rects);
+      // TODO(justinmc): Is there a cleaner way to call this?
+      //_textInputConnection!.setSelectionRects(rects);


Is this part of the comment?

Whoops, removed.

LongCatIsLooong · 2022-07-01T23:23:37Z

packages/flutter/lib/src/services/scribble.dart

+    final List<dynamic> args = methodCall.arguments as List<dynamic>;
+    switch (method) {
+      case 'Scribble.showToolbar':
+        _client!.showToolbar();


There's no guarantee that _client will be non-null I think?

You're right. I'm going to return before this if it's not null, so if the engine somehow sends handwriting while no field is focused, it will just be ignored.

LongCatIsLooong · 2022-07-01T23:27:05Z

packages/flutter/lib/src/widgets/editable_text.dart

-    TextInput.unregisterScribbleElement(elementIdentifier);
+    Scribble.unregisterScribbleElement(elementIdentifier);
+    widget.focusNode.removeListener(_onFocusChange);
+    Scribble.client = null;


what if this client didn't have the focus?

Great catch here and your next comment. I've updated it here and there to only set the client to null if this instance is currently the client.

LongCatIsLooong · 2022-07-01T23:29:48Z

packages/flutter/lib/src/widgets/editable_text.dart

+    if (hasFocus && Scribble.client != this) {
+      Scribble.client = this;
+    } else {
+      Scribble.client = null;


Scribble.client could be pointing to a different client at this point.

goderbauer · 2022-07-26T22:26:22Z

(Triage): Are there still plans for this one?

justinmc · 2022-08-10T22:22:11Z

Planning to return to this after #107193!

justinmc · 2022-10-24T18:54:29Z

This PR must wait for flutter/engine#36642 to be rolled into the framework, which it is poised to do in #113951.

* e4b9796 [flutter_tools] Implement NotifyingLogger.supportsColor (flutter/flutter#113635) * 5a42f33 Roll Flutter Engine from d62aa9526a56 to 490b06d13390 (20 revisions) (flutter/flutter#113761) * 30161d4 Enable cache cleanup. (flutter/flutter#113729) * 780ceb5 Roll Flutter Engine from 490b06d13390 to bcd83df4ecbd (4 revisions) (flutter/flutter#113766) * 2668f90 Composing text shouldn't be part of undo/redo (flutter/flutter#108765) * 4f373e1 Roll Plugins from e6184f9 to a577c00 (4 revisions) (flutter/flutter#113769) * 482466e Roll Flutter Engine from bcd83df4ecbd to 3a7acb3dbe9b (6 revisions) (flutter/flutter#113771) * 483e1d9 Validate bins on path in doctor (flutter/flutter#113106) * 103a5c9 Overlay always applies clip (flutter/flutter#113770) * c0f8229 Roll Flutter Engine from 3a7acb3dbe9b to 69f2bc881f46 (3 revisions) (flutter/flutter#113780) * 7caaac2 link "iOS PlatformView BackdropFilter design doc" in the BackdropFilter widget's documentation (flutter/flutter#113779) * 46d2908 Roll Flutter Engine from 69f2bc881f46 to 3b6ecf9f1a66 (1 revision) (flutter/flutter#113789) * 37af038 Roll pub packages (flutter/flutter#113574) * 2340188 Roll Flutter Engine from 3b6ecf9f1a66 to 2b21a3125ca2 (6 revisions) (flutter/flutter#113798) * 3665dd8 Start generating coverage. (flutter/flutter#113587) * 25b10ef Roll Flutter Engine from 2b21a3125ca2 to 85e4fa84d660 (3 revisions) (flutter/flutter#113803) * 59d26c4 Roll Flutter Engine from 85e4fa84d660 to f24ea1a04d93 (3 revisions) (flutter/flutter#113806) * 07319a9 revert last 2 engine rolls (flutter/flutter#113835) * 782baec Resolve 113705: Separated longer running tests from `runMisc` to prevent flakiness from timeouts (flutter/flutter#113784) * 8834692 [web] Use TrustedTypes in flutter.js and other tools (flutter/flutter#112969) * 1f95a7d Roll Plugins from a577c00 to 7a7480a (4 revisions) (flutter/flutter#113834) * 1ebe53c Roll pub packages (flutter/flutter#113799) * 70c1f26 Avoid creating map literal in `flutter.gradle` multidex check (flutter/flutter#113845) * 8d13c89 Followup 113705: Allow the `slow` tests to break the tree as all tests in that shard previously could (flutter/flutter#113846) * 4323397 Roll Flutter Engine from 2b21a3125ca2 to 83092c04c105 (20 revisions) (flutter/flutter#113847) * f4804ad Roll Flutter Engine from 2b21a3125ca2 to de83ef6d2c26 (21 revisions) (flutter/flutter#113849) * 44c146a Bump actions/upload-artifact from 3.1.0 to 3.1.1 (flutter/flutter#113859) * 025a3ab Roll Flutter Engine from de83ef6d2c26 to 6aa683e365d5 (3 revisions) (flutter/flutter#113863) * 4c6251a Add fontFamilyFallback to ThemeData (flutter/flutter#112976) * a0731af Roll Flutter Engine from 6aa683e365d5 to c03114f1575d (2 revisions) (flutter/flutter#113864) * b5ac8c5 Roll Flutter Engine from c03114f1575d to 30cec21e4b3c (1 revision) (flutter/flutter#113871) * 92c3e29 Roll Flutter Engine from 30cec21e4b3c to e35f850102e6 (1 revision) (flutter/flutter#113872) * 1b5b469 Roll Flutter Engine from e35f850102e6 to 30bb44616bac (3 revisions) (flutter/flutter#113875) * 35daf37 Roll Flutter Engine from 30bb44616bac to 9a671daf1c92 (2 revisions) (flutter/flutter#113877) * 2714226 Roll Flutter Engine from 9a671daf1c92 to 07bdae45e7f9 (1 revision) (flutter/flutter#113888) * 777040d Roll Flutter Engine from 07bdae45e7f9 to 5abc1b8713be (1 revision) (flutter/flutter#113892) * fd813de Roll Flutter Engine from 5abc1b8713be to 51f8ac74b558 (1 revision) (flutter/flutter#113901) * 6ac2cc5 Roll Flutter Engine from 51f8ac74b558 to 360dcd1cf31a (1 revision) (flutter/flutter#113902) * e4cc916 Roll Flutter Engine from 360dcd1cf31a to fb9df8d65dc8 (1 revision) (flutter/flutter#113918) * 20c4b6c Roll Flutter Engine from fb9df8d65dc8 to f62df692058c (1 revision) (flutter/flutter#113919) * 4a62876 Roll Flutter Engine from f62df692058c to 7fc208c07693 (1 revision) (flutter/flutter#113926) * 12b05ca Roll Flutter Engine from 7fc208c07693 to 6bb2f03e6fd0 (1 revision) (flutter/flutter#113929) * a25c86c Roll Flutter Engine from 6bb2f03e6fd0 to 2b5d630e4831 (1 revision) (flutter/flutter#113938) * 28e0f08 Reland "[text_input] introduce TextInputControl" (flutter/flutter#113758) * 0b1fbd2 Roll Plugins from 7a7480a to 84f5ec6 (2 revisions) (flutter/flutter#113942) * 15a4b00 Use correct semantics for toggle buttons (flutter/flutter#113851) * a7fe536 [framework] re-rasterize when window size or insets changes (flutter/flutter#113647) * bd9021a Roll Flutter Engine from 2b5d630e4831 to 168c711a330e (1 revision) (flutter/flutter#113947) * 29397c2 Fix selectWordsInRange when last word is located before the first word (flutter/flutter#113224) * 6415de4 Roll Flutter Engine from 168c711a330e to 7cd07782141c (1 revision) (flutter/flutter#113948) * 700b449 Roll Flutter Engine from 7cd07782141c to 2f6c6583058b (2 revisions) (flutter/flutter#113951) * b4058b9 Update Popup Menu to support Material 3 (flutter/flutter#103606) * b571abf Scribble mixin (flutter/flutter#104128) * 903e9fb Roll Flutter Engine from 2f6c6583058b to f445898c1a28 (1 revision) (flutter/flutter#113959) * 2dd87fb Fix --local-engine for the new web/wasm mode (flutter/flutter#113759) * 3c2f500 Fix edge scrolling on platforms that select word by word on long press move (flutter/flutter#113128) * 5259e1b Add --empty to the flutter create command (flutter/flutter#113873) * 0c14308 Add branch coverage to flutter test (flutter/flutter#113802) * 7571f30 Roll Flutter Engine from f445898c1a28 to ecf2f85cab61 (5 revisions) (flutter/flutter#113968) * 391330f Roll Flutter Engine from ecf2f85cab61 to 926bb80f49a2 (2 revisions) (flutter/flutter#113971) * 884f4d0 Updated the Material Design tokens used to generate component defaults to v0.137. (flutter/flutter#113970) * 694b253 [Android] Fix spell check integration test guarded function conflict (flutter/flutter#113541) * 806fb93 Fix ScrollPosition.isScrollingNotifier.value for pointer scrolling (flutter/flutter#113972) * 14a7360 Roll Flutter Engine from 926bb80f49a2 to 7577fd46d50f (1 revision) (flutter/flutter#113974) * 6154b3b Improve Scrollbar drag behavior (flutter/flutter#112434) * 1037f99 Roll Flutter Engine from 7577fd46d50f to 24d7b5f255c0 (1 revision) (flutter/flutter#113976) * e62d519 Roll Flutter Engine from 24d7b5f255c0 to 75bfcd73ca8a (1 revision) (flutter/flutter#113981) * 49f0061 Roll Flutter Engine from 75bfcd73ca8a to b93c654bd158 (1 revision) (flutter/flutter#113984) * 2a59bd5 Roll Flutter Engine from b93c654bd158 to 9abb459368d5 (2 revisions) (flutter/flutter#113992) * 400136b Fix `Slider` overlay and value indicator interactive behavior on desktop. (flutter/flutter#113543) * b0e7c9c Move `AnimatedIcons` example and fix typo in `cupertino/text_selection_toolbar.dart` (flutter/flutter#113937) * 7f75d24 Add Material 3 `ProgressIndicator` examples (flutter/flutter#113950) * 593315e Roll Flutter Engine from 9abb459368d5 to 2b70cba93123 (1 revision) (flutter/flutter#113997) * 5304a24 Roll Flutter Engine from 2b70cba93123 to c414b1d57b2b (1 revision) (flutter/flutter#114000) * 3599b3a Add support for expression compilation when debugging integration tests (flutter/flutter#113481) * 13cb46d Roll Plugins from 84f5ec6 to fed9104 (2 revisions) (flutter/flutter#114019) * b375b4a Fix an issue that Dragging the iOS text selection handles is jumpy and iOS text selection update incorrectly. (flutter/flutter#109136) * 563e0a4 Page Up / Page Down in text fields (flutter/flutter#107602) * 0fe29f5 Raise an exception when invalid subshard name (flutter/flutter#113222) * dbbef15 Add Focus.parentNode to allow controlling the shape of the Focus tree. (flutter/flutter#113655) * b373be8 Upgrade gradle for flutter tool to 7.3.0 (flutter/flutter#114023) * 92d8b04 [macOS] Flavors project throws `no flavor specified` for creating a project. (flutter/flutter#113979) * ae143ad Hide debug logs from a MemoryAllocations test that intentionally throws an exception (flutter/flutter#113786) * e133721 Check for watch companion in build settings (flutter/flutter#113956) * 9f5c655 Revert "Check for watch companion in build settings (#113956)" (flutter/flutter#114035) * df259c5 Add `clipBehavior` and apply `borderRadius` to DataTable's Material (flutter/flutter#113205) * e76f883 Cache TextPainter plain text value to improve performance (flutter/flutter#109841) * a30d816 fix stretch effect with rtl support (flutter/flutter#113214) * af34b10 Roll Flutter Engine from c414b1d57b2b to 92500cfe7a65 (1 revision) (flutter/flutter#114001) * 3ce88d3 Replace menu defaults with tokens (flutter/flutter#113963) * 8c3806f Add parentNode to FocusScope widget (flutter/flutter#114034) * a30c63a Roll Flutter Engine from 92500cfe7a65 to e9aba46a7bcb (13 revisions) (flutter/flutter#114038) * 3ed14a0 Roll Flutter Engine from e9aba46a7bcb to b1f1ec2bae46 (4 revisions) (flutter/flutter#114043) * b816801 fix to add both flutter_test and integration_test (flutter/flutter#109650) * e39fa7a Fix wasted memory caused by debug fields - 16 bytes per object (when adding that should-be-removed field crosses double-word alignment) (flutter/flutter#113927) * d5c53b8 Fix text field label animation duration and curve (flutter/flutter#105966) * dcf219e Roll Flutter Engine from b1f1ec2bae46 to ce6649aeea6d (1 revision) (flutter/flutter#114044) * afa9a70 Roll Flutter Engine from ce6649aeea6d to a34d38ccb726 (1 revision) (flutter/flutter#114046) * 8b28104 Roll Flutter Engine from a34d38ccb726 to 71675e2de9f2 (2 revisions) (flutter/flutter#114049) * dd9b7ac Roll Flutter Engine from 71675e2de9f2 to c814452fcb26 (1 revision) (flutter/flutter#114052) * b00b2f1 Roll Flutter Engine from c814452fcb26 to ac95a3a4cc92 (1 revision) (flutter/flutter#114053) * dcc6a4c Roll Flutter Engine from ac95a3a4cc92 to 199166f7c642 (1 revision) (flutter/flutter#114056) * e739ad0 M3 Text field UI update (flutter/flutter#113776) * 89e1fbd Roll Flutter Engine from 199166f7c642 to c00953e610fa (1 revision) (flutter/flutter#114059) * 391f356 Roll Flutter Engine from c00953e610fa to 3b086a0e98e3 (1 revision) (flutter/flutter#114062) * 97970ac Roll Flutter Engine from 3b086a0e98e3 to 56841d491f80 (1 revision) (flutter/flutter#114065) * 8b36497 Roll Flutter Engine from 56841d491f80 to 27269992caec (1 revision) (flutter/flutter#114068) * 7d037f2 Roll Flutter Engine from 27269992caec to 25133f15440d (1 revision) (flutter/flutter#114075) * cb53405 Don't specify libraries-spec argument if we are passing a platform dill. (flutter/flutter#114045) * e6be983 Roll Plugins from fed9104 to cd8bb0a (9 revisions) (flutter/flutter#114077) * d988c11 Expose `alwaysShowMiddle` in `CupertinoSliverNavigationBar` (flutter/flutter#113544) * 5d93894 [flutter_tools] Decouple fatal-warnings check from fatal-infos (flutter/flutter#113748) * 609b8f3 Revert part of "Terminate simulator app on "q" (#113581)" (flutter/flutter#114083) * 235a325 Provide test API for accessibility announcements (flutter/flutter#109661) * e4a80b4 Roll Flutter Engine from 25133f15440d to 2705bcb4e7d6 (1 revision) (flutter/flutter#114084) * 51acda8 Update Cupertino text input padding (flutter/flutter#113958) * 7bca82c Roll Flutter Engine from 2705bcb4e7d6 to 31d21cbed7b2 (1 revision) (flutter/flutter#114086) * e334ac1 Revert "Update Cupertino text input padding (#113958)" (flutter/flutter#114102) * 671c532 107866: Add support for verifying SemanticsNode ordering in widget tests (flutter/flutter#113133) * 23d258d Remove deprecated `updateSemantics` API usage. (flutter/flutter#113382) * 156c313 Dispose animation controller in platform view benchmarks (flutter/flutter#110413) * 8cd7953 Roll Flutter Engine from 31d21cbed7b2 to a772d20c7550 (12 revisions) (flutter/flutter#114113) * eaecf46 Roll Flutter Engine from a772d20c7550 to 871de2f904a4 (6 revisions) (flutter/flutter#114119) * 732d117 Roll Flutter Engine from 871de2f904a4 to f0eb4f0bae67 (1 revision) (flutter/flutter#114122) * d9a2229 Roll Flutter Engine from f0eb4f0bae67 to 1ea6e5e2de95 (1 revision) (flutter/flutter#114125)

This reverts commit b571abf.

This reverts commit 009fa69.

Relands the "Scribble mixin" PR, which was reverted due to breaking a Google test in the last roll. Breaks the Scribble feature out of TextInputClient in order to avoid breaking changes.

This reverts commit 3cde69e.

…" (#115146) This reverts commit 3cde69e.

)" (flutter#114698)" (flutter#115146) This reverts commit 3cde69e.

This reverts commit 3cde69e.

…114698)" (#115146)" This reverts commit 338841a.

This reverts commit b571abf.

…lutter#114698) Relands the "Scribble mixin" PR, which was reverted due to breaking a Google test in the last roll. Breaks the Scribble feature out of TextInputClient in order to avoid breaking changes.

)" (flutter#114698)" (flutter#115146) This reverts commit 3cde69e.

…lutter#114698) Relands the "Scribble mixin" PR, which was reverted due to breaking a Google test in the last roll. Breaks the Scribble feature out of TextInputClient in order to avoid breaking changes.

)" (flutter#114698)" (flutter#115146) This reverts commit 3cde69e.

justinmc added the work in progress; do not review label May 18, 2022

justinmc self-assigned this May 18, 2022

flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels May 18, 2022

justinmc force-pushed the scribble-mixin branch 2 times, most recently from 10a80aa to 325e911 Compare May 19, 2022 19:33

justinmc mentioned this pull request May 20, 2022

Make TextInputClient a mixin #104291

Merged

justinmc requested review from LongCatIsLooong and Renzo-Olivares May 20, 2022 23:48

justinmc marked this pull request as ready for review June 1, 2022 22:44

justinmc force-pushed the scribble-mixin branch 2 times, most recently from f9b02ce to 2e5c209 Compare June 23, 2022 22:03

Squashed scribble mixin

3824ee1

justinmc force-pushed the scribble-mixin branch from 2e5c209 to 3824ee1 Compare June 23, 2022 22:09

LongCatIsLooong reviewed Jun 23, 2022

View reviewed changes

justinmc added 4 commits June 24, 2022 10:01

Fix references to scribble methods in flutter_test

1289290

No longer any need to initialize TextInput early

d1ff4c7

Code review: docs improvements

8db1a32

Code review: should set client on focus

0d11c7c

justinmc requested a review from LongCatIsLooong July 1, 2022 00:19

LongCatIsLooong reviewed Jul 1, 2022

View reviewed changes

Hixie removed the work in progress; do not review label Aug 15, 2022

justinmc merged commit b571abf into flutter:master Oct 24, 2022

justinmc deleted the scribble-mixin branch October 24, 2022 19:46

engine-flutter-autoroll mentioned this pull request Oct 25, 2022

Roll Flutter from 29397c2c7dbb to 0fe29f585791 (30 revisions) flutter/plugins#6621

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 25, 2022

b571abf Scribble mixin (flutter/flutter#104128)

8937365

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 27, 2022

b571abf Scribble mixin (flutter/flutter#104128)

2e6a9b9

CaseyHillers added a commit that referenced this pull request Nov 3, 2022

Revert "Scribble mixin (#104128)"

21abf0d

This reverts commit b571abf.

CaseyHillers mentioned this pull request Nov 3, 2022

Revert "Scribble mixin" #114647

Merged

CaseyHillers pushed a commit that referenced this pull request Nov 4, 2022

Revert "Scribble mixin (#104128)" (#114647)

009fa69

This reverts commit b571abf.

CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Nov 4, 2022

Revert "Scribble mixin (flutter#104128)" (flutter#114647)

a29a329

This reverts commit b571abf.

CaseyHillers pushed a commit that referenced this pull request Nov 4, 2022

[release] Revert "Scribble mixin (#104128)" (#114647) (#114655)

79fb8c0

This reverts commit b571abf.

justinmc added a commit that referenced this pull request Nov 4, 2022

Revert "Revert "Scribble mixin (#104128)" (#114647)"

ce9d465

This reverts commit 009fa69.

justinmc mentioned this pull request Nov 4, 2022

Reland "Scribble mixin" #114698

Merged

XilaiZhang added a commit that referenced this pull request Nov 11, 2022

Revert "Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)"

60b9759

This reverts commit 3cde69e.

XilaiZhang added a commit that referenced this pull request Nov 11, 2022

Revert "Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)…

338841a

…" (#115146) This reverts commit 3cde69e.

XilaiZhang added a commit to XilaiZhang/flutter that referenced this pull request Nov 11, 2022

Revert "Revert "Revert "Scribble mixin (flutter#104128)" (flutter#114647

e786b54

)" (flutter#114698)" (flutter#115146) This reverts commit 3cde69e.

CaseyHillers pushed a commit that referenced this pull request Nov 11, 2022

[CP] Revert "Scribble mixin (#104128)" (#115162)

45f4192

This reverts commit 3cde69e.

justinmc added a commit that referenced this pull request Nov 14, 2022

Revert "Revert "Revert "Revert "Scribble mixin (#104128)" (#114647)" (#…

581ac42

…114698)" (#115146)" This reverts commit 338841a.

justinmc mentioned this pull request Nov 14, 2022

Reland Scribble mixin #115296

Closed

shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022

Revert "Scribble mixin (flutter#104128)" (flutter#114647)

5a1128b

This reverts commit b571abf.

shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022

Revert "Revert "Revert "Scribble mixin (flutter#104128)" (flutter#114647

87eafb8

)" (flutter#114698)" (flutter#115146) This reverts commit 3cde69e.

gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023

Revert "Revert "Revert "Scribble mixin (flutter#104128)" (flutter#114647

cf7a509

)" (flutter#114698)" (flutter#115146) This reverts commit 3cde69e.

Scribble mixin #104128

Scribble mixin #104128

Uh oh!

Conversation

justinmc commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Background

How to minimize these breaking changes

1. Prefer separate method channels

2. Prefer mixins and with

3. Prefer new composable widgets to an EditableText catch-all

The result

Migration guide

Uh oh!

nilsreichardt commented May 19, 2022

Uh oh!

justinmc commented May 24, 2022

Uh oh!

justinmc commented May 24, 2022

Uh oh!

flutter-dashboard bot commented Jun 22, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc commented Jul 1, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

goderbauer commented Jul 26, 2022

Uh oh!

justinmc commented Aug 10, 2022

Uh oh!

justinmc commented Oct 24, 2022

Uh oh!

Uh oh!

justinmc commented May 18, 2022 •

edited

Loading

2. Prefer mixins and `with`