Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Mac Page Up / Page Down in text fields #105497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinmc merged 18 commits into from
Nov 7, 2022
Merged

Mac Page Up / Page Down in text fields #105497

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d9231ea
Page up/down work in a text input
justinmc Jun 6, 2022
bc588ff
Test for plain pageup/down
justinmc Jun 6, 2022
aa51bb8
Shift + pageup/down
justinmc Jun 7, 2022
fa65891
Test for shift+page and a bugfix
justinmc Jun 7, 2022
e0e1d30
Positional forward param to match DirectionalTextEditingIntent
justinmc Jun 22, 2022
d4bbc34
Use ScrollIntent by overriding ScrollAction
justinmc Jun 22, 2022
a47a9f3
Share increment calculation with ScrollAction
justinmc Jun 22, 2022
a51735d
Shift+page up/down works with single line fields and tests pass
justinmc Jun 22, 2022
d7db2e7
Scrolling in pageup/down is only an Apple feature
justinmc Jun 23, 2022
b8e28cc
(analyzer) remove unused variable
justinmc Jul 13, 2022
7038a69
Merge branch 'master' into pageup-pagedown
justinmc Sep 19, 2022
cb81fee
Only Apple for this PR, and also tie-in with Mac platform shortcuts
justinmc Sep 20, 2022
268447f
Expose only one method: getDirectionalIncrement
justinmc Sep 20, 2022
a05cd81
Only test iOS and Mac now that those are the only platforms that this…
justinmc Sep 20, 2022
11e562e
Analyzer
justinmc Sep 20, 2022
22de84d
Merge branch 'master' into pageup-pagedown
justinmc Nov 4, 2022
adde00f
Remove tests related to shift + pageup/down
justinmc Nov 4, 2022
1f78845
Don't attempt to scroll a field that isn't scrollable (fixes some tests)
justinmc Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into pageup-pagedown
  • Loading branch information
@justinmc
justinmc committed Nov 4, 2022
commit 22de84d4e581fc708f5d1abd8ab7c9708f68529a
8 changes: 4 additions & 4 deletions packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,8 @@ class DefaultTextEditingShortcuts extends StatelessWidget {

const SingleActivator(LogicalKeyboardKey.pageUp): const ScrollIntent(direction: AxisDirection.up, type: ScrollIncrementType.page),
const SingleActivator(LogicalKeyboardKey.pageDown): const ScrollIntent(direction: AxisDirection.down, type: ScrollIncrementType.page),
const SingleActivator(LogicalKeyboardKey.pageUp, shift: true): const ExtendSelectionByPageIntent(forward: false),
const SingleActivator(LogicalKeyboardKey.pageDown, shift: true): const ExtendSelectionByPageIntent(forward: true),
const SingleActivator(LogicalKeyboardKey.pageUp, shift: true): const ExtendSelectionVerticallyToAdjacentPageIntent(forward: false, collapseSelection: false),
const SingleActivator(LogicalKeyboardKey.pageDown, shift: true): const ExtendSelectionVerticallyToAdjacentPageIntent(forward: true, collapseSelection: false),

const SingleActivator(LogicalKeyboardKey.keyX, meta: true): const CopySelectionTextIntent.cut(SelectionChangedCause.keyboard),
const SingleActivator(LogicalKeyboardKey.keyC, meta: true): CopySelectionTextIntent.copy,
Expand Down Expand Up @@ -559,8 +559,8 @@ Intent? intentForMacOSSelector(String selectorName) {

'scrollPageUp:': ScrollIntent(direction: AxisDirection.up, type: ScrollIncrementType.page),
'scrollPageDown:': ScrollIntent(direction: AxisDirection.down, type: ScrollIncrementType.page),
'pageUpAndModifySelection': ExtendSelectionByPageIntent(forward: false),
'pageDownAndModifySelection:': ExtendSelectionByPageIntent(forward: true),
'pageUpAndModifySelection:': ExtendSelectionVerticallyToAdjacentPageIntent(forward: false, collapseSelection: false),
'pageDownAndModifySelection:': ExtendSelectionVerticallyToAdjacentPageIntent(forward: true, collapseSelection: false),

// Escape key when there's no IME selection popup.
'cancelOperation:': DismissIntent(),
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.