"Select All" Automatically scrolls EditableText to the end of the text field, which doesn't happen on native iOS #105799

antholeole · 2022-06-10T18:52:05Z

Fixes:

"Select All" Automatically scrolls EditableText to the end of the text field, which doesn't happen on native iOS #105731

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

antholeole · 2022-06-10T23:28:43Z

packages/flutter/lib/src/widgets/text_selection.dart

@@ -207,7 +207,6 @@ abstract class TextSelectionControls {
  /// by the user.
  void handleSelectAll(TextSelectionDelegate delegate) {
    delegate.selectAll(SelectionChangedCause.toolbar);
-    delegate.bringIntoView(delegate.textEditingValue.selection.extent);


I believe this is redundant: it seems like the default editableTextState.selectAll calls scrollIntoView. Nothing that tests this directly, either

Looks like you're right and it should be removed. I'll be deprecating handleSelectAll soon and hopefully removing the opportunity for things like this to happen.

justinmc

Thanks for fixing this as a small separate PR. Just some small comments and questions but overall it looks good.

justinmc · 2022-06-16T22:21:54Z

packages/flutter/lib/src/widgets/editable_text.dart

@@ -1796,8 +1796,20 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
      ),
      cause,
    );
+
+    /// The only known current platform that does not bring into view is iOS.


This should be a double slash.

justinmc · 2022-06-16T22:33:18Z

packages/flutter/lib/src/widgets/text_selection.dart

@@ -207,7 +207,6 @@ abstract class TextSelectionControls {
  /// by the user.
  void handleSelectAll(TextSelectionDelegate delegate) {
    delegate.selectAll(SelectionChangedCause.toolbar);
-    delegate.bringIntoView(delegate.textEditingValue.selection.extent);


Looks like you're right and it should be removed. I'll be deprecating handleSelectAll soon and hopefully removing the opportunity for things like this to happen.

justinmc · 2022-06-16T22:33:52Z

packages/flutter/lib/src/widgets/text_selection.dart

@@ -529,7 +528,7 @@ class TextSelectionOverlay {
  }
 }

-/// An object that manages a pair of selection handles.
+/// An object that manages a pair of selection handles and a toolbar.


Good catch!

justinmc · 2022-06-16T22:35:35Z

packages/flutter/test/widgets/editable_text_test.dart

-    final TextEditingController controller = TextEditingController(text: text);
-    final ScrollController scrollController = ScrollController();
+  group('Selection changed scroll into view', () {
+      final String text = List<int>.generate(64, (int index) => index).join('\n');


The indentation is wrong here, this should be outdented.

justinmc · 2022-06-16T22:39:22Z

packages/flutter/test/widgets/editable_text_test.dart


-    final TextSelectionDelegate textSelectionDelegate = key.currentState!;
+        /// Populate [maxScrollExtent]


Period here.

justinmc · 2022-06-16T22:42:18Z

packages/flutter/test/widgets/editable_text_test.dart

+      await resetSelectionAndScrollOffset(tester, false);
+      textSelectionDelegate.selectAll(SelectionChangedCause.toolbar);
+      await tester.pump();
+      expect(scrollController.offset.roundToDouble(), maxScrollExtent);


I would have thought that this test would also be run on iOS and that it shouldn't scroll in that case (0.0), but it looks like it's passing so I'm wrong. What am I misunderstanding?

"In a test environment, the platform returned is TargetPlatform.android regardless of the host platform." from here. You're right that this is implicit and looks weird... I read this when I was writing the code, but your comment had me scratching my head for a little because it's so implicit :). I'll explicitly run it on all other platforms but skip mac and iOS.

Or in EditableText should you be switching on Theme.of(context).targetPlatform instead of defaultTargetPlatform?

Talked offline - defaultTargetPlatform seems better in this case

justinmc · 2022-06-16T22:43:33Z

packages/flutter/test/widgets/editable_text_test.dart

+      expect(scrollController.offset, 0.0);
+    }, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.iOS }));


Nit: Would it be useful to run this test on all platforms and put this final expect in a switch to show what the different behavior is? Or maybe that's covered by the next test anyway.

LongCatIsLooong · 2022-06-17T00:12:09Z

packages/flutter/lib/src/widgets/editable_text.dart

@@ -1796,8 +1796,20 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
      ),
      cause,
    );
+
+    /// The only known current platform that does not bring into view is iOS.
    if (cause == SelectionChangedCause.toolbar) {


does Ctrl-A scroll to the end on iOS?

This is a good call - I wasn't thinking about the keyboard on iOS world. I'd need someone else to test and verify, I Don't have access to an iOS device keyboard.

Good call, I'll ask around tomorrow.

Tried on simulator with "Send Keyboard Input to Device" on, it didn't scroll. On macOS it doesn't seem to scroll either (for single/multiline text fields. Only chrome scrolls to the end of the text in its omnibox).

antholeole · 2022-06-17T18:45:32Z

is https://github.com/flutter/flutter/pull/105799/files/dcf6ce3eb645a965d0e3270d18390e64dc25565a..64e5345bb40428e7670d96aadaa5e8fb4a5fe2f3 more or less readable? There's a bunch of post-action logic in a lot of the handlers so maybe we can abstract it out so there's not switch cases everywhere. LMK

Actually scratch this, reverting. This logic is too unique.

justinmc

LGTM 👍

There are two failing tests, but they look like flutter_svg tests that I often see flake. I would guess that rebasing on master and squashing all the commits in this PR or reopening a new PR would make them pass.

packages/flutter/test/widgets/editable_text_test.dart

goderbauer · 2022-07-20T16:50:21Z

(triage): @antholeole can you follow up on the feedback from above so we can get this merged? Thanks!

antholeole · 2022-07-20T18:19:10Z

Yes, sorry. Lots of momentum on loupe, been meaning to come back to this. Switching gears rn

goderbauer · 2022-07-26T22:24:21Z

(Triage): Looks like this is failing a customer test...

antholeole · 2022-07-28T23:30:20Z

Oopsie

justinmc

Renewing my LGTM 👍

…ore (flutter/flutter#105799)

…tter#105799) Co-authored-by: Anthony Oleinik <[email protected]>

antholeole · 2022-10-11T09:23:06Z

Oh wow. Thanks for taking a deeper look. You or Justin will have to show me how to simulate keyboard stuff on simulator :). You’re also right on the MacOS front - good catch on the Omnibox, I was testing there! Will update this PR tomorrow - tyvm!

…

On Jun 16, 2022, at 6:04 PM, LongCatIsLooong ***@***.***> wrote: @LongCatIsLooong commented on this pull request. In packages/flutter/lib/src/widgets/editable_text.dart: > @@ -1796,8 +1796,20 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien ), cause, ); + + /// The only known current platform that does not bring into view is iOS. if (cause == SelectionChangedCause.toolbar) { Tried on simulator with "Send Keyboard Input to Device" on, it didn't scroll. On macOS it doesn't seem to scroll either (for single/multiline text fields. Only chrome scrolls to the end of the text in its omnibox). — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Jun 10, 2022

antholeole mentioned this pull request Jun 10, 2022

Tooltip erroneously disappears when both selection handles are out of view, and erroneously stays visible when one selection handle is in view #105804

Closed

antholeole commented Jun 10, 2022

View reviewed changes

antholeole changed the title ~~Toolbar SelectAll fixes~~ "Select All" Automatically scrolls EditableText to the end of the text field, which doesn't happen on native iOS Jun 10, 2022

antholeole requested review from LongCatIsLooong and Renzo-Olivares and removed request for Renzo-Olivares and LongCatIsLooong June 13, 2022 16:57

justinmc reviewed Jun 16, 2022

View reviewed changes

LongCatIsLooong reviewed Jun 17, 2022

View reviewed changes

antholeole marked this pull request as ready for review June 23, 2022 00:47

goderbauer requested review from LongCatIsLooong and justinmc June 29, 2022 21:41

justinmc approved these changes Jul 1, 2022

View reviewed changes

packages/flutter/test/widgets/editable_text_test.dart Show resolved Hide resolved

packages/flutter/test/widgets/editable_text_test.dart Show resolved Hide resolved

packages/flutter/test/widgets/editable_text_test.dart Outdated Show resolved Hide resolved

antholeole requested review from jmagman, Piinks, christopherfujino and keyonghan as code owners July 28, 2022 23:28

antholeole removed request for LongCatIsLooong, jmagman, Piinks, christopherfujino and keyonghan July 28, 2022 23:29

antholeole force-pushed the 104945 branch from 90e8cda to 34d63ed Compare July 28, 2022 23:48

justinmc approved these changes Jul 28, 2022

View reviewed changes

fix the rebase mishap

4ed91dd

antholeole force-pushed the 104945 branch from 34d63ed to 4ed91dd Compare July 29, 2022 16:22

LongCatIsLooong approved these changes Jul 29, 2022

View reviewed changes

antholeole merged commit db3b141 into flutter:master Jul 29, 2022

engine-flutter-autoroll mentioned this pull request Jul 30, 2022

Roll Flutter from a62ee852950a to 176f7d71306b (28 revisions) flutter/plugins#6161

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022

db3b141 SelectAll on iOS does not scroll to end of editable text anym…

1e66cd1

…ore (flutter/flutter#105799)

engine-flutter-autoroll mentioned this pull request Jul 30, 2022

Roll Flutter from a62ee852950a to 176f7d71306b (28 revisions) flutter/packages#2399

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2022

db3b141 SelectAll on iOS does not scroll to end of editable text anym…

3844304

…ore (flutter/flutter#105799)

engine-flutter-autoroll mentioned this pull request Jul 30, 2022

Roll Flutter from a62ee852950a to ab47f01ff173 (29 revisions) flutter/plugins#6162

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022

db3b141 SelectAll on iOS does not scroll to end of editable text anym…

54c67e8

…ore (flutter/flutter#105799)

antholeole mentioned this pull request Jul 31, 2022

"Select All" Automatically scrolls EditableText to the end of the text field, which doesn't happen on native iOS #105731

Closed

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

SelectAll on iOS does not scroll to end of editable text anymore (flu…

5b84333

…tter#105799) Co-authored-by: Anthony Oleinik <[email protected]>


		final TextSelectionDelegate textSelectionDelegate = key.currentState!;
		/// Populate [maxScrollExtent]

		expect(scrollController.offset, 0.0);
		}, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.iOS }));

"Select All" Automatically scrolls EditableText to the end of the text field, which doesn't happen on native iOS #105799

"Select All" Automatically scrolls EditableText to the end of the text field, which doesn't happen on native iOS #105799

Uh oh!

Conversation

antholeole commented Jun 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

antholeole Jun 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antholeole Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antholeole Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antholeole commented Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

goderbauer commented Jul 20, 2022

Uh oh!

antholeole commented Jul 20, 2022

Uh oh!

goderbauer commented Jul 26, 2022

Uh oh!

antholeole commented Jul 28, 2022

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

antholeole commented Oct 11, 2022 via email

Uh oh!

Uh oh!

antholeole commented Jun 10, 2022 •

edited

Loading

antholeole Jun 10, 2022 •

edited

Loading

antholeole Jun 17, 2022 •

edited

Loading

antholeole Jun 17, 2022 •

edited

Loading

antholeole commented Jun 17, 2022 •

edited

Loading