Cupertino date picker fix for minDate, maxDate when using minuteInterval #105958
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I would like some help with this because I don't understand what fails here |
|
|
||
| await tester.drag(find.text('40'), const Offset(0.0, 32.0), touchSlopY: 0.0, warnIfMissed: false); | ||
| await tester.pump(); // Once to trigger the post frame animate call. | ||
| await tester.pumpAndSettle(); |
There was a problem hiding this comment.
ideally we'd have either two calls to pump (the second with a Duration that spans the animation), or only a call to pumpAndSettle (and we'd verify the return value is what we expect).
|
|
||
| await tester.drag(find.text('50'), const Offset(0.0, -64.0), touchSlopY: 0.0, warnIfMissed: false); | ||
| await tester.pump(); // Once to trigger the post frame animate call. | ||
| await tester.pumpAndSettle(); |
| ), | ||
| ); | ||
|
|
||
| await tester.drag(find.text('40'), const Offset(0.0, 32.0), touchSlopY: 0.0, warnIfMissed: false); |
There was a problem hiding this comment.
might be useful for the next reader to have a comment here explaining what this is doing
|
Sorry it took so long to review. Thanks a ton for the contribution! This looks great, just some trivial tweaks. |
|
(now i need to get a second reviewer to check it over per our process, hopefully won't take long) |
|
thanks, so do I need to do anything else now? |
nope. the PR will auto merge post the completion of the pending |
|
It looks like the google testing shard got stuck here. I checked and it passed, merging manually. |
The Cupertino date picker does not calculate the position of the min-max value correctly when using minuteInterval.
Fixing #97010
Need help to complete this pr as I have not done anything similar in the past
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.