Loupe Android + iOS #106507
Closed
Loupe Android + iOS #106507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antholeole
commented
Jun 24, 2022
| @override | ||
| void updateRenderObject( | ||
| BuildContext context, covariant RenderProxyBox renderObject) { | ||
| (renderObject as _RenderMagnification) |
There was a problem hiding this comment.
Since Magnifier should be public, but _RenderMagnification should not be, this will trigger the "no private members in public API lint`. To workaround, cast the renderObject to it's private subtype.
antholeole
commented
Jun 24, 2022
| /// [Magnifier] may have a [child], which will be drawn over the lens. This is useful | ||
| /// for overlays, like tinting the lens. | ||
| /// | ||
| /// Some caveats for using the magnifier: |
There was a problem hiding this comment.
These caveats seem a little extreme. Maybe we need to talk about not including it in the public API because it might be too hard to use.................................
|
Closing in favor of #107477, which is a branch cherry picked out of this one to not contain Portals or context menu changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loupe! Design doc: https://flutter.dev/go/text-editing-magnifying-glass
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].
Pre-launch Checklist
///).