Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ignore body_might_complete_normally_catch_error violations #106563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2022
Merged

Ignore body_might_complete_normally_catch_error violations #106563

merged 2 commits into from
Jul 29, 2022

Conversation

srawlins
Copy link
Contributor

Ignore body_might_complete_normally_catch_error violations

Related to #105750

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 24, 2022
christopherfujino
christopherfujino approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor

@srawlins are you still planning to land this one? You will probably have to check go/flutter-rob about the pending Google testing check.

@srawlins
Copy link
Contributor Author

I sure am. I've just punched up a master merge.

@srawlins
Copy link
Contributor Author

Or rather, I'm planning for someone to merge it.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 28, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 28, 2022

Validations Fail.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2022
Jasguerrero
Jasguerrero approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jasguerrero Jasguerrero added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 29, 2022
@auto-submit auto-submit bot merged commit 0c57b31 into flutter:master Jul 29, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
0c57b31 Ignore body_might_complete_normally_catch_error violations (f…
2312b8f 
…lutter/flutter#106563)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
0c57b31 Ignore body_might_complete_normally_catch_error violations (f…
f26d673 
…lutter/flutter#106563)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
0c57b31 Ignore body_might_complete_normally_catch_error violations (f…
ec252f9 
…lutter/flutter#106563)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@srawlins @camsim99
Ignore body_might_complete_normally_catch_error violations (flutter#1…
d6ca5a3 
…06563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@Jasguerrero Jasguerrero Jasguerrero approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srawlins @christopherfujino @Jasguerrero