Update ListTile and ListTile based widget docs for Material usage
#107104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Piinks
reviewed
Jul 7, 2022
Piinks
reviewed
Jul 8, 2022
| /// [CheckboxListTile] itself but by the [Material] widget ancestor. | ||
| /// In this case, one can wrap a [Material] widget around the [CheckboxListTile], | ||
| /// e.g.: | ||
| /// |
There was a problem hiding this comment.
I missed this last time, apologies. This should be wrapped in a snippet so it is subject to analysis. That way of we change the code, this will get updated.
Suggested change
| /// | |
| /// | |
| /// {@tool snippet} |
| /// [RadioListTile] itself but by the [Material] widget ancestor. In this | ||
| /// case, one can wrap a [Material] widget around the [RadioListTile], e.g.: | ||
| /// | ||
| /// ```dart |
| /// [SwitchListTile] itself but by the [Material] widget ancestor. In this | ||
| /// case, one can wrap a [Material] widget around the [SwitchListTile], e.g.: | ||
| /// | ||
| /// ```dart |
Piinks
reviewed
Jul 8, 2022
There was a problem hiding this comment.
Ah it looks like turning those into snippets did find some analysis errors! :)
Check the analyzer failure. I noticed some of them are related to undefined variables. To handle these ones, look in the codebase for // Examples can assume: That defines variables for snippets like these.
40f09f2 to
5341615
Compare
This was referenced Jul 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 13, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: #102310
closes #105760
related #106955
This PR updated
ListTileMaterial explanation and adds it to other ListTile based widgets such asCheckboxListTile,RadioListTile, andSwitchListTileInstead of turning the ListTile doc explanation into the template, I'm reusing the
ListTiledoc with modifications along with a suitable code snippet.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.