Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add SafeArea for NavigationRail #107605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2022
Merged

Add SafeArea for NavigationRail #107605

merged 2 commits into from
Jul 19, 2022

Conversation

QuncCccccc
Copy link
Contributor

This pr adds a SafeArea for NavigationRail component so that the NavigationRail will not be covered by notch/system navigation bar in landscape mode.

Screen Shot 2022-07-13 at 5 50 20 PM

Fixes #107407.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 14, 2022
@QuncCccccc QuncCccccc marked this pull request as ready for review July 14, 2022 17:53
guidezpl
guidezpl approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@QuncCccccc QuncCccccc requested a review from guidezpl July 14, 2022 23:44
@QuncCccccc QuncCccccc merged commit 2b621e1 into flutter:master Jul 19, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
708a3c9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
26a45d9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
ff68543
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
28bc111
@thilojaeggi
Copy link

The NavigationRail is now much wider even when not on the side of the notch. It's a solution, but not the prettiest one.
Is this intended?

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
16e5dc1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
04ba4b4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
881192d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
830ebc1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
b42e528
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
2429aae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
50cfda5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
05bde81
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
16f5e55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
e47811c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
13d5cdc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
6ad67a4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
4ec982e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
739e632
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
366a8b2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
9cacedd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
8249f72
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
3e18bd4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
4df86d8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
e0bd665
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
5dfb1ed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
2c93f1f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
9947878
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
25e6ee1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
c9bb5ea
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
36de31f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
b0674c1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
4791909
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
4a4ad60
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
72a23b0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
7add69c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
62835ae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2b621e1 Add SafeArea for NavigationRail (flutter/flutter#107605)
8d80859
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@QuncCccccc @camsim99
Add SafeArea for NavigationRail (flutter#107605)
50218bd 
* Added SafeArea for NavigationRail

Co-authored-by: Qun Cheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

@guidezpl guidezpl Awaiting requested review from guidezpl

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NavigationRail is covered by notch, still not resovled
3 participants
@QuncCccccc @thilojaeggi @guidezpl