Fixes a NestedScrollView UserScrollNotification issue #107632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
approved these changes
Jul 19, 2022
| // Regression test for https://github.com/flutter/flutter/issues/107101 | ||
| final List<ScrollDirection> receivedResult = <ScrollDirection>[]; | ||
| const List<ScrollDirection> expectedReverseResult = <ScrollDirection>[ScrollDirection.reverse, ScrollDirection.idle]; | ||
| const List<ScrollDirection> expectedFrowardResult = <ScrollDirection>[ScrollDirection.forward, ScrollDirection.idle]; |
There was a problem hiding this comment.
Typo nit:
Suggested change
| const List<ScrollDirection> expectedFrowardResult = <ScrollDirection>[ScrollDirection.forward, ScrollDirection.idle]; | |
| const List<ScrollDirection> expectedForwardResult = <ScrollDirection>[ScrollDirection.forward, ScrollDirection.idle]; |
|
@Piinks Hi, Could you help restart the G-test? |
|
@xu-baolin For some reason the "Google testing" check didn't trigger correctly. Could you rebase this PR with the latest master and push it up again? That will re-trigger the check. Sorry about this... |
|
|
Test flakes issue -> #97316 |
This was referenced Jul 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107101
We do not notify the idle state if ending the drag with a velocity.
We only notify the idle state if no scrolling occurs when the drag ends.
flutter/packages/flutter/lib/src/widgets/nested_scroll_view.dart
Lines 656 to 658 in 5a5d021