fix: bottom navigation bar colors #107924
Conversation
a459810 to
7ef27d6
Compare
There was a problem hiding this comment.
@talamaska thanks for the contribution. Sorry for the lag on the review.
This mostly looks good. I am not a fan of the useLegacyColorScheme type flags, but I assume this is to work around a breaking change?
|
@darrenaustin implemented the suggestions. |
add: _effectiveIconTheme function add: logic for setting the effective selected/unselected icon theme change: color tweens to use the effective label style color if not null change: use the new effective selected/unselected Icon theme when generating _BottomNavigationTile add: tests to capture the issues with the label style color, matching the docs fix: BottomNavigationBarItem title's color is not overriden neither by selectedLabelStyle nor unselectedLabelStyle remove: trailing space implement PR suggestions add: more documentation for the useLegacyColorScheme flag change: simplify effectiveIconTheme
a65cd6c to
20efa67
Compare
…colors' into fix/64358-bottom-navigation-bar-colors
|
@darrenaustin @Hixie Am I going to wait for another 6 months for someone to finalize the review and merge this PR. The contributing experience so far is not the greatest one. |
@talamaska my sincerest apologies. This is entirely my fault for letting this languish so long. I should have responded in a more timely manner. I will strive to do better in the future. We do appreciate your contribution. Thx. |
@darrenaustin thank you for responding. I apologize for my harsh comment. In my defense I really tried to be patient to this point |
|
@darrenaustin when can I expect this merged? |
Not at all, it was completely justified frustration. Again, my apologies.
Done. Not sure why it didn't automerge after the review, I thought the label was set on it. |
|
@darrenaustin any idea when this can end up in stable? I don't see it in Beta as well. It is still just in master |
|
Hm, just ran into this, too. It's a rather old bug. Interesting. |
It was released in stable. Could you please try setting useLegacyColorScheme to false. The issue should be resolved. |
|
Moved to SnakeNavigationBar meanwhile... |
add: _effectiveIconTheme function
add: logic for setting the effective selected/unselected icon theme
change: use the new effective selected/unselected Icon theme when generating _BottomNavigationTile
change: create separate tweens for the icon and for the label
add: tests to capture the issues with the label style color, matching the docs
fix: BottomNavigationBarItem label's color is not overridden neither by selectedLabelStyle nor unselectedLabelStyle
add: legacy flag for preserving the old behavior
#64358
#107925
#27753
Pre-launch Checklist
///).