-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Allow setting of TestWidgetsFlutterBinding.pointerEventSource #107976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test.
/cc @goderbauer fyi
3cd7e05
to
acf6bf0
Compare
@dnfield Hey Dan! I added a test that pretty much checks that the value can be set. Is that alright? |
acf6bf0
to
33935b9
Compare
Also cc @jiahaog |
Going to revert this - @goderbauer says hes' going to add some valid concerns we discussed offline. |
I would have expected that customers would create their own binding subclass here with a feature like that and use those in the test (at least as a one-off until we implement a proper solution for this). The change as it stands is currently making it too easy to leak state between tests. It is also missing proper documentation around what it means to change this property. The whole API seems easy to miss-use as designed. Furthermore, to fully fix the original problem we should think about what we can do to properly recognize pointer events coming from adb to have those actually drive the test instead of hacking into the pointer event handling of the test framework. |
…flutter#107976)" (flutter#108038) This reverts commit 641f4e2.
Solves #107934.
This PR allows setting of TestWidgetsFlutterBinding.pointerEventSource.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.