Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Tamil DateTime representation of AM/PM #108185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

thkim1011
Copy link
Contributor

@thkim1011 thkim1011 commented Jul 22, 2022

See title. This PR changes AM/PM strings for the Tamil language so that use of TimeOfDay.format() gives a more accurate representation of the time. See https://icu4c-demos.unicode.org/icu-bin/locexp?d_=en&_=ta_IN for more information.

Fixes #108125

Also waiting on linguist to confirm that this is the correct expected behavior.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Jul 22, 2022
@thkim1011 thkim1011 requested a review from HansMuller July 22, 2022 18:34
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is a temporary fix, and update to generated code that should be overwritten by the same fix, once Google's official Translation Console translations have been submitted.

@thkim1011 thkim1011 merged commit e3b851a into flutter:master Jul 25, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@thkim1011 thkim1011 deleted the tae/ta-localization branch July 25, 2022 21:19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
stuartmorgan-g pushed a commit to flutter/plugins that referenced this pull request Jul 27, 2022
* 2142b2e Roll Flutter Engine from cd7e2ec4037b to c31036f2381c (1 revision) (flutter/flutter#108299)

* 178e444 Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" (flutter/flutter#108262)

* 8a7b359 flutter update-packages --force-upgrade + analyzer fix (flutter/flutter#108198)

* b3f5d3f Roll Flutter Engine from c31036f2381c to 54b0ac3059bf (1 revision) (flutter/flutter#108302)

* 2f4299a [flutter_tools] Remove unused parameter when connected DAP to VM Service (flutter/flutter#108285)

* e74b9b5 Migrate InputDecorator to Material 3 (flutter/flutter#107943)

* e3b851a Fix Tamil DateTime representation of AM/PM (flutter/flutter#108185)

* 43d6e2b Roll Flutter Engine from 54b0ac3059bf to 705072522c00 (4 revisions) (flutter/flutter#108308)

* 6929ad1 Roll Flutter Engine from 705072522c00 to 3964cf62cdf8 (1 revision) (flutter/flutter#108316)

* 5f67b47 [iOS] Update template icons (flutter/flutter#107873)

* 606954d Added iconSize parameter in ButtonStyle (flutter/flutter#108268)

* b3814c7 Roll Flutter Engine from 3964cf62cdf8 to 7f8925b1f6f3 (2 revisions) (flutter/flutter#108320)

* ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (flutter/flutter#108197)

* d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (flutter/flutter#108349)

* 4056d3f Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (flutter/flutter#105280)

* b035ef1 [flutter_tools] Remove more shuffles (flutter/flutter#107759)

* be14858 Roll Flutter Engine from 7f8925b1f6f3 to 8eca26d130a2 (1 revision) (flutter/flutter#108326)

* 3eb638f Roll Flutter Engine from 8eca26d130a2 to f1f9b4de82b6 (5 revisions) (flutter/flutter#108350)

* 401b556 Roll Flutter Engine from f1f9b4de82b6 to 11d927ac3e9b (2 revisions) (flutter/flutter#108353)

* 925bee9 Roll Flutter Engine from 11d927ac3e9b to 5dcaeae6561b (1 revision) (flutter/flutter#108356)

* 5d31b07 [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (flutter/flutter#108310)

* c8b5d10 Roll Flutter Engine from 5dcaeae6561b to 89e117b89c63 (1 revision) (flutter/flutter#108367)

* e3d08fb Hide the debug banner in the PopupMenuButton example (flutter/flutter#108324)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
* init

* testS

* init

* accidentally committed wrong file
yutaaraki-toydium pushed a commit to yutaaraki-toydium/plugins that referenced this pull request Aug 12, 2022
* 2142b2e Roll Flutter Engine from cd7e2ec4037b to c31036f2381c (1 revision) (flutter/flutter#108299)

* 178e444 Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" (flutter/flutter#108262)

* 8a7b359 flutter update-packages --force-upgrade + analyzer fix (flutter/flutter#108198)

* b3f5d3f Roll Flutter Engine from c31036f2381c to 54b0ac3059bf (1 revision) (flutter/flutter#108302)

* 2f4299a [flutter_tools] Remove unused parameter when connected DAP to VM Service (flutter/flutter#108285)

* e74b9b5 Migrate InputDecorator to Material 3 (flutter/flutter#107943)

* e3b851a Fix Tamil DateTime representation of AM/PM (flutter/flutter#108185)

* 43d6e2b Roll Flutter Engine from 54b0ac3059bf to 705072522c00 (4 revisions) (flutter/flutter#108308)

* 6929ad1 Roll Flutter Engine from 705072522c00 to 3964cf62cdf8 (1 revision) (flutter/flutter#108316)

* 5f67b47 [iOS] Update template icons (flutter/flutter#107873)

* 606954d Added iconSize parameter in ButtonStyle (flutter/flutter#108268)

* b3814c7 Roll Flutter Engine from 3964cf62cdf8 to 7f8925b1f6f3 (2 revisions) (flutter/flutter#108320)

* ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (flutter/flutter#108197)

* d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (flutter/flutter#108349)

* 4056d3f Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (flutter/flutter#105280)

* b035ef1 [flutter_tools] Remove more shuffles (flutter/flutter#107759)

* be14858 Roll Flutter Engine from 7f8925b1f6f3 to 8eca26d130a2 (1 revision) (flutter/flutter#108326)

* 3eb638f Roll Flutter Engine from 8eca26d130a2 to f1f9b4de82b6 (5 revisions) (flutter/flutter#108350)

* 401b556 Roll Flutter Engine from f1f9b4de82b6 to 11d927ac3e9b (2 revisions) (flutter/flutter#108353)

* 925bee9 Roll Flutter Engine from 11d927ac3e9b to 5dcaeae6561b (1 revision) (flutter/flutter#108356)

* 5d31b07 [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (flutter/flutter#108310)

* c8b5d10 Roll Flutter Engine from 5dcaeae6561b to 89e117b89c63 (1 revision) (flutter/flutter#108367)

* e3d08fb Hide the debug banner in the PopupMenuButton example (flutter/flutter#108324)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
* 2142b2e Roll Flutter Engine from cd7e2ec4037b to c31036f2381c (1 revision) (flutter/flutter#108299)

* 178e444 Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" (flutter/flutter#108262)

* 8a7b359 flutter update-packages --force-upgrade + analyzer fix (flutter/flutter#108198)

* b3f5d3f Roll Flutter Engine from c31036f2381c to 54b0ac3059bf (1 revision) (flutter/flutter#108302)

* 2f4299a [flutter_tools] Remove unused parameter when connected DAP to VM Service (flutter/flutter#108285)

* e74b9b5 Migrate InputDecorator to Material 3 (flutter/flutter#107943)

* e3b851a Fix Tamil DateTime representation of AM/PM (flutter/flutter#108185)

* 43d6e2b Roll Flutter Engine from 54b0ac3059bf to 705072522c00 (4 revisions) (flutter/flutter#108308)

* 6929ad1 Roll Flutter Engine from 705072522c00 to 3964cf62cdf8 (1 revision) (flutter/flutter#108316)

* 5f67b47 [iOS] Update template icons (flutter/flutter#107873)

* 606954d Added iconSize parameter in ButtonStyle (flutter/flutter#108268)

* b3814c7 Roll Flutter Engine from 3964cf62cdf8 to 7f8925b1f6f3 (2 revisions) (flutter/flutter#108320)

* ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (flutter/flutter#108197)

* d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (flutter/flutter#108349)

* 4056d3f Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (flutter/flutter#105280)

* b035ef1 [flutter_tools] Remove more shuffles (flutter/flutter#107759)

* be14858 Roll Flutter Engine from 7f8925b1f6f3 to 8eca26d130a2 (1 revision) (flutter/flutter#108326)

* 3eb638f Roll Flutter Engine from 8eca26d130a2 to f1f9b4de82b6 (5 revisions) (flutter/flutter#108350)

* 401b556 Roll Flutter Engine from f1f9b4de82b6 to 11d927ac3e9b (2 revisions) (flutter/flutter#108353)

* 925bee9 Roll Flutter Engine from 11d927ac3e9b to 5dcaeae6561b (1 revision) (flutter/flutter#108356)

* 5d31b07 [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (flutter/flutter#108310)

* c8b5d10 Roll Flutter Engine from 5dcaeae6561b to 89e117b89c63 (1 revision) (flutter/flutter#108367)

* e3d08fb Hide the debug banner in the PopupMenuButton example (flutter/flutter#108324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeOfDay.format() localization issue in language 'ta'
2 participants