Only run pod install on the first iOS build
#108205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Jul 23, 2022
| @@ -11,15 +11,15 @@ import 'test_utils.dart'; | |||
|
|
|||
| void main() { | |||
| test('flutter build ios --config only updates generated xcconfig file without performing build', () async { | |||
| final String workingDirectory = fileSystem.path.join(getFlutterRoot(), 'examples', 'hello_world'); | |||
| final String workingDirectory = fileSystem.path.join(getFlutterRoot(), 'dev', 'integration_tests', 'flutter_gallery'); | |||
There was a problem hiding this comment.
Change to example project that has pods.
This comment was marked as outdated.
This comment was marked as outdated.
jmagman
commented
Jul 25, 2022
78a9880 to
e0b7cb1
Compare
pod install on the first iOS build
jmagman
commented
Jul 26, 2022
| _fileSystem.file(fingerprintPath).writeAsStringSync(fingerprint.toJson()); | ||
| final File fingerprintFile = _fileSystem.file(fingerprintPath); | ||
| fingerprintFile.createSync(recursive: true); | ||
| fingerprintFile.writeAsStringSync(fingerprint.toJson()); |
There was a problem hiding this comment.
Fingerprint write error: FileSystemException: Cannot open file, path = 'build/ios/pod_inputs.fingerprint' (OS Error: No such file or directory, errno = 2)
writeAsStringSync wasn't recursively creating the directory structure. This write succeeded after the first successful build.
jmagman
commented
Jul 26, 2022
| testWithoutContext('fingerprint does match if identical', () { | ||
| fileSystem.file('a.dart').createSync(); | ||
| fileSystem.file('b.dart').createSync(); | ||
|
|
||
| const String fingerprintPath = 'path/to/out.fingerprint'; |
There was a problem hiding this comment.
This test failed on master.
christopherfujino
approved these changes
Jul 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 28, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pod installis skipped based on SHAs stored in a fingerprint file. Fix the bug where the fingerprint file isn't being written to the first time when the directory structure isn't created.pod installwhenGenerated.xcconfigchanges. The build settings in the file should not impact any of the dependencies anymore, and that file changes all the time like every time you run a differentintegration_testtest.Fixes #108202
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.