Set Xcode build script phases to always run #108331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Jul 26, 2022
Comment on lines
+46
to
+47
| <key>UIApplicationSupportsIndirectInputEvents</key> | ||
| <true/> |
| @@ -386,7 +387,7 @@ | |||
| GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; | |||
| GCC_WARN_UNUSED_FUNCTION = YES; | |||
| GCC_WARN_UNUSED_VARIABLE = YES; | |||
| MACOSX_DEPLOYMENT_TARGET = 10.11; | |||
| MACOSX_DEPLOYMENT_TARGET = 10.13; | |||
jmagman
commented
Jul 26, 2022
| @@ -3,7 +3,7 @@ | |||
| archiveVersion = 1; | |||
| classes = { | |||
| }; | |||
| objectVersion = 50; | |||
| objectVersion = 54; | |||
There was a problem hiding this comment.
Most of these files changes are the example/integration test apps being updated.
| @@ -20,6 +20,8 @@ import '../flutter_manifest.dart'; | |||
| import '../globals.dart' as globals; | |||
| import '../macos/cocoapod_utils.dart'; | |||
| import '../macos/xcode.dart'; | |||
| import '../migrations/xcode_project_object_version_migration.dart'; | |||
There was a problem hiding this comment.
This is where the actual tool migration logic starts.
| @@ -2,14 +2,14 @@ | |||
| // Use of this source code is governed by a BSD-style license that can be | |||
There was a problem hiding this comment.
Moved this file out of ios directory since it's now used for iOS and macOS
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 28, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate iOS and macOS Xcode projects to avoid new warning in Xcode 14 when the script build phase
Based on dependency analysischeckbox is checked, but there's no input/output dependencies set up.flutter assembleknows which steps to run with various fingerprints, so unchecked is correct. Under the covers, unchecking that checkbox setsalwaysOutOfDate = 1in the project.This also required
objectVersionin the project to be54, presumably the version that introducedalwaysOutOfDate.Build all iOS and macOS example/test projects to prove this works. This also picked up a few previous migrations that were never run and checked in.
Similar to previous #90304 and #88074
Fixes #108321
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.