Only show iOS simulators, reduce output spew in verbose #108345

jmagman · 2022-07-26T03:46:19Z

Reduce a lot of the verbose flutter run/test/drive spew by only querying for available, booted iOS simulators since that's the only way these simulators are used. This also avoids showing watchOS/tvOS running simulators as available targets in the IDE.

This should make verbose logging easier to read and more concise. Bonus: less data to upload in LUCI.

Before (2300 lines)

After (80 lines)

[   +2 ms] xcrun simctl list devices booted iOS --json
[        ] executing: xcrun simctl list devices booted iOS --json
[   +5 ms] executing: xcrun simctl list devices booted
[ +245 ms] Exit code 0 from: xcrun simctl list devices booted
[        ] == Devices ==
           -- iOS 12.4 --
           -- iOS 13.0 --
           -- iOS 14.0 --
               iPhone 11 (9EC90A99-6924-472D-8CDD-4D8234AB4779) (Booted)
           -- iOS 16.0 --
               Phone w Watch (C82680B9-9C3B-41F8-A0B9-4441E64DC209) (Booted)
               iPhone 13 (C5CA91DB-9D86-4934-AB78-2628C2734F96) (Booted)
           -- tvOS 16.0 --
           -- watchOS 9.0 --
               Apple Watch Series 7 - 45mm (3766BB11-4E3D-409C-AC38-262037345CD7) (Booted)
[  +67 ms] List of devices attached
[ +239 ms] {
                      "devices" : {
                        "com.apple.CoreSimulator.SimRuntime.iOS-14-0" : [
                          {
                            "lastBootedAt" : "2022-07-26T02:43:00Z",
                            "dataPath" : "\/Users\/magder\/Library\/Developer\/CoreSimulator\/Devices\/9EC90A99-6924-472D-8CDD-4D8234AB4779\/data",
                            "dataPathSize" : 1734352896,
                            "logPath" : "\/Users\/magder\/Library\/Logs\/CoreSimulator\/9EC90A99-6924-472D-8CDD-4D8234AB4779",
                            "udid" : "9EC90A99-6924-472D-8CDD-4D8234AB4779",
                            "isAvailable" : true,
                            "logPathSize" : 9502720,
                            "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPhone-11",
                            "state" : "Booted",
                            "name" : "iPhone 11"
                          }
                        ],
                        "com.apple.CoreSimulator.SimRuntime.iOS-13-0" : [

                        ],
                        "com.apple.CoreSimulator.SimRuntime.iOS-12-4" : [

                        ],
                        "com.apple.CoreSimulator.SimRuntime.tvOS-16-0" : [

                        ],
                        "com.apple.CoreSimulator.SimRuntime.watchOS-9-0" : [

                        ],
                        "com.apple.CoreSimulator.SimRuntime.iOS-16-0" : [
                          {
                            "lastBootedAt" : "2022-07-26T02:50:32Z",
                            "dataPath" : "\/Users\/magder\/Library\/Developer\/CoreSimulator\/Devices\/C82680B9-9C3B-41F8-A0B9-4441E64DC209\/data",
                            "dataPathSize" : 427372544,
                            "logPath" : "\/Users\/magder\/Library\/Logs\/CoreSimulator\/C82680B9-9C3B-41F8-A0B9-4441E64DC209",
                            "udid" : "C82680B9-9C3B-41F8-A0B9-4441E64DC209",
                            "isAvailable" : true,
                            "logPathSize" : 90112,
                            "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPhone-11",
                            "state" : "Booted",
                            "name" : "Phone w Watch"
                          },
                          {
                            "lastBootedAt" : "2022-07-26T02:43:06Z",
                            "dataPath" : "\/Users\/magder\/Library\/Developer\/CoreSimulator\/Devices\/C5CA91DB-9D86-4934-AB78-2628C2734F96\/data",
                            "dataPathSize" : 2183602176,
                            "logPath" : "\/Users\/magder\/Library\/Logs\/CoreSimulator\/C5CA91DB-9D86-4934-AB78-2628C2734F96",
                            "udid" : "C5CA91DB-9D86-4934-AB78-2628C2734F96",
                            "isAvailable" : true,
                            "logPathSize" : 151552,
                            "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPhone-13",
                            "state" : "Booted",
                            "name" : "iPhone 13"
                          }
                        ]
                      }
                    }

Deleted some dead code.
Stop checking for Xcode minimum version just to list devices. It will immediately fail if you try to run on one if the version is too low.

Fixes #108342

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2022-07-26T03:52:08Z

packages/flutter_tools/lib/src/ios/simulators.dart

-///
-/// Simulated device types can be listed using the command
-/// `xcrun simctl list devicetypes`.
-class SimDeviceType {


This is dead. Introduced in #2682 usage removed in #10780.

jmagman · 2022-07-26T03:52:22Z

packages/flutter_tools/lib/src/ios/simulators.dart

-
-  final String name;
-
-  static const SimControlListSection devices = SimControlListSection._('devices');


Only devices was used, remove this class and use the string instead.

jmagman · 2022-07-26T03:53:12Z

packages/flutter_tools/lib/src/ios/simulators.dart


    final List<String> command = <String>[
      ..._xcode.xcrunCommand(),
      'simctl',
      'list',
+      'devices',
+      'booted',


Limiting to booted iOS devices since that's all we care about.

jmagman · 2022-07-26T03:53:32Z

packages/flutter_tools/lib/src/ios/simulators.dart

@@ -156,30 +170,24 @@ class SimControl {
    }
  }

-  /// Returns a list of all available devices, both potential and connected.
-  Future<List<SimDevice>> getDevices() async {


getDevices was only used by getConnectedDevices and tests, so remove the former.

christopherfujino

Nice, LGTM!

…ter/flutter#108345)

jmagman added the t: xcode "xcodebuild" on iOS and general Xcode project management label Jul 26, 2022

jmagman self-assigned this Jul 26, 2022

flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 26, 2022

jmagman changed the title ~~Limit simulator output spew~~ Limit iOS simulator output spew in verbose Jul 26, 2022

jmagman changed the title ~~Limit iOS simulator output spew in verbose~~ Only show iOS simulators, reduce output spew in verbose Jul 26, 2022

jmagman force-pushed the simctl-output branch from 5a41dd0 to 118c46c Compare July 26, 2022 04:08

jmagman commented Jul 26, 2022

View reviewed changes

jmagman added 3 commits July 26, 2022 11:06

Limit simulator output spew

51ccce3

Fix test

9d27add

Another test

333fdad

jmagman force-pushed the simctl-output branch from 118c46c to 333fdad Compare July 26, 2022 18:16

jmagman requested review from christopherfujino and cyanglaz July 26, 2022 18:49

christopherfujino approved these changes Jul 26, 2022

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 26, 2022

auto-submit bot merged commit 167655e into flutter:master Jul 26, 2022

jmagman deleted the simctl-output branch July 26, 2022 19:09

engine-flutter-autoroll mentioned this pull request Jul 27, 2022

Roll Flutter from fe16c206ea19 to 183141fcb76c (25 revisions) flutter/packages#2393

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2022

167655e Only show iOS simulators, reduce output spew in verbose (flut…

5425ae5

…ter/flutter#108345)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 28, 2022

167655e Only show iOS simulators, reduce output spew in verbose (flut…

a84102a

…ter/flutter#108345)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Only show iOS simulators, reduce output spew in verbose (flutter#108345)

4dc1baf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Only show iOS simulators, reduce output spew in verbose #108345

Only show iOS simulators, reduce output spew in verbose #108345

Uh oh!

jmagman commented Jul 26, 2022 •

edited

Loading

Uh oh!

jmagman Jul 26, 2022

Uh oh!

jmagman Jul 26, 2022

Uh oh!

jmagman Jul 26, 2022

Uh oh!

christopherfujino Jul 26, 2022

Uh oh!

jmagman Jul 26, 2022

Uh oh!

christopherfujino left a comment

Uh oh!

Uh oh!


		final String name;

		static const SimControlListSection devices = SimControlListSection._('devices');

Only show iOS simulators, reduce output spew in verbose #108345

Only show iOS simulators, reduce output spew in verbose #108345

Uh oh!

Conversation

jmagman commented Jul 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

jmagman Jul 26, 2022

Choose a reason for hiding this comment

Uh oh!

jmagman Jul 26, 2022

Choose a reason for hiding this comment

Uh oh!

jmagman Jul 26, 2022

Choose a reason for hiding this comment

Uh oh!

christopherfujino Jul 26, 2022

Choose a reason for hiding this comment

Uh oh!

jmagman Jul 26, 2022

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmagman commented Jul 26, 2022 •

edited

Loading