Update docs on ChangeNotifier.dispose and KeepAliveHandle.release #108384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
reviewed
Jul 26, 2022
| @@ -321,6 +321,9 @@ class KeepAliveNotification extends Notification { | |||
| class KeepAliveHandle extends ChangeNotifier { | |||
| /// Trigger the listeners to indicate that the widget | |||
| /// no longer needs to be kept alive. | |||
| /// | |||
| /// This method does not call [dispose]. When the handle is not needed | |||
| /// anymore, it must be [dispose]d regardless of whether notifying listeners. | |||
There was a problem hiding this comment.
Should we just fix this by deprecating release and overriding dispose to call notifyListeners before super.dispose?
There was a problem hiding this comment.
I think that makes sense. I wasn't clear on what if anything that would break.
There was a problem hiding this comment.
Do you want me to do that in this PR or should we file an issue/follow up?
There was a problem hiding this comment.
I would prefer doing it in this PR, but I would be fine either way.
|
ARgh, we should not be calling both release and dispose now though since that will notify listeners twice... |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 28, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Hixie
reviewed
May 3, 2023
| @@ -354,7 +367,6 @@ mixin AutomaticKeepAliveClientMixin<T extends StatefulWidget> on State<T> { | |||
|
|
|||
| void _releaseKeepAlive() { | |||
| // Dispose and release do not imply each other. | |||
There was a problem hiding this comment.
well this comment definitely seems out of place now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/flutter/flutter/pull/108227/files#r930193822
@polina-c FYI