TextPainter throw with stack trace to help track down read-before-layout #108571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Jul 28, 2022
Comment on lines
656
to
658
| if (!_systemFontsChangeScheduled) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Do we need this guard? It looks like you only schedule the callback when _systemFontsChangeScheduled is false, and the only way to reset it back to false is in the callback. Is it ever possible that we have a callback scheduled but don't want to run it anymore?
Maybe just turn this into an assert?
…t-changes-between-frames
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 30, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #108029
Also defer
RenderParagraph.systemFontsDidChangeto transient frame callbacks so hit-tests / gestures / post frame callbacks can safely read text layout.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.