Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve dumpSemanticsTree error when semantics are unavailable #108574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 29, 2022
Merged

Improve dumpSemanticsTree error when semantics are unavailable #108574

merged 4 commits into from
Jul 29, 2022

Conversation

goderbauer
Copy link
Member

Fixes #108494.

@goderbauer goderbauer requested a review from Piinks July 28, 2022 19:58
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 28, 2022
Piinks
Piinks reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are some existing tests failing here that expect the old error message.

@goderbauer goderbauer requested a review from Piinks July 29, 2022 17:06
Piinks
Piinks approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM-cat

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 29, 2022
@auto-submit auto-submit bot merged commit c7498f6 into flutter:master Jul 29, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
c7498f6 Improve dumpSemanticsTree error when semantics are unavailable (
6e5d217 
flutter/flutter#108574)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
c7498f6 Improve dumpSemanticsTree error when semantics are unavailable (
128fe67 
flutter/flutter#108574)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
c7498f6 Improve dumpSemanticsTree error when semantics are unavailable (
1741e7e 
flutter/flutter#108574)
@goderbauer goderbauer deleted the semanticsError branch August 8, 2022 16:57
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@goderbauer @camsim99
Improve dumpSemanticsTree error when semantics are unavailable (flutt…
5d12d74 
…er#108574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more details to "Semantics not collected." error
2 participants
@goderbauer @Piinks