Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[platform_view]add android deps to platform view test #108585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2022
Merged

[platform_view]add android deps to platform view test #108585

merged 1 commit into from
Jul 28, 2022

Conversation

hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Jul 28, 2022 •
edited
Loading

deviceOperatingSystem = .ios does not work because it's asking for ios device.

if we do not set deviceOperatingSystem = .ios; then deviceOperatingSystem is default to use android.

So we will need to add dependencies to android.

List which issues are fixed by this PR. You must list at least one issue.

#106745 (comment)

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hellohuanlin hellohuanlin requested a review from keyonghan as a code owner July 28, 2022 22:43
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 28, 2022
@hellohuanlin hellohuanlin requested a review from jmagman July 28, 2022 22:43
jmagman
jmagman approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try it

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2022
@auto-submit auto-submit bot merged commit b00bfef into master Jul 28, 2022
@auto-submit auto-submit bot deleted the huan_native_platform_view_ui_tests_ios_remove_device branch July 28, 2022 23:42
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
b00bfef [platform_view]add android deps to platform view test (flutte…
a23012a 
…r/flutter#108585)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
b00bfef [platform_view]add android deps to platform view test (flutte…
6c16a5b 
…r/flutter#108585)
@jmagman jmagman mentioned this pull request Jul 29, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@hellohuanlin @camsim99
[platform_view]add android deps to platform view test (flutter#108585)
d23d759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellohuanlin @jmagman