Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Quick Documentation Fix for Sliver #108633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2022
Merged

Quick Documentation Fix for Sliver #108633

merged 2 commits into from
Jul 29, 2022

Conversation

youssef-attia
Copy link
Contributor

@youssef-attia youssef-attia commented Jul 29, 2022 •
edited
Loading

Small fix in documentation for SliverChildListDelegate

#108619

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Jul 29, 2022
Piinks
Piinks reviewed Jul 29, 2022
View reviewed changes
@Piinks
Copy link
Contributor

Piinks commented Jul 29, 2022

Hey @youssef-attia the flutter_plugins failure here is not internal, it is from flutter/plugins here on github. The failure does not have to do with your PR, but you will need to update you branch here with the latest from master for it to pass.

Piinks
Piinks approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@Piinks Piinks added autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ documentation labels Jul 29, 2022
@auto-submit auto-submit bot merged commit 5da997e into flutter:master Jul 29, 2022
@youssef-attia youssef-attia deleted the sliverQuickDocumentationFix branch July 29, 2022 22:03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
5da997e Quick Documentation Fix for Sliver (flutter/flutter#108633)
bf7a7d9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
5da997e Quick Documentation Fix for Sliver (flutter/flutter#108633)
4a526bf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
5da997e Quick Documentation Fix for Sliver (flutter/flutter#108633)
dea412a
@youssef-attia youssef-attia linked an issue Aug 1, 2022 that may be closed by this pull request
Typo in documentation for SliverChildListDelegate #108619
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@youssef-attia @camsim99
Quick Documentation Fix for Sliver (flutter#108633)
79807b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in documentation for SliverChildListDelegate
2 participants
@youssef-attia @Piinks