Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Auto-submit pub packages autoroll PRs #108635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

christopherfujino
Copy link
Contributor

Part of #106371

I've been manually reviewing and approving these PRs for about a month (https://github.com/flutter/flutter/pulls?q=is%3Apr+author%3Afluttergithubbot+%22Roll+pub+packages%22+is%3Aclosed+) and nothing has gone wrong. The PRs that were closed without merging required manual intervention that was resolved in a separate PR.

This PR has the bot add the autosubmit label when creating the PR. I will make a follow-up cocoon change to have the cocoon bot auto approve. Any autoroll that breaks pre-submits will still require manual intervention.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 29, 2022
@christopherfujino
Copy link
Contributor Author

@goderbauer FYI next time you manually roll pub packages I should get auto-added as a reviewer via codeowners, so you shouldn't have to remember to cc me.

Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter-lgtm

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 29, 2022
@auto-submit auto-submit bot merged commit 3ce2ab9 into flutter:master Jul 29, 2022
@christopherfujino christopherfujino deleted the automate-pub-autoroll branch July 29, 2022 20:00
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants