Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[platform_view]run platform view ui test to physical device #108642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Jul 29, 2022

The failure is because await devices.workingDevice requires a physical device, and we were running it using Mac name under .ci.yaml.

There are 3 possible fixes:

  1. running on simulator. Use testWithNewIOSSimulator to get the device ID, and run the simulator. In this case we don't have to set deviceOperatingSystem because it's only for physical device.
  2. actually running it on physical device (This PR)
  3. change this test to flutter_drone test which runs on simulator too, but it is a lot more involved (moving the test from devicelab to flutter_drone).

We pick option 2 because it's relatively easier, and we may actually want to test platform views on device (e.g. measure performance, etc).

List which issues are fixed by this PR. You must list at least one issue.

#106745 (comment)

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hellohuanlin hellohuanlin requested a review from keyonghan as a code owner July 29, 2022 21:23
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 29, 2022
@hellohuanlin hellohuanlin requested a review from jmagman July 29, 2022 21:23
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cs.opensource.google/flutter/flutter/+/master:TESTOWNERS;l=201 should be moved under section: ## Mac iOS DeviceLab tests

@hellohuanlin hellohuanlin requested a review from keyonghan July 29, 2022 21:43
@keyonghan
Copy link
Contributor

https://cs.opensource.google/flutter/flutter/+/master:TESTOWNERS;l=201 should be moved under section: ## Mac iOS DeviceLab tests

This change request is for TESTOWNERS file.
Though the builder Linux test_ownership succeeds here, I am afraid it will fail in other PRs when this lands. This is due to #108645.

@hellohuanlin hellohuanlin force-pushed the platform_view_ui_use_flutter_drone branch from 3c56bd4 to 7d29046 Compare July 29, 2022 23:55
@hellohuanlin
Copy link
Contributor Author

https://cs.opensource.google/flutter/flutter/+/master:TESTOWNERS;l=201 should be moved under section: ## Mac iOS DeviceLab tests

This change request is for TESTOWNERS file. Though the builder Linux test_ownership succeeds here, I am afraid it will fail in other PRs when this lands. This is due to #108645.

Oh sorry i misunderstood. Updated both to be consistent.

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 30, 2022
@auto-submit auto-submit bot merged commit 176f7d7 into flutter:master Jul 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants