-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[platform_view]run platform view ui test to physical device #108642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[platform_view]run platform view ui test to physical device #108642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://cs.opensource.google/flutter/flutter/+/master:TESTOWNERS;l=201 should be moved under section: ## Mac iOS DeviceLab tests
This change request is for TESTOWNERS file. |
3c56bd4
to
7d29046
Compare
Oh sorry i misunderstood. Updated both to be consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The failure is because
await devices.workingDevice
requires a physical device, and we were running it usingMac
name under.ci.yaml
.There are 3 possible fixes:
testWithNewIOSSimulator
to get the device ID, and run the simulator. In this case we don't have to setdeviceOperatingSystem
because it's only for physical device.flutter_drone
test which runs on simulator too, but it is a lot more involved (moving the test fromdevicelab
toflutter_drone
).We pick option 2 because it's relatively easier, and we may actually want to test platform views on device (e.g. measure performance, etc).
List which issues are fixed by this PR. You must list at least one issue.
#106745 (comment)
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.