Deprecate ThemeData.selectedRowColor #109070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansMuller
approved these changes
Aug 5, 2022
| @@ -1796,7 +1808,11 @@ class ThemeData with Diagnosticable { | |||
| 'https://flutter.dev/docs/release/breaking-changes/toggleable-active-color#migration-guide. ' | |||
| 'This feature was deprecated after v2.13.0-0.4.pre.', | |||
| ) | |||
| Color? toggleableActiveColor, | |||
| Color? toggleableActiveColor,@Deprecated( | |||
There was a problem hiding this comment.
I think one was added while I was reviewing. Please ignore this.
Piinks
commented
Aug 5, 2022
| buttonColor: buttonColor ?? this.buttonColor, | ||
| fixTextFieldOutlineLabel: fixTextFieldOutlineLabel ?? this.fixTextFieldOutlineLabel, | ||
| primaryColorBrightness: primaryColorBrightness ?? this.primaryColorBrightness, | ||
| accentColor: accentColor ?? _accentColor, |
There was a problem hiding this comment.
Added this tweak. this.<deprecatedProperty> here does not actually allow folks to stop using it. I just found out in a test case. 😜
|
Will see about landing this next week, I want to run it through internal tests first. |
|
Internal testing passed. |
42 tasks
This was referenced Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 10, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #91772
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.