Generate syntax for plugin registration that works both with and without null safety. #109480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to dev. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
e86e093 to
007f96b
Compare
yjbanov
reviewed
Aug 15, 2022
yjbanov
approved these changes
Aug 18, 2022
packages/flutter_tools/test/integration.shard/web_plugin_registrant_test.dart
Outdated
Show resolved
Hide resolved
|
Blocked by #109797 currently |
MatthewPatience
pushed a commit
to MatthewPatience/flutter
that referenced
this pull request
Aug 20, 2022
This was referenced Aug 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2022
…and without null safety. (flutter/flutter#109480)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 20, 2022
…and without null safety. (flutter/flutter#109480)
eyebrowsoffire
added a commit
to eyebrowsoffire/flutter
that referenced
this pull request
Aug 29, 2022
CaseyHillers
pushed a commit
that referenced
this pull request
Aug 29, 2022
…out null safety. (#109480) (#109906) Co-authored-by: Jackson Gardner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a language header to specify we can use null safety in the generated plugin registrant file.
This fixes #109160