Add support for double tap and drag for text selection #109573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
reviewed
Aug 17, 2022
| @@ -191,6 +195,16 @@ class DragUpdateDetails { | |||
| /// Defaults to [globalPosition] if not specified in the constructor. | |||
| final Offset localPosition; | |||
|
|
|||
| /// A delta offset from the point where the drag initially contacted | |||
There was a problem hiding this comment.
The receiver should be able to calculate this from the sequence of the update events? Does it worth it to add a new API that may be breaking change?
There was a problem hiding this comment.
Would this be break since offsetFromOrigin has a default value, and localOffsetFromOrigin is nullable? One of the reasons i'm in favor of adding this, is that LongPressMoveUpdateDetails provides a similar API
DragStartDetails in our current text selection implementation, which is something I can't do with the text gestures project since the gesture recognizer mapping is defined in the classes initializer.
Edit: I just realized since I'm using SelectionEvents and updating the SelectionEdgeStart and SelectionEdgeEnd I don't necessarily need this. Though I still think it would be good for the current implementation.
|
|
||
| void consecutiveTapTimeout() { | ||
| print('consecutive tap timeout'); | ||
| consecutiveTapTimer?.cancel(); |
There was a problem hiding this comment.
can this be null? if not, we should assert it
| consecutiveTapCount += 1; | ||
| lastTapOffset = details.globalPosition; | ||
| } else { | ||
| if (consecutiveTapTimer != null && isWithinConsecutiveTapTolerance(details.globalPosition)) { |
There was a problem hiding this comment.
It feels to me this logic should be in the mixin instead
There was a problem hiding this comment.
does this differentiate between right click and left click
There was a problem hiding this comment.
You're right, I think that logic can go in the mixin.
It does not currently differentiate between left and right click, but that is a good point. I don't think there are any gestures related to consecutive right clicks so it should be fine to not count the tap counts on right click, do you know of any?
| typedef GestureDragEndWithConsecutiveTapCountCallback = void Function(DragEndDetails endDetails, int consecutiveTapCount); | ||
| typedef GestureTapAndDragCancelCallback = void Function(); | ||
|
|
||
| mixin ConsecutiveTapMixin { |
There was a problem hiding this comment.
This should probably be private class for now
| } | ||
| } | ||
|
|
||
| _consecutiveTapCountWhileDragging = consecutiveTapCount; |
There was a problem hiding this comment.
why in tap down? we can save this in move instead ?
There was a problem hiding this comment.
If we save it in drag start or drag update, the count timer could timeout before we have begun the drag. In native I can hold the double tap and drag N seconds later and still get double tap to drag.
| invokeCallback<void>('onEnd', () => onEnd!(endDetails, consecutiveTapCount)); | ||
| _consecutiveTapCountWhileDragging = null; | ||
| consecutiveTapTimer ??= Timer(kDoubleTapTimeout, consecutiveTapTimeout); | ||
| } else { |
There was a problem hiding this comment.
may need to handle pointer cancel event
|
|
||
| void _checkLongPressStart() { | ||
| print('from recognizer check long press start'); | ||
| if (_isDoubleTap) { |
There was a problem hiding this comment.
does this work for double tap and drag?
There was a problem hiding this comment.
Do you mean if we can do this case for double tap and drag?, or if this case breaks double tap to drag?
justinmc
reviewed
Sep 16, 2022
|
|
||
| /// {@macro flutter.gestures.tap.GestureTapDownCallback} | ||
| /// | ||
| /// The consecutive tap count at the time the pointer contacted the screen, is given by `consecutiveTapCount`. |
There was a problem hiding this comment.
Nit: No comma needed here and below I think.
There was a problem hiding this comment.
Also maybe link consecutiveTapCount like [TapStatus.consecutiveTapCount]?
| // If last tap offset is false then we have restarted our consecutive tap count, | ||
| // so the consecutiveTapTimer should be null.ß | ||
| assert(consecutiveTapTimer == null); | ||
| consecutiveTapCount += 1; |
There was a problem hiding this comment.
The comment above says that you have "restarted our consecutive tap count". Does that mean that consecutiveTapCount should be 0 here before the increment?
There was a problem hiding this comment.
Corrected this
| this.dragStartBehavior = DragStartBehavior.start, | ||
| super.kind, | ||
| super.supportedDevices, | ||
| }); |
There was a problem hiding this comment.
Nit: Do we need an assert that dragStartBehavior isn't null here? I know with sound null safety it won't be possible to pass null anyway, but I'm not sure if the assert will do something or not otherwise.
There was a problem hiding this comment.
Added the assert!
| switch (defaultTargetPlatform) { | ||
| case TargetPlatform.android: | ||
| case TargetPlatform.fuchsia: | ||
| case TargetPlatform.iOS: | ||
| // On mobile platforms the selection is set on tap up. | ||
| if (_isShiftTapping) { |
There was a problem hiding this comment.
It's really cool to see all of this shifttapping stuff go away and be replaced by a normal gesture detector 👍
| // Adjust the drag start offset for possible viewport offset changes. | ||
| final Offset startOffset = renderEditable.maxLines == 1 | ||
| ? Offset(renderEditable.offset.pixels - _dragStartViewportOffset, 0.0) | ||
| : Offset(0.0, renderEditable.offset.pixels - _dragStartViewportOffset); | ||
| final Offset dragStartGlobalPosition = details.globalPosition - details.offsetFromOrigin; |
There was a problem hiding this comment.
Is this something that you could always do to get the start position? It seems nice that we don't need DragStartDetails any more.
There was a problem hiding this comment.
Yes! because I added offsetFromOrigin to DragUpdateDetails. This is similar to LongPressMoveUpdateDetails which also has offsetFromOrigin. A good use case where that is currently used is in TextField
| // Adjust the drag start offset for possible viewport offset changes. | ||
| final Offset startOffset = renderEditable.maxLines == 1 | ||
| ? Offset(renderEditable.offset.pixels - _dragStartViewportOffset, 0.0) | ||
| : Offset(0.0, renderEditable.offset.pixels - _dragStartViewportOffset); | ||
| final Offset dragStartGlobalPosition = details.globalPosition - details.offsetFromOrigin; | ||
|
|
||
| // Select word by word. |
There was a problem hiding this comment.
I didn't realize this but even with a mouse this is right, it selects by word for me here on Linux.
| @@ -3446,7 +3446,7 @@ void main() { | |||
| ); | |||
| await tester.tapAt(endpoints[0].point + const Offset(1.0, 1.0)); | |||
| await tester.pump(); | |||
| await tester.pump(const Duration(milliseconds: 200)); // skip past the frame where the opacity is zero | |||
| await tester.pump(const Duration(milliseconds: 300)); // skip past the frame where the opacity is zero | |||
There was a problem hiding this comment.
Is there a constant somewhere that could be used in all of the cases where you use 300ms to make it more clear where this comes from?
There was a problem hiding this comment.
Yeah I can do that 300ms is the kDoubleTapTimeout from gestures/constants.dart
|
@justinmc @chunhtai @LongCatIsLooong This is ready for review. There's an analyzer issue due to a dependency loop that happens when I bring in My main motivation for having it in the recognizer is so that I can then define a map of GestureRecognizer subclasses to GestureRecognizerFactory, in the initialization of a class https://github.com/Renzo-Olivares/flutter/blob/3dbffa3922c656e5c2f97fb6ff8d42b4573d152c/packages/flutter/lib/src/widgets/default_selection_gestures.dart#L43. This can't be done in the initializer if I have to save state, such as saving if shift was tapped when on tap down is pressed. |
chunhtai
reviewed
Sep 26, 2022
| @@ -101,7 +101,7 @@ class _CupertinoTextFieldSelectionGestureDetectorBuilder extends TextSelectionGe | |||
| final _CupertinoTextFieldState _state; | |||
|
|
|||
| @override | |||
| void onSingleTapUp(TapUpDetails details) { | |||
| void onSingleTapUp(TapUpDetails details, TapStatus status) { | |||
There was a problem hiding this comment.
can this be SerialTapUpDetails?
There was a problem hiding this comment.
That wouldn't include the isShiftTapping field (status of shift being pressed).
| /// A delta offset from the point where the drag initially contacted | ||
| /// the screen to the point where the pointer is currently located (the | ||
| /// present [globalPosition]) when this callback is triggered. | ||
| final Offset offsetFromOrigin; |
There was a problem hiding this comment.
Which origin should this be if this is a double tap and drag? may be good to document this
There was a problem hiding this comment.
It would be the global position of the most recent tap down, i.e. the second tap down of a double tap and drag. I'll make sure to document it.
| /// The local position in the coordinate system of the event receiver at | ||
| /// which the pointer contacted the screen. | ||
| /// | ||
| /// Defaults to [globalPosition] if not specified in the constructor. | ||
| final Offset localPosition; | ||
|
|
||
| /// A delta offset from the point where the drag initially contacted | ||
| /// the screen to the point where the pointer is currently located (the |
There was a problem hiding this comment.
Suggested change
| /// the screen to the point where the pointer is currently located (the | |
| /// the screen to the point where the pointer is currently located in global coordinates (the |
| /// present [globalPosition]) when this callback is triggered. | ||
| final Offset offsetFromOrigin; | ||
|
|
||
| /// A local delta offset from the point where the drag initially contacted |
There was a problem hiding this comment.
maybe
A delta offset from the point where the drag initially contacted the screen to the point where the pointer is currently located in local coordinates relative to <TextField?>
There was a problem hiding this comment.
I don't think we should add the TextField specification since these Details object is used outside of TextField.
There was a problem hiding this comment.
That is just place holder. When it say local coordinates, it only makes sense if it mention what it is relative to.
| Offset? localPosition, | ||
| this.offsetFromOrigin = Offset.zero, |
There was a problem hiding this comment.
Is this necessary? In the past we let the caller to calculate this if they need.
tangential to this pr, I just realized there are states in the drag gesture reconginzer, will the internal state messed up if it is sharing between multiple textfields?
There was a problem hiding this comment.
I've done this to avoid having to save lastStartDetails and passing that to the drag update method to calculate the origin of the drag.
LongPressMoveUpdateDetails has a similar API, and we also use it in text selection. #109573 (comment)
I think it's a nice to have, to avoid saving theDragStartDetails.
| /// | ||
| /// Can be null to indicate that the gesture can drift for any distance. | ||
| /// Defaults to [kTouchSlop]. | ||
| final double? preAcceptSlopTolerance; |
There was a problem hiding this comment.
not entirely sure why this was exposed in other gesture recongizer, but you can use doc template to avoid duplicated the doc string from
| /// | ||
| /// Can be null to indicate that the gesture can drift for any distance. | ||
| /// Defaults to [kTouchSlop]. | ||
| final double? postAcceptSlopTolerance; |
| /// {@macro flutter.gestures.tap.TapGestureRecognizer.onSecondaryTapUp} | ||
| GestureTapUpCallback? onSecondaryTapUp; | ||
|
|
||
| /// {@macro flutter.gestures.monodrag.DragGestureRecognizer.onStart} |
There was a problem hiding this comment.
may need to document the tap status but, here and other places
| kind: getKindForPointer(event.pointer), | ||
| ); | ||
|
|
||
| incrementConsecutiveTapCountOnDown(details.globalPosition); |
There was a problem hiding this comment.
I imagine the _ConsecutiveTapMixin to be more self contain. can the _ConsecutiveTapMixin to be mix on OneSequenceGestureRecognizer so that it can override addAllowGesture, accept gesture and the rejectGesture to update its own state? TapAndDragGestureRecognizer can just query the consecutiveTapCount when the drag starts
There was a problem hiding this comment.
I think we have to continue to query the consecutiveTapCount in the onTapDown. The primary reason being there can be a double click hold and then drag. If we query during drag start the consecutiveTapCount may have been reset by the Timer timeout callback.
I also think at the OneSequenceGestureRecognizer level we do not have access to the most recent down event (unless we start tracking it) which we need for consecutiveTapCount to be updated in acceptGesture and rejectGesture. I'm also unsure about adding this functionality to OneSequenceGestureRecognizer since there are some GestureRecognizers using it as a base class.
There was a problem hiding this comment.
you can override handleEvent to get record most recent down event?
| if (widget.onSingleLongTapStart != null || | ||
| widget.onSingleLongTapMoveUpdate != null || | ||
| widget.onSingleLongTapEnd != null) { | ||
| gestures[LongPressGestureRecognizer] = GestureRecognizerFactoryWithHandlers<LongPressGestureRecognizer>( | ||
| () => LongPressGestureRecognizer(debugOwner: this, kind: PointerDeviceKind.touch), | ||
| () => LongPressGestureRecognizer(debugOwner: this, supportedDevices: <PointerDeviceKind>{ PointerDeviceKind.touch }), |
There was a problem hiding this comment.
Can this also be replaced by TapAndDragGestureRecognizer?
There was a problem hiding this comment.
At the moment I did not see a reason to expand the new recognizer's capabilities to support LongPress. I haven't identified any selection behaviors that rely on consecutive taps for long press.
There was a problem hiding this comment.
how do we handle longpress and drag?
justinmc
reviewed
Sep 27, 2022
There was a problem hiding this comment.
The one thing that I want to double check is the existence of TapStatus separate from the gesture Details. It just seems strangely different from the other gesture callbacks when I see both parameters. Could it be combined into the relevant Details classes, or is this approach actually better so we don't have to make changes to so many Details classes?
| /// amount of time has elapsed since starting to track the primary pointer. | ||
| /// | ||
| /// [onTapDown] will not be called if the primary pointer is | ||
| /// accepted, rejected, or all pointers are up or canceled before [deadline]. |
There was a problem hiding this comment.
Nit: Maybe use a macro for these repeated docs.
| /// {@macro flutter.gestures.tap.TapGestureRecognizer.onTapUp} | ||
| GestureTapUpWithTapStatusCallback? onTapUp; | ||
|
|
||
| /// {@macro flutter.gestures.tap.TapGestureRecognizer.onTapCancel} |
There was a problem hiding this comment.
Nit: Should there be an empty /// line after this macro?
| to: details.globalPosition, | ||
| cause: SelectionChangedCause.drag, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Are you planning to do triple tap and drag later?
There was a problem hiding this comment.
Yes triple tap and drag, will be handled in another PR.
| return; | ||
| case TargetPlatform.android: | ||
| case TargetPlatform.fuchsia: | ||
| // With a touch device, the cursor should move with the drag. |
There was a problem hiding this comment.
Nit: Also state what happens with a mouse?
| } | ||
|
|
||
| void _handleTapCancel() { | ||
| widget.onSingleTapCancel?.call(); | ||
| } | ||
|
|
||
| DragStartDetails? _lastDragStartDetails; | ||
| // TODO(Renzo-Olivares): Can this be moved into the TapAndDragGestureRecognizer? |
There was a problem hiding this comment.
Heads up there's a TODO still here.
|
|
||
| expect(controller.selection.baseOffset, testValue.indexOf('d')); | ||
| expect(controller.selection.extentOffset, testValue.indexOf('i') + 1); | ||
| }); |
There was a problem hiding this comment.
Nit: Maybe do it like this for consistency (if indeed most other tests are this way. At least the previous one is.):
},
);
| @@ -1835,6 +1835,103 @@ void main() { | |||
| }, | |||
| ); | |||
|
|
|||
| testWidgets( | |||
| 'double tap + drag selects word by word on mouse devices', | |||
There was a problem hiding this comment.
Nit: This title seems misleading to me because it's not the device that matters, it's the gesture device kind. Same for the next test and the corresponding tests in material.
There was a problem hiding this comment.
Changed to
Can double tap + drag to select word by word and
Can double click + drag with a mouse to select word by word
| final int consecutiveTapCount; | ||
|
|
||
| /// Whether the shift key was pressed when this tap happened. | ||
| final bool isShiftPressed; |
There was a problem hiding this comment.
Nit: Maybe shiftWasDown or something like that? I don't know if I like that any better... But it's slightly confusing that this means that the shift was down at the time of the tap, not necessarily when it is accessed.
There was a problem hiding this comment.
I changed this to keysPressedOnDown in case there are other keyboard + gesture combinations that need to be handled in the future. I have so far identified one other gesture besides shift, which is ctrl. ctrl + click acts like a right click on macOS, selecting the word at the clicked position and popping up the context menu.
I see what you mean. It feels like |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is ready for another review. Most of the changes since the last review happened in I am still unsure how to proceed with the callback signatures including a tap status vs making a new details object. My only gripe about making new details objects is that I’m not sure what direction we want to move with them since the different details objects now share some common fields. |
justinmc
reviewed
Nov 10, 2022
| final Offset localPosition; | ||
|
|
||
| /// If this tap is in a series of taps, then this value represents | ||
| /// the number in the series this tap is. |
There was a problem hiding this comment.
Yes, but that is not set by default by this object. It is set by the recognizer.
| /// the number in the series this tap is. | ||
| final int consecutiveTapCount; | ||
|
|
||
| /// The keys that were pressed when the most recent [PointerDownEvent] occurred. |
There was a problem hiding this comment.
So if this is say 5th in a series of taps, then keysPressedOnDown represents the keys down during the 5th tap?
There was a problem hiding this comment.
Exactly. I think it's fine that the keysPressedOnDown represents the keys down of the most recent tap. I would think a gesture would seem a bit unintuitive if it was something like on the 2nd tap of a quadruple tap if shift was down then do some action on the 4th tap.
There was a problem hiding this comment.
Yeah that sounds fine to me 👍
| final PointerDeviceKind kind; | ||
|
|
||
| /// If this tap is in a series of taps, then this value represents | ||
| /// the number in the series this tap is. |
There was a problem hiding this comment.
Reading through this, I'm wondering exactly what events are fired when. Like I think this is only for tapping several times in one spot and then dragging from there. So continuing to tap again after dragging would not be part of the same consecutiveTapCount. Is that right?
Maybe you could explain this more somewhere if it's not already (and I haven't gotten to it yet). Like give an example of a user tapping a few times, then dragging, then lifting, and say what events are fired when. Maybe this belongs somewhere else besides the Details classes, just thinking out loud here.
There was a problem hiding this comment.
That is correct, if you continue to tap again after a drag then the tap series is reset. I'll put together some more docs.
| expect(controller.selection.baseOffset, testValue.indexOf('d')); | ||
| expect(controller.selection.extentOffset, testValue.indexOf('i') + 1); | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Would this kind of test work on an EditableText so you wouldn't have to test both TextField and CupertinoTextField? I know handle dragging might not be worth it to do on EditableText, but maybe just this kind of tap and drag would work easily?
There was a problem hiding this comment.
I don't think we have any tests for TextSelectionGestureDetector inside of EditableText since it is only available at the TextField level. The only gesture related tests I see on EditableText are ones that make use of the internal gesture recognizers RenderEditable has. I think we should keep these tests where they are for now, but definitely explore how we can make the situation better. I always find it a bit cumbersome to have to write tests x2 sometimes x3 if we include SelectableText.
Since we want our new Text selection gestures to follow platform behaviors versus follow design language behaviors (material vs cupertino), then I agree the best path forwards are to move all the selection tests to one place since they shouldn't differ between cupertino and material.
There was a problem hiding this comment.
Ah that's right, sounds good, but agreed that we should find a way to consolidate these in the future.
chunhtai
reviewed
Nov 11, 2022
chunhtai
reviewed
Nov 11, 2022
There was a problem hiding this comment.
It looks like the mixin still not separating the functionality well enough that the TapAndDragGestureRecognizer and _TapStatusTrackerMixin needs to use fragmented information to guess the status of each other's state.
Is it possible to come up with a mechanism in _TapStatusTrackerMixin to start or stop tracking the tap? something like _TapStatusTrackerMixin.startTrackingTap or _TapStatusTrackerMixin.stopTrackingTap. The TapAndDragGestureRecognizer will just look for when drag is accepted.
Before drag is accepted, everything will be handled by _TapStatusTrackerMixin. Once drag is accepted, TapAndDragGestureRecognizer call _TapStatusTrackerMixin.stopTrackingTap and start handling the event.
for _TapStatusTrackerMixin it will just handle event as long as _TapStatusTrackerMixin.stopTrackingTap is not called.
Will this make thing cleaner? If this is not possible, we may consider just merge them together since they are too inner-connected
| if (_up != null && _down != null) { | ||
| _consecutiveTapTimerStop(); | ||
| _consecutiveTapTimerStart(); | ||
| _wonArena = false; |
There was a problem hiding this comment.
What does the _wonArena parameter really mean? How can a gesturereconginzer un-win itself without caliing rejectGesture?
There was a problem hiding this comment.
It means the gesture recognizer has won the arena for the given pointer sometime in the past. This is used because acceptGesture might be called before handleEvent and in that case we will not have tracked a PointerUpEvent yet so we cannot call tap up until we track the PointerUpEvent in handleEvent. So I use _wonArena to communicate this to handleEvent.
There was a problem hiding this comment.
ontapup is no longer in this class is this parameter still needed?
There was a problem hiding this comment.
Yes because we want to start the timer on tap up and stop it on tap down. Better explained here: #109573 (comment)
|
|
||
| @override | ||
| void handleEvent(PointerEvent event) { | ||
| if (event is PointerMoveEvent) { |
There was a problem hiding this comment.
Why does this need to check for move? we should only need to worry about the slop distance when the pointer is up?
There was a problem hiding this comment.
There can be a PointerMoveEvent that occurs between a PointerDownEvent and PointerUpEvent. If that PointerMoveEvent reaches that threshold then we should stop tracking the current tap series. See
| if (_dragState == _DragState.possible) { | ||
| // If we arrive at a [PointerUpEvent], and the recognizer has not won the arena, and the tap drift | ||
| // has exceeded its tolerance, then we should reject this recognizer. | ||
| if (pastTapTolerance) { |
There was a problem hiding this comment.
Shouldn't this be handled by the mixin?
| _giveUpPointer(event.pointer); | ||
| return; | ||
| } | ||
| // The drag has not been accepted before a [PointerUpEvent], therefore the recognizer |
There was a problem hiding this comment.
I can't wrap my head around the logic.
Is it using pastTapTolerance to infer the drag has not been accepted?
There was a problem hiding this comment.
Say we have a sequence of events PointerDownEvent -> PointerMoveEvent -> PointerUpEvent. There are 3 cases.
- If we arrive at that
PointerUpEventand thePointerMoveEventdid not move a sufficient global distance to be accepted as a drag, but moved a sufficient global distance to move past the tap tolerance.
- TapCancel
- DragCancel
- If we arrive at that
PointerUpEventand thePointerMoveEventmoved a sufficient global distance to be accepted as a drag, therefore also moving past the tap tolerance because dragTolerance > tapTolerance.
- TapCancel
- If we arrive at that
PointerUpEventand thePointerMoveEventdid not move a sufficient global distance to be accepted as a drag and it did not move past the tap tolerance.
- DragCancel
It is using pastTapTolerance to decide if the tap has been declined.
There was a problem hiding this comment.
the pointer did not move a sufficient global distance to be accepted as a drag.
In this case, why does it need to send DragCancel? Does the Drag already start at this point?
There was a problem hiding this comment.
Because even if it doesn't meet the sufficient global distance to be accepted as a drag, the DragGestureRecognizer will be accepted if it is the last recognizer in the arena before a PointerUpEvent is tracked.
Here I was trying to match the behavior of PanGestureRecognizer and TapGestureRecognizer in an arena.
The PanGestureRecognizer will only self-lose if we have arrived at a PointerUpEvent and our drag has not yet been accepted. It will only declare victory when a sufficient global distance has been moved from the origin.
The TapGestureRecognizer will only win when it is the last member of the arena. It does not declare victory on its own. It will self-lose when the tap has drifted past the tap tolerance defined by preAcceptSlopTolerance and postAcceptSlopTolerance, this behavior is defined by PrimaryPointerGestureRecognizer.
When both of these recognizers are in one arena this is their behavior.
If we arrive at that PointerUpEvent and the PointerMoveEvent did not move a sufficient global distance to be accepted as a drag, but moved a sufficient global distance to move past the tap tolerance.
- Nothing unless the
PrimaryPointerGestureRecognizer.deadlinehas elapsed and the tap down callback has been called in that case TapCancel will be called becausePrimaryPointerGestureRecognizerdeclares self-loss because we moved past the tap tolerance.
If we arrive at that PointerUpEvent and the PointerMoveEvent moved a sufficient global distance to be accepted as a drag, therefore also moving past the tap tolerance because dragTolerance > tapTolerance.
- TapCancel because
DragGestureRecognizerhas declared self-victory, andPrimaryPointerGestureRecognizerhas also declared self-loss because we have moved past the tap tolerance.
If we arrive at that PointerUpEvent and the PointerMoveEvent did not move a sufficient global distance to be accepted as a drag and it did not move past the tap tolerance.
- DragCancel because we arrive at
DragGestureRecognizer.didStopTrackingLastPointerwhen the_DragStateispossible.
There was a problem hiding this comment.
It looks like in case #1 I am not matching the target behavior. Where individual TapGestureRecognizer and DragGestureRecognizer will detect the case as a drag, my single TapAndDragGestureRecognizer rejects both tap and drag.
There was a problem hiding this comment.
I am now mostly matching the behavior in scenario #1.
With two recognizers TapGestureRecognizer and PanGestureRecognizer:
onDown-PanGestureRecognizer -> onStart-PanGestureRecognizer -> onUpdate-PanGestureRecognizer -> onEnd-PanGestureRecognizer
TapGestureRecognizerdeclares loss and doesn't fire any callbacks because the pointer moves past the tap tolerance.
With one TapAndDragGestureRecognizer:
onTapDown-TapAndDragGestureRecognize -> onTapCancel-TapAndDragGestureRecognize -> onDragStart-TapAndDragGestureRecognize -> onDragUpdate-TapAndDragGestureRecognize -> onDragEnd-TapAndDragGestureRecognize.
The difference is that the new recognizer calls onTapDown and onTapCancel followed by onDragStart and onDragEnd. This differing behavior is expected for the new recognizer since it will call onTapDown when acceptGesture is called, and that needs to be followed up with an onTapCancel when a drag begins.
When using two recognizers (TapGestureRecognizer and PanGestureRecognizer), onTapDown is not called because TapGestureRecognizer only fires it on acceptGesture and TapGestureRecognizer self declares loss when moving past tap tolerance, therefore there is also no need for it to call onTapCancel since tap down was never fired. In this situation PanGestureRecognizer wins and the gesture is pan.
Our case differs because TapGestureRecognizer declares loss, which gives acceptGesture in TapAndDragGestureRecognizer the chance to call onTapDown, but because our pointer moved past the tap tolerance this gesture cannot be a tap, so we call tap cancel and the gesture defaults to a drag.
I added some tests to verify these behaviors as well as documentation. Do you have any thoughts on this cancel behavior?
There was a problem hiding this comment.
It feels weird that we merge two gesture recognizers to eliminate the conflicting callback and cancelling each other, but now we still simulating the canceling behavior in one merged gesture recognizer. In my opinion, once the canceling is called, this gesture recognizer should not fire any other callback in this gesture sequence. I think we should treat tap and drag as one kind of gesture so in this case
onTapDown-TapAndDragGestureRecognize -> onTapCancel-TapAndDragGestureRecognize -> onDragStart-TapAndDragGestureRecognize -> onDragUpdate-TapAndDragGestureRecognize -> onDragEnd-TapAndDragGestureRecognize.
it doesn't make sense to call onTapCancel-TapAndDragGestureRecognize. The onTapDown can be a down for a single tap or a down for a drag. The cusumer (i.e editabletext) should have this in mind when using this recognizer. If they have to differentiate it, they need to implement their own logic or keep some kind of state.
Does this make sense?
There was a problem hiding this comment.
This makes a lot of sense! I think my initial train of thought regarding the decision on cancel behavior was to keep some tests happy, but it makes a lot more sense to change the intended behavior and have the recognizer only have one cancel.
There was a problem hiding this comment.
Updated the cancel behavior to only cancel when a tap down has been fired, i.e. when a PointerDownEvent was received. Also merged onTapCancel and onDragCancel into onCancel.
I agree that the onCancel should be the callback fired in a sequence of callbacks of the recognizer. And it should only be called if the recognizer has fired a tap down before, if not then it is unclear what was "cancelled". The new changes now reflect this.
3c0c59c to
27021c2
Compare
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
* Replace PanGestureRecognizer in TextSelection with TapAndDragGestureRecognizer * add tracking of _DragState to new tap_and_drag recognizer and remove some legacy double tap code from text_selection.dart and add logs" * add dragTapCount, a tap count that is persistent for an entire drag and is set to null on drag end vs the regular tap count which is reset on a timer * basic double tap to drag functionality and add a local dragTapCount in text_selection.dart to use with the timer callback * Add offsetFromOrigin and localOffsetFromOrigin to DragUpdateDetails similar to LongPressMoveUpdateDetails, eliminates the need to hold the state of lastDragStartDetails * make a generic baselongpressgesturerecognizer * Revert "make a generic baselongpressgesturerecognizer" This reverts commit aad8f74. * rename tap_and_drag to selection_recognizers * add mixin for consecutivetap * tap and long press gesture recognizer * Revert "Revert "make a generic baselongpressgesturerecognizer"" This reverts commit 181350c. * Revert "Revert "Revert "make a generic baselongpressgesturerecognizer""" This reverts commit 4d69775. * Add support for secondary button clicks on drag gesture recognizer and separate drag end and tap up callback * get test running * rename tapCount to consecutiveTapCount * dispose timer properly * add some comments to tests * Add comments * Make ConsecutiveTapMixin private and move logic to increment tap count into mixin * stop tracking pointer when gesture is rejected and detect drags on touch devices * onCancel for TapAndDrag * have the TapAndDragGestureRecognizer handle tap downs and tap ups on touch and mouse devices * add drag to move cursor for android and iOS, and pointer device kind to DragUpdateDetails * get tests running * refactor TapAndDragGestureRecognizer moving some logic into _check methods * Handle cancel properly on TapAndDragGestureRecognizer, having both onTapCancel and onDragCancel, also fix tests * Fix test mouse drag selects and cannot drag cursor, save _initialPosition based on dragStartBehavior (either on tapDown or dragStart) * determine if drag has a sufficient global distance to accept and fix some cancel behavior, making _checkCancel clearer * give up pointer on drag end * properly stop tracking pointer, fixes test for right click on Apple and non-apple platforms * clean up some comments from last commit * remove drag on touch for now * fix Can select text by dragging with a mouse due to dragStart only being fired on the first PointerMoveEvent, the previous pan gesture recognizer would fire both dragStart and dragUpdate * Revert "fix Can select text by dragging with a mouse due to dragStart only being fired on the first PointerMoveEvent, the previous pan gesture recognizer would fire both dragStart and dragUpdate" This reverts commit 124dc79. * correctly use _initialPosition for checkStart and call _checkUpdate after _checkStart if localDelta is not zero * updates * fix double tap chains * Add docs * Address analyzer * more analyzer, only issues left are with print statements * add deadlineTimer to fix conflict with ForcePressGestureRecognizer * Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer" This reverts commit 3b29ddf. * remove unecessary changes to tests * secondaryButton should not drag * Revert "Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer"" This reverts commit 0a008f0. * updates * Revert "updates" This reverts commit 4803b84. * Revert "Revert "Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer""" This reverts commit 79251a7. * fix shift + tap + drag tests, this was happening because a double tap + drag was being registered and not a single tap, added a duration to pumpAndSettle to fix this * remove TapAndLongPressGestureRecognizer * fix cupertino text field tests related to shift + tap + drag * deadline timer try 2 * more logs * Should reset taps when tap cancel is called, and should wait until gesture is accepted to initiate a drag * should clear _down and _up when gesture is rejected * remove erroneous log * fix selectable text double tap chains test * dont restart timer until tap up * reset consecutiveTapCount on drag end * fix selectableText test * fix material text field tests * reject TapAndDragGestureRecognizer when it is neither a tap nor a drag * remove prints * clean up * shift aware * clean up * fix cupertino test * fix text field focus tests * Add 100ms delay to cupertino test, to prevent a double tap * clean up test comments * add comment to test * uncomment test * remove longpress changes * Fix drag on mobile * remove debug * Fix drag to move cursor on iOS * left over from drag fix * add tests for drag on touch devices * add test for double tap + drag mouse devices * add tests * Fix bug where initialPosition was used before it was set * Address some review comments and fix issue where if double tap was held too long then long press gesture recognizer would take over * remove _isDoubleTap flag since it is no longer needed due to previous commit * Add docs for onTapCancel and onDragCancel * analyzer fixes * Do not test selection handles on macOS, since macOS does not support touch * Add assert for dragStartBehavior * add double tap + drag tests to cupertino * use kDoubleTapTimeout instead of const Duration(milliseconds: 300) for readability * analyzer issues * update docs * update more docs * address comments * more doc updates * fix docs * unused import * fix docs * Add more tests * Add more tests and reject a tap up if we have exceeded the tap tolerance * updates * Address comments * fix test naming * update documentation * move selection_recognizers to selection_gestures * fix analyzer * fix analyzer * keysPressedOnDown instead of isShiftPressed * update docs * update docs * Add drag update throttle to TapAndDragGestureRecognizer * update comments * missed from merge * Replace _ConsecutiveTapMixin with _TapStatusTrackerMixin * updates * correctly cancel tap when when past tap tolerance with new implementation * Should call tap and drag cancel if we are giving up a pointer without succesfully tracking a PointerUpEvent * comments * move pastTapTolerance to tap tracker * move pastTapTolerance to tap tracker * clean up check for nulls and remove use of consecutiveTapCountWhileDragging * move call to super.acceptGesture to top * remove print * clean up * Fix tests where both PanGestureRecognizer and TapAndDragGestureRecognizer lost * clean up * _GestureState -> _DragState * more docs clean up * more clean up * Add onSecondaryTapCancel * Add docs * more docs * Fix broken isPointerAllowed when attempting a right click drag - the _initialButtons is never reset * revert debug flag * make primaryPointer private * Add support for upper count limit in TapAndDragGestureRecognizer, the tap counter should not be allowed to grow infinitely unless that is desired * fix analyzer * Use new TapDrag details objects and callbacks * clean up docs * clean up and add test for upperLimit * Add docs for TapAndDragGestureRecognizer and remove some ambiguity of onStart onUpdate and onEnd parameters * Address review comments * analyzer fixes * Call cancel before rejecting the gesture so we can still access _initialButtons * Recognizer should reject any pointer differing from the original * Revert "Recognizer should reject any pointer differing from the original" This reverts commit afd9807. * Address reviewer comments * Correct cancel behavior * Fix consecutive tap + drag because _dragStart state was not being set when consecutive tap is greater than one * Add more tests * Add documentation on behavior with TapGestureRecognizer and DragGestureRecognizer * more docs * more docs * remove comments * updates * fix multiple pointer behavior * only handle the primary pointer * Clean up dangerous assumptions in gesture details objects * forgot from rebase * update docs * updates * Clean up some redundant code * remove whitespace * fix tests as a result of flutter#115849 * update test docs * Fix same test from last commit for material variants * More clean up of redundant code and update docs * Clean up didStopTrackingLastPointer and untie TapAndDragGestureRecognizer cancel behavior from TapStatusTrackerMixin.currentUp state * untie pastTapTolerance * updates * Add slopTolerance * update docs * Have secondary tap handled by TapGestureRecognizer * update docs * fix analyzer and address comments * Add more docs * Update cancel behavior tol not call on tap cancel when a drag has been accepted * Change cancel behavior to only cancel if the tap down callback has been sent and merge tapcancel and dragcancel * update docs; * Rename selection_gestures to tap_and_drag_gestures * Address some reviewer comments * make deadline and slopTolerance private * updates * updates * Address review comments * remove _initialButtons * fix docs * trackTrap -> trackTap * fix analyzer * Add test to verify that tap up is called when recognizer accepts before handleEvent is called * implement Diagnosticable for Details objects; * sentTapDown == wonArenaForPrimaryPointer, so the implementation now only uses sentTapDown * Count user tap up immediately and do not wait to win the arena * Do not need to call super from TapAndDragGestureRecognizer.acceptGesture anymore because mixin implementation is gone * Do not start selection drag on Android, iOS, and Fuchshsia touch devices if renderEditable does not have focus, this fixes many scubas * Address reviewer comments * fix test * TapAndDragGestureRecognizer should wait for other recognizer to lose before winning the arena * Address review comments * Dont check for drag if the start was already found * Only check for a drag if it has not already been found" * fix from rebase Co-authored-by: Renzo Olivares <[email protected]>
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…er#109573)" (flutter#117497) This reverts commit cd0f15a. Co-authored-by: Renzo Olivares <[email protected]>
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…r#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <[email protected]>
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <[email protected]> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <[email protected]> * comment fixes * test update * docstring fixes * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * 4dd8a694f Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter/engine#38560) (flutter#117783) * 3460f349b [fuchsia] Set presentation interval (flutter/engine#38549) (flutter#117785) * Roll Flutter Engine from 3460f349b01d to 1752b5b84680 (2 revisions) (flutter#117788) * 332c0a2f2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561) * 1752b5b84 Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563) * a63bd854a [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) (flutter#117790) * Roll Flutter Engine from a63bd854ac5a to 5713a216076f (2 revisions) (flutter#117795) * e012dc825 [Windows] Add engine builder to simplify tests (flutter/engine#38546) * 5713a2160 Revert "[web] Don't overwrite editing state with semantic updates (flutter#38271)" (flutter/engine#38562) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (flutter#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * 9095f7a8b Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter/engine#38569) (flutter#117799) * 0118b461b Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter/engine#38571) (flutter#117800) * e03d7c8bb Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter/engine#38572) (flutter#117802) * af6078b5f Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter/engine#38574) (flutter#117804) * 7e5cc7bb6 Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter/engine#38575) (flutter#117805) * d4a04a538 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter/engine#38578) (flutter#117817) * b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter/plugins#6892) (flutter#117824) * Roll Flutter Engine from d4a04a538050 to 9153966bcb06 (2 revisions) (flutter#117830) * 53806fa1e Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579) * 9153966bc [fuchsia] Bump the target API level to 11 (flutter/engine#38544) * b9bf51d16 Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter/engine#38580) (flutter#117832) * Roll Flutter Engine from b9bf51d16f25 to f6ad9b6d00e3 (2 revisions) (flutter#117834) * 4b38736e7 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577) * f6ad9b6d0 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581) * 932591ec0 Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter/engine#38584) (flutter#117840) * 3d8c5ef10 Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter/engine#38585) (flutter#117846) * Roll Flutter Engine from 3d8c5ef1060c to a7decc3e459b (2 revisions) (flutter#117856) * 3470fa848 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586) * a7decc3e4 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587) * 0a2029cf3 Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter/engine#38588) (flutter#117858) * 5fe7d5b4e Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter/engine#38591) (flutter#117863) * e5d605b3a Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter/engine#38592) (flutter#117865) * 71c5f1704 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter/engine#38593) (flutter#117868) * 472e34cbb Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter/engine#38594) (flutter#117869) * Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (flutter#117875) * 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter/plugins#6896) * 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter/plugins#6901) * e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter/plugins#6908) * [flutter_tools] timeline_test.dart flaky (flutter#116667) * contains name instead of remove last * fix expect * remove and expect on elements * delete unused code * 7e51aef0a Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (flutter#117874) * Updated to tokens v0.150. (flutter#117350) * Updated to tokens v0.150. * Updated with a reverted list_tile.dart. * Simplify null check. (flutter#117026) * Simplify null check. * Simplify null check. * Simplify null check. * Fix. * Roll Flutter Engine from 7e51aef0a1be to 1d2ba73d1059 (9 revisions) (flutter#117923) * 3e1b0dcb2 Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter/engine#38597) * 8b17efed8 Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter/engine#38598) * 27960a700 [Impeller Scene] Import animation data (flutter/engine#38583) * b5acb2099 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter/engine#38599) * dd0335b34 Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter/engine#38601) * adda2e80c [Impeller Scene] Animation binding and playback (flutter/engine#38595) * 71a296d53 Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter/engine#38607) * bde8d4524 Implement ITextProvider and ITextRangeProvider for UIA (flutter/engine#38538) * 1d2ba73d1 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) * Reland "Remove single-view assumption from ScrollPhysics (flutter#117503)" (flutter#117916) This reverts commit c956121. * Minor documentation fix on BorderRadiusDirectional.zero (flutter#117661) * fix typos (flutter#117592) * c0b3f8fce Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (flutter#117931) * Add convenience constructors for SliverList (flutter#116605) * init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again * 2213b80dd [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (flutter#117935) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <[email protected]> * == override parameters are non-nullable (flutter#117839) * Fix the message strings for xcodeMissing and xcodeIncomplete (flutter#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test * 32c468507 Roll quiver to 3.2.1 (flutter/engine#38617) (flutter#117942) * Send text direction in selection rects (flutter#117436) * Correctly propagate verbosity to subtasks in flutter.gradle (flutter#117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports * Roll Plugins from e85f8ac1502d to f9dda6a27b79 (3 revisions) (flutter#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890) * [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (flutter#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment * roll packages (flutter#117940) * roll packages (flutter#118001) * [Android] Increase timeout duration for spell check integration test (flutter#117989) * Add timeout * Add library directive * Add comment, remove testing only changes * Roll Flutter Engine from 32c468507b32 to cdd3bf29e27a (8 revisions) (flutter#118014) * 22f872d5e Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9ed0 Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3bd Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dcdb Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5bf3 Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440ccd5 fix roll (flutter/engine#38635) * 87bdde8fe Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf29e make DisplayListFlags constexpr throughout (flutter/engine#38649) * 60515762e [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter/engine#38628) (flutter#118016) * 35b7dee32 [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter/engine#38497) (flutter#118017) * b9b0193ea Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter/engine#38654) (flutter#118018) * a01548f5f [Impeller Scene] Fix material/vertex color overlapping (flutter/engine#38653) (flutter#118027) * Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (flutter#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891) * 072a9ca37 Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter/engine#38646) (flutter#118039) * bb4015269 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter/engine#38659) (flutter#118042) * Avoid using `TextAffinity` in `TextBoundary` (flutter#117446) * Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests * 74861f369 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) (flutter#118048) * 5bd90d6e7 Consider more roles as text (flutter/engine#38645) (flutter#118049) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * Adding 'is' to list of kotlin reserved keywords (flutter#116299) Co-authored-by: Gray Mackall <[email protected]> * Added expandIconColor property on ExpansionPanelList Widget (flutter#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (flutter#118072) Co-authored-by: a-wallen <[email protected]> * Fix out-of-sync ExpansionPanel animation (flutter#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by: Morris Kurz <[email protected]> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by: Morris Kurz <[email protected]> * Clarify comment. Signed-off-by: Morris Kurz <[email protected]> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by: Morris Kurz <[email protected]> * Update testcases to new header height (56px -> 48px). Signed-off-by: Morris Kurz <[email protected]> * Test for header height equal to 48px. Signed-off-by: Morris Kurz <[email protected]> * Change issue number to link in comment * Add periods to comments Signed-off-by: Morris Kurz <[email protected]> * Roll Plugins from 320461910156 to 276cfd4b212d (2 revisions) (flutter#118099) * 3a6f63bed Roll Flutter from 231855f to 43b9120 (11 revisions) (flutter/plugins#6918) * 276cfd4b2 [shared_preferences] Convert macOS to Pigeon (flutter/plugins#6914) * 33d7f8a1b Remove single view assumptions from `window.dart` (flutter/engine#38453) (flutter#118069) * InteractiveViewer parameter to return to pre-3.3 trackpad/Magic Mouse behaviour (flutter#114280) * trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines * 0a0e3d205 Roll Flutter from 43b9120 to 5070620 (9 revisions) (flutter/plugins#6919) (flutter#118183) * Roll Flutter Engine from 33d7f8a1b307 to 03609b420beb (6 revisions) (flutter#118125) * c58254702 SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) * 3d9214ace Bump actions/checkout from 3.1.0 to 3.2.0 (flutter/engine#38390) * a4775c7a7 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) * 046012e8e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter/engine#38683) * cda410c28 Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter/engine#38668) * 03609b420 [web] Fix canvas2d leaks in text measurement (flutter/engine#38640) * remove the unused check in selectable_text (flutter#117716) * Roll Flutter Engine from 03609b420beb to b5513d7a442a (2 revisions) (flutter#118186) * fd5a96e10 Limit selection change to focused node on Windows (flutter/engine#38634) * b5513d7a4 Roll Dart SDK from 0b064bc49557 to cb29cb6d1d0f (12 revisions) (flutter/engine#38688) * Roll Flutter Engine from b5513d7a442a to 5bdb04f33f99 (2 revisions) (flutter#118187) * e20809014 Roll Skia from 54dbda290908 to b8c0a78a2378 (43 revisions) (flutter/engine#38690) * 5bdb04f33 Roll Fuchsia Mac SDK from Bewt-eq7gNu6sU_Ob... to ORxExaprF9fW5d4MP... (flutter/engine#38697) * 51baed6e0 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (flutter#118189) * Update to Xcode 14.2 (flutter#117507) * Update to Xcode 14.2 * Only bump for devicelab builders * Restore presubmit: false * Allow iOS and macOS plugins to share darwin directory (flutter#115337) * Roll Flutter Engine from 51baed6e01b8 to 5df0072a0e63 (3 revisions) (flutter#118192) * 181286315 Roll Dart SDK from cb29cb6d1d0f to 853eff8b0faa (2 revisions) (flutter/engine#38694) * 642f72f73 Bump actions/upload-artifact from 3.1.0 to 3.1.2 (flutter/engine#38713) * 5df0072a0 Bump actions/checkout from 3.2.0 to 3.3.0 (flutter/engine#38714) * Use program during attach if provided (flutter#118130) * eb5c6f0b4 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (flutter#118197) * Update `ListTile` to support Material 3 (flutter#117965) * Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add flutter#99933 HTML workaround. * 3a7d8862f Re-enable UIA text/range provider unit tests (flutter/engine#38718) (flutter#118201) * Fix path for require.js (flutter#118120) - Matches new location in the Dart SDK. https://dart-review.googlesource.com/c/sdk/+/275482 - Includes fall back logic so the existing and new locations will work depending on the file that is available. * ee0c4d26b Roll flutter/packages to 25454e (flutter/engine#38685) (flutter#118205) * Roll Flutter Engine from ee0c4d26b0fa to 264aa032cf75 (2 revisions) (flutter#118208) * 5a39a8846 Add CI builder for windows-arm64. (flutter/engine#38394) * 264aa032c Revert "Add CI builder for windows-arm64. (flutter#38394)" (flutter/engine#38729) * 9c0b187a1 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (flutter#118210) * add closed/open focus traversal; use open on web (flutter#115961) * allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments * Roll Flutter Engine from 9c0b187a1139 to 716bb9172c0d (3 revisions) (flutter#118220) * b6720a5b7 Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) * 4f0cdcd0b Inline usage of SkIsPow2 (flutter/engine#38722) * 716bb9172 [Impeller Scene] Add DisplayList OP and Dart bindings (flutter/engine#38676) * Hide InkWell hover highlight when an hovered InkWell is disabled (flutter#118026) * Allow select cases to be numbers (flutter#116625) * [Impeller Scene] Add SceneC asset importing (flutter#118157) * Add a comment about repeat event + fix typos (flutter#118095) * Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (flutter#116894) * Roll Flutter Engine from 716bb9172c0d to 687e3cb0fbe2 (2 revisions) (flutter#118242) * 24ee5c10f Roll Fuchsia Mac SDK from ORxExaprF9fW5d4MP... to zC90VpkAGMG1jJ-BK... (flutter/engine#38734) * 687e3cb0f Roll Dart SDK from 418bee5da2e2 to 8d7a6aabd3a3 (2 revisions) (flutter/engine#38738) * Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (flutter#118253) * d03de2fce [tool] Don't add Guava in the all-packages app (flutter/plugins#6747) * d485c7e83 [local_auth]: Bump espresso-core (flutter/plugins#6925) * a47e71988 [webview_flutter_platform_interface] Improves error message when `WebViewPlatform.instance` is null (flutter/plugins#6938) * 7132dac0e [google_maps]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/plugins#6937) * dc3287ccf [espresso]: Bump truth from 1.4.0 to 1.5.0 in /packages/espresso/android (flutter/plugins#6707) * 1de6477bd [camera]: Bump camerax_version from 1.3.0-alpha01 to 1.3.0-alpha02 in /packages/camera/camera_android_camerax/android (flutter/plugins#6828) * fb405819e [shared_preferences] Merge iOS and macOS implementations (flutter/plugins#6920) * 9fdc899b7 [various] Enable `avoid_dynamic_calls` (flutter/plugins#6834) * Manually mark Windows run_debug_test_windows as unflaky (flutter#118112) * Marks Mac_arm64_android run_debug_test_android to be unflaky (flutter#117469) * Marks Mac_arm64_ios run_debug_test_macos to be unflaky (flutter#117990) * remove unsound mode web test (flutter#118256) * Update `CupertinoPicker` example (flutter#118248) * Update `CupertinoPicker` example * format lines * Revert making variable public * revert variable change * roll packages (flutter#118117) * Add option for opting out of enter route snapshotting. (flutter#118086) * Add option for opting out of enter route snapshotting. * Fix typo. * Merge find layers logic. * Add justification comment on why web is skipped in test. * Update documentation as suggested. * Update documentation as suggested. * roll packages (flutter#118272) * Roll Flutter Engine from 687e3cb0fbe2 to c1d61cf11da8 (6 revisions) (flutter#118274) * ad9052a38 Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter/engine#38740) * c4c97023f Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter/engine#38721) * f40af3eb4 Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter/engine#38744) * 41cfbdd7e Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter/engine#38746) * 95c7b1f8a Make operator == parameter non-nullable (flutter/engine#38663) * c1d61cf11 Move canvaskit artifacts to expected location in Web SDK Archive (flutter/engine#38168) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * ae9e181e3 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (flutter#118287) * Fix Finnish TimeOfDate format (flutter#118204) * init * add test * Roll Flutter Engine from ae9e181e30c2 to 53bd4bbf9646 (3 revisions) (flutter#118289) * b9a723482 [web] retain GL/Gr context on window resize (flutter/engine#38576) * fd4360671 Add SpringAnimation.js from React Native (flutter/engine#38750) * 53bd4bbf9 Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter/engine#38758) * 9ade91c8b removed forbidden skia include (flutter/engine#38761) (flutter#118296) * 8d7beac82 Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (flutter#118297) * 6256f05db Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (flutter#118300) * FIX: UnderlineInputBorder hashCode and equality by including borderRadius (flutter#118284) * Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter#118116) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@83fd05a...0b7f8ab) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (flutter#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93ea575...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6048f9110 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (flutter#118320) * Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (flutter#118317) * 6a24f2d7b == override parameters are non-nullable (flutter/plugins#6900) * b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter/plugins#6933) * b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter/plugins#6902) * 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter/plugins#6915) * ee76ab71e Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (flutter#118335) * Roll Flutter Engine from ee76ab71e0a6 to cccaae2f3d8b (3 revisions) (flutter#118349) * 5ec03d7d1 Roll Fuchsia Mac SDK from a9NpYJbjhDRX9P9u4... to ao8fSjW8HrZSsu3yq... (flutter/engine#38782) * 87ead948e delete include of private GrMtlTypes header (flutter/engine#38783) * cccaae2f3 [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) * 764a9e012 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (flutter#118355) * Roll Flutter Engine from 764a9e01204d to 4a8d6866a1c0 (2 revisions) (flutter#118357) * 7abc5f13a [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter/engine#38786) * 4a8d6866a Add CI builder for windows-arm64. (flutter#38394) (flutter/engine#38739) * Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (flutter#111570) * Marks Mac channels_integration_test to be unflaky (flutter#111571) * Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (flutter#116668) * Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (flutter#118322) * docs: update docs about color property in material card (flutter#117263) * update docs * * * typo * Revert "typo" This reverts commit 3e25d4be337b1a41d24b1a86136606d6551b30cf. * Update card.dart * Update card.dart * Update card.dart * Fix M3 `Drawer` default shape in RTL (flutter#118185) * [M3] Add error state support for side property of CheckBox (flutter#118386) * Add error state support for side property * lint fixes * lint fixes * Roll Plugins from 620a059d62b2 to 39197f17ca59 (6 revisions) (flutter#118391) * 8c461cfde [gh_actions]: Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (flutter/plugins#6882) * a119afd47 [in_app_pur]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6924) * 12266846e Roll Flutter from 5070620 to 7ddf42e (5 revisions) (flutter/plugins#6923) * 44098fe34 [shared_preferences] Switch to `shared_preferences_foundation` (flutter/plugins#6940) * 0dd166959 [tool] Replace `flutter format` (flutter/plugins#6946) * 39197f17c [gh_actions]: Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/plugins#6935) * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <[email protected]> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <[email protected]> * IconButtonTheme should be overridden by the AppBar/AppBarTheme's iconTheme and actionsIconTheme (flutter#118216) * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * [web] Update build to use generated JS runtime for Dart2Wasm. (flutter#118359) * Roll Flutter Engine from 4a8d6866a1c0 to c01465a18f31 (9 revisions) (flutter#118409) * 2d2c5e7eb Roll Dart SDK from 22fa50e09ee8 to 21f5de0ad596 (2 revisions) (flutter/engine#38796) * 24eb954da fix canvas drawLine bugs (flutter/engine#38753) * 2b024cbb6 [Impeller Scene] Change how property resolution works to fix Animation blending; add mutation log to nodes; enable backface culling; add vertex color contribution back to meshes (flutter/engine#38766) * 0192ea15e Roll Dart SDK from 21f5de0ad596 to 7879aa93da71 (1 revision) (flutter/engine#38804) * 5cd50f568 Roll Fuchsia Mac SDK from ao8fSjW8HrZSsu3yq... to gZ6xbsp2MRsoXfKgY... (flutter/engine#38806) * 4bf70c011 Roll Dart SDK from 7879aa93da71 to d7235947ff9b (1 revision) (flutter/engine#38808) * bb2d5e93a Roll Dart SDK from d7235947ff9b to edd406c07399 (2 revisions) (flutter/engine#38814) * 2a9fa7975 Revert "fix canvas drawLine bugs (flutter#38753)" (flutter/engine#38815) * c01465a18 Add wasm_release build to linux_host_engine.json (flutter/engine#38755) * Add MSYS2 detection on Windows Terminal (flutter#117612) As the results of "uname -s" command is like the below on MSYS2 on Windows Terminal, MSYS_NT-10.0-22621 This patch fixes the Flutter command working on this kind of systems. Signed-off-by: Deokgyu Yang <[email protected]> Signed-off-by: Deokgyu Yang <[email protected]> * Add documentation for drag/fling offset in WidgetController. (flutter#118288) * Documentation for drag/fling offset * Fix typo * Fix typo 2 * Fix the docs_test * Fix the grammar * 688015782 fixed glfw example for arm64 (flutter/engine#38426) (flutter#118413) * Use correct API docs link in create --sample help message (flutter#118371) * Use correct API doc link in create --sample help message * Verify Flutter and Dart website links in tool help messages use https * Adjust test failure reasoning message * Roll Flutter Engine from 688015782762 to 35cfe9158648 (2 revisions) (flutter#118415) * e9b7a2d38 [macOS] Do not block raster thread when shutting down (flutter/engine#38777) * 35cfe9158 Roll Fuchsia Mac SDK from gZ6xbsp2MRsoXfKgY... to nIPtQ59jG1pxyatOq... (flutter/engine#38819) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <[email protected]> * 8aa26baa9 Roll Dart SDK from edd406c07399 to 20cca507d98b (1 revision) (flutter/engine#38823) (flutter#118420) * add generated_plugins.cmake (flutter#116581) Added files to the .gitignore that are generated on each "flutter pub get", so it's useless to ever commit these to a git repository. * Enable xcode cache cleanup for a few days. (flutter#118419) This is to ensure the xcode caches get back to a normal state as they seem to have gotten into a bad state after updating the xcode version. Bug: flutter#118324 Bug: flutter#118327 Bug: flutter#118328 * 99509a7e4 Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) (flutter#118425) * Roll Flutter Engine from 99509a7e4275 to f3f05368033b (2 revisions) (flutter#118429) * 091c785a4 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) * f3f053680 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * a62d25326 Roll Skia from dfb838747295 to cc983d28f3bf (27 revisions) (flutter/engine#38830) (flutter#118435) * dfa0327f8 Roll Skia from cc983d28f3bf to fd54be29a3cc (3 revisions) (flutter/engine#38833) (flutter#118436) * 07603c6d4 Roll Dart SDK from 20cca507d98b to 3d629d00a8d7 (2 revisions) (flutter/engine#38834) (flutter#118439) * Fix copying/applying font fallback with package (flutter#118393) * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * dec608917 Roll Fuchsia Mac SDK from nIPtQ59jG1pxyatOq... to 21nYb648VWbpxc36t... (flutter/engine#38839) (flutter#118445) * 970889b87 Roll Skia from fd54be29a3cc to c72c7bf7e45b (3 revisions) (flutter/engine#38840) (flutter#118448) * a512cebdc Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (flutter#118454) * Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (flutter#118457) * b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter/plugins#6948) * 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter/plugins#6635) * be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter/plugins#6952) * 92a5367d5 [tool] Fix false positives in update-exceprts (flutter/plugins#6950) * Added LinearBorder, an OutlinedBorder like BoxBorder (flutter#116940) * Marks Mac_ios spell_check_test to be unflaky (flutter#117743) * [Linux] Add a 'flutter run' console output test (flutter#118279) * Add Linux support for the UI integration test project * Add Linux run console test * Add Info.plist from build directory as input path to Thin Binary build phase (flutter#118209) * Add Info.plist from build directory as input path to Thin Binary build phase * fix directive ordering * migrate benchmark, integration, and example tests * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter#118482) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.37 to 2.1.38. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@959cbb7...515828d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove whitespace * add newline * newline fixes * newline fix * test fix * Update documentation about accent color (flutter#116778) * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (flutter#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <[email protected]> * roll packages (flutter#117940) * roll packages (flutter#118001) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * [Impeller Scene] Add SceneC asset importing (flutter#118157) * roll packages (flutter#118117) * roll packages (flutter#118272) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <[email protected]> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <[email protected]> * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <[email protected]> * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * remove whitespace * fix rebase mess Signed-off-by: Morris Kurz <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Deokgyu Yang <[email protected]> Co-authored-by: Pierre-Louis <[email protected]> Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Jesús S Guerrero <[email protected]> Co-authored-by: Darren Austin <[email protected]> Co-authored-by: Ahmed Ashour <[email protected]> Co-authored-by: Michael Goderbauer <[email protected]> Co-authored-by: Greg Price <[email protected]> Co-authored-by: CicadaCinema <[email protected]> Co-authored-by: Tae Hyung Kim <[email protected]> Co-authored-by: Renzo Olivares <[email protected]> Co-authored-by: Renzo Olivares <[email protected]> Co-authored-by: Sam Rawlins <[email protected]> Co-authored-by: Peixin Li <[email protected]> Co-authored-by: Callum Moffat <[email protected]> Co-authored-by: Vyacheslav Egorov <[email protected]> Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: Flutter GitHub Bot <[email protected]> Co-authored-by: Camille Simon <[email protected]> Co-authored-by: LongCatIsLooong <[email protected]> Co-authored-by: Drew Roen <[email protected]> Co-authored-by: Jason Simmons <[email protected]> Co-authored-by: Nehal Patel <[email protected]> Co-authored-by: gmackall <[email protected]> Co-authored-by: Gray Mackall <[email protected]> Co-authored-by: Mohammed CHAHBOUN <[email protected]> Co-authored-by: Alex Wallen <[email protected]> Co-authored-by: a-wallen <[email protected]> Co-authored-by: Morris Kurz <[email protected]> Co-authored-by: Lucas.Xu <[email protected]> Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Helin Shiah <[email protected]> Co-authored-by: Taha Tesser <[email protected]> Co-authored-by: Nicholas Shahan <[email protected]> Co-authored-by: Yegor <[email protected]> Co-authored-by: Bruno Leroux <[email protected]> Co-authored-by: Brandon DeRosier <[email protected]> Co-authored-by: Loïc Sharma <[email protected]> Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: Youchen Du <[email protected]> Co-authored-by: Sigurd Meldgaard <[email protected]> Co-authored-by: Rydmike <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suhwan Cha <[email protected]> Co-authored-by: Andrew Kolos <[email protected]> Co-authored-by: Qun Cheng <[email protected]> Co-authored-by: joshualitt <[email protected]> Co-authored-by: Deokgyu Yang <[email protected]> Co-authored-by: Peixin Li <[email protected]> Co-authored-by: Parker Lougheed <[email protected]> Co-authored-by: Ivo Beckers <[email protected]> Co-authored-by: godofredoc <[email protected]> Co-authored-by: Bernardo Ferrari <[email protected]> Co-authored-by: Dennis Kugelmann <[email protected]> Co-authored-by: Hans Muller <[email protected]> Co-authored-by: Victoria Ashworth <[email protected]>
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <[email protected]> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <[email protected]> * comment fixes * test update * docstring fixes * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * 4dd8a694f Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter/engine#38560) (flutter#117783) * 3460f349b [fuchsia] Set presentation interval (flutter/engine#38549) (flutter#117785) * Roll Flutter Engine from 3460f349b01d to 1752b5b84680 (2 revisions) (flutter#117788) * 332c0a2f2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561) * 1752b5b84 Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563) * a63bd854a [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) (flutter#117790) * Roll Flutter Engine from a63bd854ac5a to 5713a216076f (2 revisions) (flutter#117795) * e012dc825 [Windows] Add engine builder to simplify tests (flutter/engine#38546) * 5713a2160 Revert "[web] Don't overwrite editing state with semantic updates (flutter#38271)" (flutter/engine#38562) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (flutter#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * 9095f7a8b Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter/engine#38569) (flutter#117799) * 0118b461b Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter/engine#38571) (flutter#117800) * e03d7c8bb Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter/engine#38572) (flutter#117802) * af6078b5f Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter/engine#38574) (flutter#117804) * 7e5cc7bb6 Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter/engine#38575) (flutter#117805) * d4a04a538 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter/engine#38578) (flutter#117817) * b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter/plugins#6892) (flutter#117824) * Roll Flutter Engine from d4a04a538050 to 9153966bcb06 (2 revisions) (flutter#117830) * 53806fa1e Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579) * 9153966bc [fuchsia] Bump the target API level to 11 (flutter/engine#38544) * b9bf51d16 Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter/engine#38580) (flutter#117832) * Roll Flutter Engine from b9bf51d16f25 to f6ad9b6d00e3 (2 revisions) (flutter#117834) * 4b38736e7 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577) * f6ad9b6d0 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581) * 932591ec0 Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter/engine#38584) (flutter#117840) * 3d8c5ef10 Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter/engine#38585) (flutter#117846) * Roll Flutter Engine from 3d8c5ef1060c to a7decc3e459b (2 revisions) (flutter#117856) * 3470fa848 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586) * a7decc3e4 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587) * 0a2029cf3 Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter/engine#38588) (flutter#117858) * 5fe7d5b4e Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter/engine#38591) (flutter#117863) * e5d605b3a Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter/engine#38592) (flutter#117865) * 71c5f1704 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter/engine#38593) (flutter#117868) * 472e34cbb Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter/engine#38594) (flutter#117869) * Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (flutter#117875) * 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter/plugins#6896) * 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter/plugins#6901) * e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter/plugins#6908) * [flutter_tools] timeline_test.dart flaky (flutter#116667) * contains name instead of remove last * fix expect * remove and expect on elements * delete unused code * 7e51aef0a Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (flutter#117874) * Updated to tokens v0.150. (flutter#117350) * Updated to tokens v0.150. * Updated with a reverted list_tile.dart. * Simplify null check. (flutter#117026) * Simplify null check. * Simplify null check. * Simplify null check. * Fix. * Roll Flutter Engine from 7e51aef0a1be to 1d2ba73d1059 (9 revisions) (flutter#117923) * 3e1b0dcb2 Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter/engine#38597) * 8b17efed8 Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter/engine#38598) * 27960a700 [Impeller Scene] Import animation data (flutter/engine#38583) * b5acb2099 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter/engine#38599) * dd0335b34 Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter/engine#38601) * adda2e80c [Impeller Scene] Animation binding and playback (flutter/engine#38595) * 71a296d53 Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter/engine#38607) * bde8d4524 Implement ITextProvider and ITextRangeProvider for UIA (flutter/engine#38538) * 1d2ba73d1 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) * Reland "Remove single-view assumption from ScrollPhysics (flutter#117503)" (flutter#117916) This reverts commit c956121. * Minor documentation fix on BorderRadiusDirectional.zero (flutter#117661) * fix typos (flutter#117592) * c0b3f8fce Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (flutter#117931) * Add convenience constructors for SliverList (flutter#116605) * init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again * 2213b80dd [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (flutter#117935) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <[email protected]> * == override parameters are non-nullable (flutter#117839) * Fix the message strings for xcodeMissing and xcodeIncomplete (flutter#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test * 32c468507 Roll quiver to 3.2.1 (flutter/engine#38617) (flutter#117942) * Send text direction in selection rects (flutter#117436) * Correctly propagate verbosity to subtasks in flutter.gradle (flutter#117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports * Roll Plugins from e85f8ac1502d to f9dda6a27b79 (3 revisions) (flutter#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890) * [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (flutter#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment * roll packages (flutter#117940) * roll packages (flutter#118001) * [Android] Increase timeout duration for spell check integration test (flutter#117989) * Add timeout * Add library directive * Add comment, remove testing only changes * Roll Flutter Engine from 32c468507b32 to cdd3bf29e27a (8 revisions) (flutter#118014) * 22f872d5e Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9ed0 Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3bd Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dcdb Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5bf3 Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440ccd5 fix roll (flutter/engine#38635) * 87bdde8fe Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf29e make DisplayListFlags constexpr throughout (flutter/engine#38649) * 60515762e [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter/engine#38628) (flutter#118016) * 35b7dee32 [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter/engine#38497) (flutter#118017) * b9b0193ea Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter/engine#38654) (flutter#118018) * a01548f5f [Impeller Scene] Fix material/vertex color overlapping (flutter/engine#38653) (flutter#118027) * Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (flutter#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891) * 072a9ca37 Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter/engine#38646) (flutter#118039) * bb4015269 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter/engine#38659) (flutter#118042) * Avoid using `TextAffinity` in `TextBoundary` (flutter#117446) * Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests * 74861f369 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) (flutter#118048) * 5bd90d6e7 Consider more roles as text (flutter/engine#38645) (flutter#118049) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * Adding 'is' to list of kotlin reserved keywords (flutter#116299) Co-authored-by: Gray Mackall <[email protected]> * Added expandIconColor property on ExpansionPanelList Widget (flutter#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (flutter#118072) Co-authored-by: a-wallen <[email protected]> * Fix out-of-sync ExpansionPanel animation (flutter#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by: Morris Kurz <[email protected]> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by: Morris Kurz <[email protected]> * Clarify comment. Signed-off-by: Morris Kurz <[email protected]> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by: Morris Kurz <[email protected]> * Update testcases to new header height (56px -> 48px). Signed-off-by: Morris Kurz <[email protected]> * Test for header height equal to 48px. Signed-off-by: Morris Kurz <[email protected]> * Change issue number to link in comment * Add periods to comments Signed-off-by: Morris Kurz <[email protected]> * Roll Plugins from 320461910156 to 276cfd4b212d (2 revisions) (flutter#118099) * 3a6f63bed Roll Flutter from 231855f to 43b9120 (11 revisions) (flutter/plugins#6918) * 276cfd4b2 [shared_preferences] Convert macOS to Pigeon (flutter/plugins#6914) * 33d7f8a1b Remove single view assumptions from `window.dart` (flutter/engine#38453) (flutter#118069) * InteractiveViewer parameter to return to pre-3.3 trackpad/Magic Mouse behaviour (flutter#114280) * trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines * 0a0e3d205 Roll Flutter from 43b9120 to 5070620 (9 revisions) (flutter/plugins#6919) (flutter#118183) * Roll Flutter Engine from 33d7f8a1b307 to 03609b420beb (6 revisions) (flutter#118125) * c58254702 SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) * 3d9214ace Bump actions/checkout from 3.1.0 to 3.2.0 (flutter/engine#38390) * a4775c7a7 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) * 046012e8e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter/engine#38683) * cda410c28 Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter/engine#38668) * 03609b420 [web] Fix canvas2d leaks in text measurement (flutter/engine#38640) * remove the unused check in selectable_text (flutter#117716) * Roll Flutter Engine from 03609b420beb to b5513d7a442a (2 revisions) (flutter#118186) * fd5a96e10 Limit selection change to focused node on Windows (flutter/engine#38634) * b5513d7a4 Roll Dart SDK from 0b064bc49557 to cb29cb6d1d0f (12 revisions) (flutter/engine#38688) * Roll Flutter Engine from b5513d7a442a to 5bdb04f33f99 (2 revisions) (flutter#118187) * e20809014 Roll Skia from 54dbda290908 to b8c0a78a2378 (43 revisions) (flutter/engine#38690) * 5bdb04f33 Roll Fuchsia Mac SDK from Bewt-eq7gNu6sU_Ob... to ORxExaprF9fW5d4MP... (flutter/engine#38697) * 51baed6e0 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (flutter#118189) * Update to Xcode 14.2 (flutter#117507) * Update to Xcode 14.2 * Only bump for devicelab builders * Restore presubmit: false * Allow iOS and macOS plugins to share darwin directory (flutter#115337) * Roll Flutter Engine from 51baed6e01b8 to 5df0072a0e63 (3 revisions) (flutter#118192) * 181286315 Roll Dart SDK from cb29cb6d1d0f to 853eff8b0faa (2 revisions) (flutter/engine#38694) * 642f72f73 Bump actions/upload-artifact from 3.1.0 to 3.1.2 (flutter/engine#38713) * 5df0072a0 Bump actions/checkout from 3.2.0 to 3.3.0 (flutter/engine#38714) * Use program during attach if provided (flutter#118130) * eb5c6f0b4 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (flutter#118197) * Update `ListTile` to support Material 3 (flutter#117965) * Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add flutter#99933 HTML workaround. * 3a7d8862f Re-enable UIA text/range provider unit tests (flutter/engine#38718) (flutter#118201) * Fix path for require.js (flutter#118120) - Matches new location in the Dart SDK. https://dart-review.googlesource.com/c/sdk/+/275482 - Includes fall back logic so the existing and new locations will work depending on the file that is available. * ee0c4d26b Roll flutter/packages to 25454e (flutter/engine#38685) (flutter#118205) * Roll Flutter Engine from ee0c4d26b0fa to 264aa032cf75 (2 revisions) (flutter#118208) * 5a39a8846 Add CI builder for windows-arm64. (flutter/engine#38394) * 264aa032c Revert "Add CI builder for windows-arm64. (flutter#38394)" (flutter/engine#38729) * 9c0b187a1 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (flutter#118210) * add closed/open focus traversal; use open on web (flutter#115961) * allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments * Roll Flutter Engine from 9c0b187a1139 to 716bb9172c0d (3 revisions) (flutter#118220) * b6720a5b7 Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) * 4f0cdcd0b Inline usage of SkIsPow2 (flutter/engine#38722) * 716bb9172 [Impeller Scene] Add DisplayList OP and Dart bindings (flutter/engine#38676) * Hide InkWell hover highlight when an hovered InkWell is disabled (flutter#118026) * Allow select cases to be numbers (flutter#116625) * [Impeller Scene] Add SceneC asset importing (flutter#118157) * Add a comment about repeat event + fix typos (flutter#118095) * Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (flutter#116894) * Roll Flutter Engine from 716bb9172c0d to 687e3cb0fbe2 (2 revisions) (flutter#118242) * 24ee5c10f Roll Fuchsia Mac SDK from ORxExaprF9fW5d4MP... to zC90VpkAGMG1jJ-BK... (flutter/engine#38734) * 687e3cb0f Roll Dart SDK from 418bee5da2e2 to 8d7a6aabd3a3 (2 revisions) (flutter/engine#38738) * Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (flutter#118253) * d03de2fce [tool] Don't add Guava in the all-packages app (flutter/plugins#6747) * d485c7e83 [local_auth]: Bump espresso-core (flutter/plugins#6925) * a47e71988 [webview_flutter_platform_interface] Improves error message when `WebViewPlatform.instance` is null (flutter/plugins#6938) * 7132dac0e [google_maps]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/plugins#6937) * dc3287ccf [espresso]: Bump truth from 1.4.0 to 1.5.0 in /packages/espresso/android (flutter/plugins#6707) * 1de6477bd [camera]: Bump camerax_version from 1.3.0-alpha01 to 1.3.0-alpha02 in /packages/camera/camera_android_camerax/android (flutter/plugins#6828) * fb405819e [shared_preferences] Merge iOS and macOS implementations (flutter/plugins#6920) * 9fdc899b7 [various] Enable `avoid_dynamic_calls` (flutter/plugins#6834) * Manually mark Windows run_debug_test_windows as unflaky (flutter#118112) * Marks Mac_arm64_android run_debug_test_android to be unflaky (flutter#117469) * Marks Mac_arm64_ios run_debug_test_macos to be unflaky (flutter#117990) * remove unsound mode web test (flutter#118256) * Update `CupertinoPicker` example (flutter#118248) * Update `CupertinoPicker` example * format lines * Revert making variable public * revert variable change * roll packages (flutter#118117) * Add option for opting out of enter route snapshotting. (flutter#118086) * Add option for opting out of enter route snapshotting. * Fix typo. * Merge find layers logic. * Add justification comment on why web is skipped in test. * Update documentation as suggested. * Update documentation as suggested. * roll packages (flutter#118272) * Roll Flutter Engine from 687e3cb0fbe2 to c1d61cf11da8 (6 revisions) (flutter#118274) * ad9052a38 Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter/engine#38740) * c4c97023f Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter/engine#38721) * f40af3eb4 Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter/engine#38744) * 41cfbdd7e Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter/engine#38746) * 95c7b1f8a Make operator == parameter non-nullable (flutter/engine#38663) * c1d61cf11 Move canvaskit artifacts to expected location in Web SDK Archive (flutter/engine#38168) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * ae9e181e3 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (flutter#118287) * Fix Finnish TimeOfDate format (flutter#118204) * init * add test * Roll Flutter Engine from ae9e181e30c2 to 53bd4bbf9646 (3 revisions) (flutter#118289) * b9a723482 [web] retain GL/Gr context on window resize (flutter/engine#38576) * fd4360671 Add SpringAnimation.js from React Native (flutter/engine#38750) * 53bd4bbf9 Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter/engine#38758) * 9ade91c8b removed forbidden skia include (flutter/engine#38761) (flutter#118296) * 8d7beac82 Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (flutter#118297) * 6256f05db Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (flutter#118300) * FIX: UnderlineInputBorder hashCode and equality by including borderRadius (flutter#118284) * Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter#118116) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@83fd05a...0b7f8ab) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (flutter#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93ea575...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6048f9110 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (flutter#118320) * Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (flutter#118317) * 6a24f2d7b == override parameters are non-nullable (flutter/plugins#6900) * b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter/plugins#6933) * b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter/plugins#6902) * 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter/plugins#6915) * ee76ab71e Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (flutter#118335) * Roll Flutter Engine from ee76ab71e0a6 to cccaae2f3d8b (3 revisions) (flutter#118349) * 5ec03d7d1 Roll Fuchsia Mac SDK from a9NpYJbjhDRX9P9u4... to ao8fSjW8HrZSsu3yq... (flutter/engine#38782) * 87ead948e delete include of private GrMtlTypes header (flutter/engine#38783) * cccaae2f3 [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) * 764a9e012 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (flutter#118355) * Roll Flutter Engine from 764a9e01204d to 4a8d6866a1c0 (2 revisions) (flutter#118357) * 7abc5f13a [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter/engine#38786) * 4a8d6866a Add CI builder for windows-arm64. (flutter#38394) (flutter/engine#38739) * Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (flutter#111570) * Marks Mac channels_integration_test to be unflaky (flutter#111571) * Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (flutter#116668) * Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (flutter#118322) * docs: update docs about color property in material card (flutter#117263) * update docs * * * typo * Revert "typo" This reverts commit 3e25d4be337b1a41d24b1a86136606d6551b30cf. * Update card.dart * Update card.dart * Update card.dart * Fix M3 `Drawer` default shape in RTL (flutter#118185) * [M3] Add error state support for side property of CheckBox (flutter#118386) * Add error state support for side property * lint fixes * lint fixes * Roll Plugins from 620a059d62b2 to 39197f17ca59 (6 revisions) (flutter#118391) * 8c461cfde [gh_actions]: Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (flutter/plugins#6882) * a119afd47 [in_app_pur]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6924) * 12266846e Roll Flutter from 5070620 to 7ddf42e (5 revisions) (flutter/plugins#6923) * 44098fe34 [shared_preferences] Switch to `shared_preferences_foundation` (flutter/plugins#6940) * 0dd166959 [tool] Replace `flutter format` (flutter/plugins#6946) * 39197f17c [gh_actions]: Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/plugins#6935) * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <[email protected]> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <[email protected]> * IconButtonTheme should be overridden by the AppBar/AppBarTheme's iconTheme and actionsIconTheme (flutter#118216) * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * [web] Update build to use generated JS runtime for Dart2Wasm. (flutter#118359) * Roll Flutter Engine from 4a8d6866a1c0 to c01465a18f31 (9 revisions) (flutter#118409) * 2d2c5e7eb Roll Dart SDK from 22fa50e09ee8 to 21f5de0ad596 (2 revisions) (flutter/engine#38796) * 24eb954da fix canvas drawLine bugs (flutter/engine#38753) * 2b024cbb6 [Impeller Scene] Change how property resolution works to fix Animation blending; add mutation log to nodes; enable backface culling; add vertex color contribution back to meshes (flutter/engine#38766) * 0192ea15e Roll Dart SDK from 21f5de0ad596 to 7879aa93da71 (1 revision) (flutter/engine#38804) * 5cd50f568 Roll Fuchsia Mac SDK from ao8fSjW8HrZSsu3yq... to gZ6xbsp2MRsoXfKgY... (flutter/engine#38806) * 4bf70c011 Roll Dart SDK from 7879aa93da71 to d7235947ff9b (1 revision) (flutter/engine#38808) * bb2d5e93a Roll Dart SDK from d7235947ff9b to edd406c07399 (2 revisions) (flutter/engine#38814) * 2a9fa7975 Revert "fix canvas drawLine bugs (flutter#38753)" (flutter/engine#38815) * c01465a18 Add wasm_release build to linux_host_engine.json (flutter/engine#38755) * Add MSYS2 detection on Windows Terminal (flutter#117612) As the results of "uname -s" command is like the below on MSYS2 on Windows Terminal, MSYS_NT-10.0-22621 This patch fixes the Flutter command working on this kind of systems. Signed-off-by: Deokgyu Yang <[email protected]> Signed-off-by: Deokgyu Yang <[email protected]> * Add documentation for drag/fling offset in WidgetController. (flutter#118288) * Documentation for drag/fling offset * Fix typo * Fix typo 2 * Fix the docs_test * Fix the grammar * 688015782 fixed glfw example for arm64 (flutter/engine#38426) (flutter#118413) * Use correct API docs link in create --sample help message (flutter#118371) * Use correct API doc link in create --sample help message * Verify Flutter and Dart website links in tool help messages use https * Adjust test failure reasoning message * Roll Flutter Engine from 688015782762 to 35cfe9158648 (2 revisions) (flutter#118415) * e9b7a2d38 [macOS] Do not block raster thread when shutting down (flutter/engine#38777) * 35cfe9158 Roll Fuchsia Mac SDK from gZ6xbsp2MRsoXfKgY... to nIPtQ59jG1pxyatOq... (flutter/engine#38819) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <[email protected]> * 8aa26baa9 Roll Dart SDK from edd406c07399 to 20cca507d98b (1 revision) (flutter/engine#38823) (flutter#118420) * add generated_plugins.cmake (flutter#116581) Added files to the .gitignore that are generated on each "flutter pub get", so it's useless to ever commit these to a git repository. * Enable xcode cache cleanup for a few days. (flutter#118419) This is to ensure the xcode caches get back to a normal state as they seem to have gotten into a bad state after updating the xcode version. Bug: flutter#118324 Bug: flutter#118327 Bug: flutter#118328 * 99509a7e4 Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) (flutter#118425) * Roll Flutter Engine from 99509a7e4275 to f3f05368033b (2 revisions) (flutter#118429) * 091c785a4 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) * f3f053680 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * a62d25326 Roll Skia from dfb838747295 to cc983d28f3bf (27 revisions) (flutter/engine#38830) (flutter#118435) * dfa0327f8 Roll Skia from cc983d28f3bf to fd54be29a3cc (3 revisions) (flutter/engine#38833) (flutter#118436) * 07603c6d4 Roll Dart SDK from 20cca507d98b to 3d629d00a8d7 (2 revisions) (flutter/engine#38834) (flutter#118439) * Fix copying/applying font fallback with package (flutter#118393) * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * dec608917 Roll Fuchsia Mac SDK from nIPtQ59jG1pxyatOq... to 21nYb648VWbpxc36t... (flutter/engine#38839) (flutter#118445) * 970889b87 Roll Skia from fd54be29a3cc to c72c7bf7e45b (3 revisions) (flutter/engine#38840) (flutter#118448) * a512cebdc Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (flutter#118454) * Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (flutter#118457) * b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter/plugins#6948) * 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter/plugins#6635) * be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter/plugins#6952) * 92a5367d5 [tool] Fix false positives in update-exceprts (flutter/plugins#6950) * Added LinearBorder, an OutlinedBorder like BoxBorder (flutter#116940) * Marks Mac_ios spell_check_test to be unflaky (flutter#117743) * [Linux] Add a 'flutter run' console output test (flutter#118279) * Add Linux support for the UI integration test project * Add Linux run console test * Add Info.plist from build directory as input path to Thin Binary build phase (flutter#118209) * Add Info.plist from build directory as input path to Thin Binary build phase * fix directive ordering * migrate benchmark, integration, and example tests * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter#118482) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.37 to 2.1.38. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@959cbb7...515828d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove whitespace * add newline * newline fixes * newline fix * test fix * Update documentation about accent color (flutter#116778) * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (flutter#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <[email protected]> * roll packages (flutter#117940) * roll packages (flutter#118001) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * [Impeller Scene] Add SceneC asset importing (flutter#118157) * roll packages (flutter#118117) * roll packages (flutter#118272) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <[email protected]> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <[email protected]> * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <[email protected]> * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * remove whitespace * fix rebase mess * fix time picker tests * whitespace fix * actual whitespace fix Signed-off-by: Morris Kurz <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Deokgyu Yang <[email protected]> Co-authored-by: Pierre-Louis <[email protected]> Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Jesús S Guerrero <[email protected]> Co-authored-by: Darren Austin <[email protected]> Co-authored-by: Ahmed Ashour <[email protected]> Co-authored-by: Michael Goderbauer <[email protected]> Co-authored-by: Greg Price <[email protected]> Co-authored-by: CicadaCinema <[email protected]> Co-authored-by: Tae Hyung Kim <[email protected]> Co-authored-by: Renzo Olivares <[email protected]> Co-authored-by: Renzo Olivares <[email protected]> Co-authored-by: Sam Rawlins <[email protected]> Co-authored-by: Peixin Li <[email protected]> Co-authored-by: Callum Moffat <[email protected]> Co-authored-by: Vyacheslav Egorov <[email protected]> Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: Flutter GitHub Bot <[email protected]> Co-authored-by: Camille Simon <[email protected]> Co-authored-by: LongCatIsLooong <[email protected]> Co-authored-by: Drew Roen <[email protected]> Co-authored-by: Jason Simmons <[email protected]> Co-authored-by: Nehal Patel <[email protected]> Co-authored-by: gmackall <[email protected]> Co-authored-by: Gray Mackall <[email protected]> Co-authored-by: Mohammed CHAHBOUN <[email protected]> Co-authored-by: Alex Wallen <[email protected]> Co-authored-by: a-wallen <[email protected]> Co-authored-by: Morris Kurz <[email protected]> Co-authored-by: Lucas.Xu <[email protected]> Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Helin Shiah <[email protected]> Co-authored-by: Taha Tesser <[email protected]> Co-authored-by: Nicholas Shahan <[email protected]> Co-authored-by: Yegor <[email protected]> Co-authored-by: Bruno Leroux <[email protected]> Co-authored-by: Brandon DeRosier <[email protected]> Co-authored-by: Loïc Sharma <[email protected]> Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: Youchen Du <[email protected]> Co-authored-by: Sigurd Meldgaard <[email protected]> Co-authored-by: Rydmike <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suhwan Cha <[email protected]> Co-authored-by: Andrew Kolos <[email protected]> Co-authored-by: Qun Cheng <[email protected]> Co-authored-by: joshualitt <[email protected]> Co-authored-by: Deokgyu Yang <[email protected]> Co-authored-by: Peixin Li <[email protected]> Co-authored-by: Parker Lougheed <[email protected]> Co-authored-by: Ivo Beckers <[email protected]> Co-authored-by: godofredoc <[email protected]> Co-authored-by: Bernardo Ferrari <[email protected]> Co-authored-by: Dennis Kugelmann <[email protected]> Co-authored-by: Hans Muller <[email protected]> Co-authored-by: Victoria Ashworth <[email protected]>
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* 9aa2ea1 Roll Flutter Engine from 0a6a4a58f4f7 to db5605ea7115 (11 revisions) (flutter/flutter#117109) * 409a39d remove debugPrint from timePicker test (flutter/flutter#117111) * 169b49f Revert "[framework] make transform with filterQuality a rpb (#116792)" (flutter/flutter#117095) * 47300e0 Roll Plugins from 10c0293 to 78de28c (4 revisions) (flutter/flutter#117145) * dcd2170 Fix typos in scale gesture recognizer docs (flutter/flutter#117116) * fc3571e Improve documentation of `compute()` function (flutter/flutter#116878) * b122200 Roll Flutter Engine from db5605ea7115 to 29196519c124 (13 revisions) (flutter/flutter#117148) * f1d157b Add an integration test to plugin template example (flutter/flutter#117062) * ada4460 Audit `covariant` usage in tool (flutter/flutter#116930) * 1eaf5c0 [flutter_tools] tree shake icons from web builds (flutter/flutter#115886) * 91c1c70 Bump ossf/scorecard-action from 2.0.6 to 2.1.0 (flutter/flutter#117170) * c98978a Update Navigator updatePages() (flutter/flutter#116945) * 0916375 [tools]Build IPA validation UI Polish (flutter/flutter#116744) * a41c447 Pass dimension explicitly to mac x64 packaging. (flutter/flutter#117172) * 86b62a3 Tiny fix about outdated message (flutter/flutter#114391) * a34e419 Inject current `FlutterView` into tree and make available via `View.of(context)` (flutter/flutter#116924) * c7cb5f3 [flutter_tools] pin package intl and roll pub packages (flutter/flutter#117168) * 7336312 Do not filter the stderr output of "flutter run" in the devicelab run tests (flutter/flutter#117188) * fa711f7 Run packaging on presubtmit. (flutter/flutter#116943) * 76bb8ea Reland "Fix text field label animation duration and curve" (#114646)" * 80e1008 fix: #110342 unable to update rich text widget gesture recognizer (flutter/flutter#116849) * da7b832 Bottom App Bar M3 background color fix (flutter/flutter#117082) * ab47fc3 Roll Plugins from 78de28c to cbcf507 (3 revisions) (flutter/flutter#117213) * 23a2fa3 Reland "Adds API in semanticsconfiguration to decide how to merge chi… (flutter/flutter#116895) * 9102f2f Revert "Inject current `FlutterView` into tree and make available via `View.of(context)` (#116924)" (flutter/flutter#117214) * 3d0607b Defer `systemFontsDidChange` to the transientCallbacks phase (flutter/flutter#117123) * ecf9b2d Update localization of shortcut labels in menus (flutter/flutter#116681) * 0604a0e Add a recursive flag to the zip command - currently it is zipping nothing (flutter/flutter#117227) * 98e9032 [web] Allow shift + left/right keyboard shortcuts to be handled by framework on web (flutter/flutter#117217) * ebeb491 Use the name of errors, not the diagnostic messages. (flutter/flutter#117229) * 93c581a Formatted and removed lints from devicelab README.md (flutter/flutter#117239) * 5018a6c Roll Flutter Engine from 29196519c124 to d91e20879a67 (29 revisions) (flutter/flutter#117242) * 36d536a Roll Flutter Engine from d91e20879a67 to 60cf34e2abf1 (4 revisions) (flutter/flutter#117246) * c9dd458 42689eafb Sped up FlutterStandardCodec writing speed. (flutter/engine#38345) (flutter/flutter#117249) * 0a2a1d9 d45d375ae [iOS, macOS] Migrate from assert to FML_DCHECK (flutter/engine#38368) (flutter/flutter#117256) * bf5fdb9 Reland "Inject current FlutterView into tree and make available via `View.of(context)` (#116924)" (flutter/flutter#117244) * 427b2fb 901b455d0 Roll Fuchsia Mac SDK from bn5VF1-xDf-wKjIw8... to qYE6uXjRtAxy7p5HB... (flutter/engine#38373) (flutter/flutter#117258) * cee3e6c b10769998 Even though the file is pure C code, it's useful to use a C++ or Objective-C++ filename in order to use FML (assertions) in the implementation. (flutter/engine#38365) (flutter/flutter#117260) * 7b850ef f74dd5331 Roll Fuchsia Linux SDK from H6B0UgW07fc1nBtnc... to PqyqxdbUFyd8xoYIP... (flutter/engine#38377) (flutter/flutter#117262) * b20a9e0 imporve gesture recognizer semantics test cases (flutter/flutter#117257) * a82c556 3626c487a Add a missing include to display_list_matrix_clip_tracker.h (flutter/engine#38371) (flutter/flutter#117269) * 9daf2a6 Roll Flutter Engine from 3626c487a610 to 7e296985f426 (2 revisions) (flutter/flutter#117270) * d0d13c5 51b84d69b Roll Fuchsia Mac SDK from qYE6uXjRtAxy7p5HB... to qk9nUlw83EeMMaWmE... (flutter/engine#38380) (flutter/flutter#117273) * 725049f 794370b9c Roll Fuchsia Linux SDK from PqyqxdbUFyd8xoYIP... to bloqad357AGI6lnOb... (flutter/engine#38381) (flutter/flutter#117276) * 49f3ca4 eeae936f9 Use canvaskit `toByteData` for unsupported videoFrame formats (flutter/engine#38361) (flutter/flutter#117279) * c0dddac Fix is canvas kit bool (flutter/flutter#116944) * d88d524 276327f7e Roll Fuchsia Mac SDK from qk9nUlw83EeMMaWmE... to DdU--deE0Xl4TQ2Bm... (flutter/engine#38383) (flutter/flutter#117286) * b7d9be0 747a9d8c7 Roll Skia from 7b0a9d9a3008 to 0362c030efa7 (9 revisions) (flutter/engine#38385) (flutter/flutter#117289) * 1233fc9 37387019b Roll Fuchsia Linux SDK from bloqad357AGI6lnOb... to mRBUNknZk43y-LHGS... (flutter/engine#38386) (flutter/flutter#117290) * a3a0048 3c6cab032 Roll Fuchsia Mac SDK from DdU--deE0Xl4TQ2Bm... to NLb_T58g0l_X46JEN... (flutter/engine#38387) (flutter/flutter#117295) * 420c6d6 Roll Flutter Engine from 3c6cab03274f to 58ab5277a7c4 (2 revisions) (flutter/flutter#117312) * d238bed Roll Plugins from cbcf507 to 840a049 (8 revisions) (flutter/flutter#117314) * 3eefb7a a9491515f Roll Skia from 0362c030efa7 to fc0ac31a46f8 (4 revisions) (flutter/engine#38399) (flutter/flutter#117317) * 9f9010f [flutter_tools] Update DAP progress when waiting for Dart Debug extension connection (flutter/flutter#116892) * 32da250 a12dadfda Roll Fuchsia Mac SDK from NLb_T58g0l_X46JEN... to NS4fVXM2KhKcZ1uyD... (flutter/engine#38400) (flutter/flutter#117319) * cb988c7 Add `indicatorColor` & `indicatorShape` to `NavigationRail`, `NavigationDrawer` and move these properties from destination to `NavigationBar` (flutter/flutter#117049) * 5fcb48d Fix `NavigationRail` highlight (flutter/flutter#117320) * 70f391d 7bc519375 Roll Skia from fc0ac31a46f8 to 46af4ad25426 (1 revision) (flutter/engine#38403) (flutter/flutter#117322) * 9f2c5d8 Support `flutter build web --wasm` (flutter/flutter#117075) * 55584ad Roll Flutter Engine from 7bc519375b7b to 45713ea10510 (2 revisions) (flutter/flutter#117330) * 4daff08 Roll Flutter Engine from 45713ea10510 to cba3a3990138 (5 revisions) (flutter/flutter#117336) * 1adc275 Bump min SDK to 2.19.0-0 (flutter/flutter#117345) * efadc34 Roll Flutter Engine from cba3a3990138 to 6de29d1cba70 (3 revisions) (flutter/flutter#117354) * b30947b roll packages (flutter/flutter#117226) * e625e5f 3330cce60 Roll Fuchsia Linux SDK from yGQvkNl85l1TSeuo9... to uKNwsaf92uZcX_QiY... (flutter/engine#38411) (flutter/flutter#117358) * 50a23d9 339791f19 Roll Skia from 8876daf17554 to e8c3fa6d7d2f (3 revisions) (flutter/engine#38413) (flutter/flutter#117366) * 7f7a877 Implemented Scrim Focus for BottomSheet (flutter/flutter#116743) * 38e3930 Exposed tooltip longPress action when available (flutter/flutter#117338) * 61fb6ea Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (flutter/flutter#117372) * c64dcbe Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (flutter/flutter#117396) * 8289ea6 Move a comment where it belongs (flutter/flutter#117385) * fa3777b Enable `sized_box_shrink_expand` lint (flutter/flutter#117371) * e0742eb [Android] Add spell check suggestions toolbar (flutter/flutter#114460) * 0220afd enable use_enums (flutter/flutter#117376) * d71fa88 Bump ossf/scorecard-action from 2.1.0 to 2.1.1 (flutter/flutter#117337) * 4591f05 roll packages (flutter/flutter#117357) * 46bb853 Revert "Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (#117396)" (flutter/flutter#117402) * 81bc54b Enable `use_colored_box` lint (flutter/flutter#117370) * fdd2d7d Sync analysis_options.yaml & cleanups (flutter/flutter#117327) * de35764 [Android] Bump template AGP and NDK versions (flutter/flutter#116536) * b308555 Enable `dangling_library_doc_comments` and `library_annotations` lints (flutter/flutter#117365) * b3c7fe3 enable test_ownership in presubmit (flutter/flutter#117414) * 014b8f7 Roll Flutter Engine from 7ee3bf518036 to 75d75575d0ea (12 revisions) (flutter/flutter#117421) * cd0f15a Add support for double tap and drag for text selection (flutter/flutter#109573) * e8e26b6 c7eae2901 [Impeller] Remove depth/stencil attachments from imgui pipeline (flutter/engine#38427) (flutter/flutter#117425) * a3e7fe3 de59f842a Roll Dart SDK from 35f6108ef685 to 1530a824fd5f (6 revisions) (flutter/engine#38431) (flutter/flutter#117429) * 1699351 4724a91af Roll Skia from 09d796c0a728 to a60f3f6214d3 (5 revisions) (flutter/engine#38432) (flutter/flutter#117433) * 9024c95 28f344ceb Roll Dart SDK from 1530a824fd5f to 8078926ca996 (1 revision) (flutter/engine#38434) (flutter/flutter#117435) * cae7846 c9ee05b68 use min/max sandwich test on unit test bounds (flutter/engine#38435) (flutter/flutter#117442) * 6819f72 Roll Flutter Engine from c9ee05b68e6e to 2404db80ae80 (3 revisions) (flutter/flutter#117443) * f5c0716 4910ff889 Roll Fuchsia Mac SDK from nJJfWIwH5zElheIX8... to UsYNZnnfR_s0OGQoX... (flutter/engine#38444) (flutter/flutter#117454) * a7a5d14 Roll Plugins from 840a049 to 54fc206 (6 revisions) (flutter/flutter#117456) * 51a3e3a 1e695f453 Roll Dart SDK from 778a29535ab5 to 62ea309071c6 (1 revision) (flutter/engine#38445) (flutter/flutter#117459) * d1244b7 da77d1a3a Roll Skia from 2e3ee507e838 to 7ad6f27aff57 (1 revision) (flutter/engine#38447) (flutter/flutter#117474) * 400b05a Manual package roll (flutter/flutter#117439) * 9a347fb Support safe area and scrolling in the NavigationDrawer (flutter/flutter#116995) * 2a50236 Add native unit tests to iOS and macOS templates (flutter/flutter#117147) * 1970bc9 cacheWidth cacheHeight support for canvaskit on web (flutter/flutter#117423) * ff347bf Fix `InkRipple` doesn't respect `rectCallback` when rendering ink circle (flutter/flutter#117395) * ddb7e43 Roll Flutter Engine from da77d1a3abb8 to 84ba80331ffe (2 revisions) (flutter/flutter#117489) * 8ff1b6e Fix Scaffold bottomSheet null exceptions (flutter/flutter#117008) * 2931e50 Handle the case of no selection rects (flutter/flutter#117419) * 39fa011 Revert "Add support for double tap and drag for text selection (#109573)" (flutter/flutter#117497) * b8b3567 Remove single-view assumption from widgets library (flutter/flutter#117480) * ca7ca3b Roll Flutter Engine from 84ba80331ffe to a90c45db3f13 (2 revisions) (flutter/flutter#117499) * 9fb1ae8 [iOS] Add task for spell check integration test (flutter/flutter#116222)
esouthren
added a commit
that referenced
this pull request
Jan 30, 2023
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <[email protected]> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <[email protected]> * comment fixes * test update * docstring fixes * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * 4dd8a694f Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter/engine#38560) (#117783) * 3460f349b [fuchsia] Set presentation interval (flutter/engine#38549) (#117785) * Roll Flutter Engine from 3460f349b01d to 1752b5b84680 (2 revisions) (#117788) * 332c0a2f2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561) * 1752b5b84 Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563) * a63bd854a [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) (#117790) * Roll Flutter Engine from a63bd854ac5a to 5713a216076f (2 revisions) (#117795) * e012dc825 [Windows] Add engine builder to simplify tests (flutter/engine#38546) * 5713a2160 Revert "[web] Don't overwrite editing state with semantic updates (#38271)" (flutter/engine#38562) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * 9095f7a8b Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter/engine#38569) (#117799) * 0118b461b Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter/engine#38571) (#117800) * e03d7c8bb Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter/engine#38572) (#117802) * af6078b5f Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter/engine#38574) (#117804) * 7e5cc7bb6 Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter/engine#38575) (#117805) * d4a04a538 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter/engine#38578) (#117817) * b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter/plugins#6892) (#117824) * Roll Flutter Engine from d4a04a538050 to 9153966bcb06 (2 revisions) (#117830) * 53806fa1e Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579) * 9153966bc [fuchsia] Bump the target API level to 11 (flutter/engine#38544) * b9bf51d16 Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter/engine#38580) (#117832) * Roll Flutter Engine from b9bf51d16f25 to f6ad9b6d00e3 (2 revisions) (#117834) * 4b38736e7 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577) * f6ad9b6d0 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581) * 932591ec0 Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter/engine#38584) (#117840) * 3d8c5ef10 Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter/engine#38585) (#117846) * Roll Flutter Engine from 3d8c5ef1060c to a7decc3e459b (2 revisions) (#117856) * 3470fa848 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586) * a7decc3e4 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587) * 0a2029cf3 Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter/engine#38588) (#117858) * 5fe7d5b4e Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter/engine#38591) (#117863) * e5d605b3a Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter/engine#38592) (#117865) * 71c5f1704 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter/engine#38593) (#117868) * 472e34cbb Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter/engine#38594) (#117869) * Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (#117875) * 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter/plugins#6896) * 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter/plugins#6901) * e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter/plugins#6908) * [flutter_tools] timeline_test.dart flaky (#116667) * contains name instead of remove last * fix expect * remove and expect on elements * delete unused code * 7e51aef0a Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (#117874) * Updated to tokens v0.150. (#117350) * Updated to tokens v0.150. * Updated with a reverted list_tile.dart. * Simplify null check. (#117026) * Simplify null check. * Simplify null check. * Simplify null check. * Fix. * Roll Flutter Engine from 7e51aef0a1be to 1d2ba73d1059 (9 revisions) (#117923) * 3e1b0dcb2 Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter/engine#38597) * 8b17efed8 Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter/engine#38598) * 27960a700 [Impeller Scene] Import animation data (flutter/engine#38583) * b5acb2099 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter/engine#38599) * dd0335b34 Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter/engine#38601) * adda2e80c [Impeller Scene] Animation binding and playback (flutter/engine#38595) * 71a296d53 Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter/engine#38607) * bde8d4524 Implement ITextProvider and ITextRangeProvider for UIA (flutter/engine#38538) * 1d2ba73d1 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) * Reland "Remove single-view assumption from ScrollPhysics (#117503)" (#117916) This reverts commit c956121. * Minor documentation fix on BorderRadiusDirectional.zero (#117661) * fix typos (#117592) * c0b3f8fce Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (#117931) * Add convenience constructors for SliverList (#116605) * init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again * 2213b80dd [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (#117935) * Reland "Add support for double tap and drag for text selection #109573" (#117502) * Revert "Revert "Add support for double tap and drag for text selection (#109573)" (#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <[email protected]> * == override parameters are non-nullable (#117839) * Fix the message strings for xcodeMissing and xcodeIncomplete (#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test * 32c468507 Roll quiver to 3.2.1 (flutter/engine#38617) (#117942) * Send text direction in selection rects (#117436) * Correctly propagate verbosity to subtasks in flutter.gradle (#117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports * Roll Plugins from e85f8ac1502d to f9dda6a27b79 (3 revisions) (#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890) * [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment * roll packages (#117940) * roll packages (#118001) * [Android] Increase timeout duration for spell check integration test (#117989) * Add timeout * Add library directive * Add comment, remove testing only changes * Roll Flutter Engine from 32c468507b32 to cdd3bf29e27a (8 revisions) (#118014) * 22f872d5e Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9ed0 Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3bd Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dcdb Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5bf3 Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440ccd5 fix roll (flutter/engine#38635) * 87bdde8fe Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf29e make DisplayListFlags constexpr throughout (flutter/engine#38649) * 60515762e [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter/engine#38628) (#118016) * 35b7dee32 [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter/engine#38497) (#118017) * b9b0193ea Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter/engine#38654) (#118018) * a01548f5f [Impeller Scene] Fix material/vertex color overlapping (flutter/engine#38653) (#118027) * Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891) * 072a9ca37 Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter/engine#38646) (#118039) * bb4015269 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter/engine#38659) (#118042) * Avoid using `TextAffinity` in `TextBoundary` (#117446) * Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests * 74861f369 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) (#118048) * 5bd90d6e7 Consider more roles as text (flutter/engine#38645) (#118049) * [EMPTY] Commit to refresh the tree that is currently red (#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * Adding 'is' to list of kotlin reserved keywords (#116299) Co-authored-by: Gray Mackall <[email protected]> * Added expandIconColor property on ExpansionPanelList Widget (#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (#118072) Co-authored-by: a-wallen <[email protected]> * Fix out-of-sync ExpansionPanel animation (#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by: Morris Kurz <[email protected]> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by: Morris Kurz <[email protected]> * Clarify comment. Signed-off-by: Morris Kurz <[email protected]> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by: Morris Kurz <[email protected]> * Update testcases to new header height (56px -> 48px). Signed-off-by: Morris Kurz <[email protected]> * Test for header height equal to 48px. Signed-off-by: Morris Kurz <[email protected]> * Change issue number to link in comment * Add periods to comments Signed-off-by: Morris Kurz <[email protected]> * Roll Plugins from 320461910156 to 276cfd4b212d (2 revisions) (#118099) * 3a6f63bed Roll Flutter from 231855f to 43b9120 (11 revisions) (flutter/plugins#6918) * 276cfd4b2 [shared_preferences] Convert macOS to Pigeon (flutter/plugins#6914) * 33d7f8a1b Remove single view assumptions from `window.dart` (flutter/engine#38453) (#118069) * InteractiveViewer parameter to return to pre-3.3 trackpad/Magic Mouse behaviour (#114280) * trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines * 0a0e3d205 Roll Flutter from 43b9120 to 5070620 (9 revisions) (flutter/plugins#6919) (#118183) * Roll Flutter Engine from 33d7f8a1b307 to 03609b420beb (6 revisions) (#118125) * c58254702 SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) * 3d9214ace Bump actions/checkout from 3.1.0 to 3.2.0 (flutter/engine#38390) * a4775c7a7 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) * 046012e8e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter/engine#38683) * cda410c28 Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter/engine#38668) * 03609b420 [web] Fix canvas2d leaks in text measurement (flutter/engine#38640) * remove the unused check in selectable_text (#117716) * Roll Flutter Engine from 03609b420beb to b5513d7a442a (2 revisions) (#118186) * fd5a96e10 Limit selection change to focused node on Windows (flutter/engine#38634) * b5513d7a4 Roll Dart SDK from 0b064bc49557 to cb29cb6d1d0f (12 revisions) (flutter/engine#38688) * Roll Flutter Engine from b5513d7a442a to 5bdb04f33f99 (2 revisions) (#118187) * e20809014 Roll Skia from 54dbda290908 to b8c0a78a2378 (43 revisions) (flutter/engine#38690) * 5bdb04f33 Roll Fuchsia Mac SDK from Bewt-eq7gNu6sU_Ob... to ORxExaprF9fW5d4MP... (flutter/engine#38697) * 51baed6e0 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (#118189) * Update to Xcode 14.2 (#117507) * Update to Xcode 14.2 * Only bump for devicelab builders * Restore presubmit: false * Allow iOS and macOS plugins to share darwin directory (#115337) * Roll Flutter Engine from 51baed6e01b8 to 5df0072a0e63 (3 revisions) (#118192) * 181286315 Roll Dart SDK from cb29cb6d1d0f to 853eff8b0faa (2 revisions) (flutter/engine#38694) * 642f72f73 Bump actions/upload-artifact from 3.1.0 to 3.1.2 (flutter/engine#38713) * 5df0072a0 Bump actions/checkout from 3.2.0 to 3.3.0 (flutter/engine#38714) * Use program during attach if provided (#118130) * eb5c6f0b4 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (#118197) * Update `ListTile` to support Material 3 (#117965) * Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add #99933 HTML workaround. * 3a7d8862f Re-enable UIA text/range provider unit tests (flutter/engine#38718) (#118201) * Fix path for require.js (#118120) - Matches new location in the Dart SDK. https://dart-review.googlesource.com/c/sdk/+/275482 - Includes fall back logic so the existing and new locations will work depending on the file that is available. * ee0c4d26b Roll flutter/packages to 25454e (flutter/engine#38685) (#118205) * Roll Flutter Engine from ee0c4d26b0fa to 264aa032cf75 (2 revisions) (#118208) * 5a39a8846 Add CI builder for windows-arm64. (flutter/engine#38394) * 264aa032c Revert "Add CI builder for windows-arm64. (#38394)" (flutter/engine#38729) * 9c0b187a1 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (#118210) * add closed/open focus traversal; use open on web (#115961) * allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments * Roll Flutter Engine from 9c0b187a1139 to 716bb9172c0d (3 revisions) (#118220) * b6720a5b7 Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) * 4f0cdcd0b Inline usage of SkIsPow2 (flutter/engine#38722) * 716bb9172 [Impeller Scene] Add DisplayList OP and Dart bindings (flutter/engine#38676) * Hide InkWell hover highlight when an hovered InkWell is disabled (#118026) * Allow select cases to be numbers (#116625) * [Impeller Scene] Add SceneC asset importing (#118157) * Add a comment about repeat event + fix typos (#118095) * Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (#116894) * Roll Flutter Engine from 716bb9172c0d to 687e3cb0fbe2 (2 revisions) (#118242) * 24ee5c10f Roll Fuchsia Mac SDK from ORxExaprF9fW5d4MP... to zC90VpkAGMG1jJ-BK... (flutter/engine#38734) * 687e3cb0f Roll Dart SDK from 418bee5da2e2 to 8d7a6aabd3a3 (2 revisions) (flutter/engine#38738) * Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (#118253) * d03de2fce [tool] Don't add Guava in the all-packages app (flutter/plugins#6747) * d485c7e83 [local_auth]: Bump espresso-core (flutter/plugins#6925) * a47e71988 [webview_flutter_platform_interface] Improves error message when `WebViewPlatform.instance` is null (flutter/plugins#6938) * 7132dac0e [google_maps]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/plugins#6937) * dc3287ccf [espresso]: Bump truth from 1.4.0 to 1.5.0 in /packages/espresso/android (flutter/plugins#6707) * 1de6477bd [camera]: Bump camerax_version from 1.3.0-alpha01 to 1.3.0-alpha02 in /packages/camera/camera_android_camerax/android (flutter/plugins#6828) * fb405819e [shared_preferences] Merge iOS and macOS implementations (flutter/plugins#6920) * 9fdc899b7 [various] Enable `avoid_dynamic_calls` (flutter/plugins#6834) * Manually mark Windows run_debug_test_windows as unflaky (#118112) * Marks Mac_arm64_android run_debug_test_android to be unflaky (#117469) * Marks Mac_arm64_ios run_debug_test_macos to be unflaky (#117990) * remove unsound mode web test (#118256) * Update `CupertinoPicker` example (#118248) * Update `CupertinoPicker` example * format lines * Revert making variable public * revert variable change * roll packages (#118117) * Add option for opting out of enter route snapshotting. (#118086) * Add option for opting out of enter route snapshotting. * Fix typo. * Merge find layers logic. * Add justification comment on why web is skipped in test. * Update documentation as suggested. * Update documentation as suggested. * roll packages (#118272) * Roll Flutter Engine from 687e3cb0fbe2 to c1d61cf11da8 (6 revisions) (#118274) * ad9052a38 Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter/engine#38740) * c4c97023f Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter/engine#38721) * f40af3eb4 Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter/engine#38744) * 41cfbdd7e Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter/engine#38746) * 95c7b1f8a Make operator == parameter non-nullable (flutter/engine#38663) * c1d61cf11 Move canvaskit artifacts to expected location in Web SDK Archive (flutter/engine#38168) * Align `flutter pub get/upgrade/add/remove/downgrade` (#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * ae9e181e3 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (#118287) * Fix Finnish TimeOfDate format (#118204) * init * add test * Roll Flutter Engine from ae9e181e30c2 to 53bd4bbf9646 (3 revisions) (#118289) * b9a723482 [web] retain GL/Gr context on window resize (flutter/engine#38576) * fd4360671 Add SpringAnimation.js from React Native (flutter/engine#38750) * 53bd4bbf9 Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter/engine#38758) * 9ade91c8b removed forbidden skia include (flutter/engine#38761) (#118296) * 8d7beac82 Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (#118297) * 6256f05db Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (#118300) * FIX: UnderlineInputBorder hashCode and equality by including borderRadius (#118284) * Bump actions/upload-artifact from 3.1.1 to 3.1.2 (#118116) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@83fd05a...0b7f8ab) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93ea575...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.1.35 to 2.1.37 (#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6048f9110 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (#118320) * Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (#118317) * 6a24f2d7b == override parameters are non-nullable (flutter/plugins#6900) * b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter/plugins#6933) * b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter/plugins#6902) * 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter/plugins#6915) * ee76ab71e Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (#118335) * Roll Flutter Engine from ee76ab71e0a6 to cccaae2f3d8b (3 revisions) (#118349) * 5ec03d7d1 Roll Fuchsia Mac SDK from a9NpYJbjhDRX9P9u4... to ao8fSjW8HrZSsu3yq... (flutter/engine#38782) * 87ead948e delete include of private GrMtlTypes header (flutter/engine#38783) * cccaae2f3 [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) * 764a9e012 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (#118355) * Roll Flutter Engine from 764a9e01204d to 4a8d6866a1c0 (2 revisions) (#118357) * 7abc5f13a [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter/engine#38786) * 4a8d6866a Add CI builder for windows-arm64. (#38394) (flutter/engine#38739) * Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (#111570) * Marks Mac channels_integration_test to be unflaky (#111571) * Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (#116668) * Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (#118322) * docs: update docs about color property in material card (#117263) * update docs * * * typo * Revert "typo" This reverts commit 3e25d4be337b1a41d24b1a86136606d6551b30cf. * Update card.dart * Update card.dart * Update card.dart * Fix M3 `Drawer` default shape in RTL (#118185) * [M3] Add error state support for side property of CheckBox (#118386) * Add error state support for side property * lint fixes * lint fixes * Roll Plugins from 620a059d62b2 to 39197f17ca59 (6 revisions) (#118391) * 8c461cfde [gh_actions]: Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (flutter/plugins#6882) * a119afd47 [in_app_pur]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6924) * 12266846e Roll Flutter from 5070620 to 7ddf42e (5 revisions) (flutter/plugins#6923) * 44098fe34 [shared_preferences] Switch to `shared_preferences_foundation` (flutter/plugins#6940) * 0dd166959 [tool] Replace `flutter format` (flutter/plugins#6946) * 39197f17c [gh_actions]: Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/plugins#6935) * Move debug error message from failed pub to logger.printTrace (#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <[email protected]> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <[email protected]> * IconButtonTheme should be overridden by the AppBar/AppBarTheme's iconTheme and actionsIconTheme (#118216) * reduce pub output from flutter create (#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (#118277) * [web] Update build to use generated JS runtime for Dart2Wasm. (#118359) * Roll Flutter Engine from 4a8d6866a1c0 to c01465a18f31 (9 revisions) (#118409) * 2d2c5e7eb Roll Dart SDK from 22fa50e09ee8 to 21f5de0ad596 (2 revisions) (flutter/engine#38796) * 24eb954da fix canvas drawLine bugs (flutter/engine#38753) * 2b024cbb6 [Impeller Scene] Change how property resolution works to fix Animation blending; add mutation log to nodes; enable backface culling; add vertex color contribution back to meshes (flutter/engine#38766) * 0192ea15e Roll Dart SDK from 21f5de0ad596 to 7879aa93da71 (1 revision) (flutter/engine#38804) * 5cd50f568 Roll Fuchsia Mac SDK from ao8fSjW8HrZSsu3yq... to gZ6xbsp2MRsoXfKgY... (flutter/engine#38806) * 4bf70c011 Roll Dart SDK from 7879aa93da71 to d7235947ff9b (1 revision) (flutter/engine#38808) * bb2d5e93a Roll Dart SDK from d7235947ff9b to edd406c07399 (2 revisions) (flutter/engine#38814) * 2a9fa7975 Revert "fix canvas drawLine bugs (#38753)" (flutter/engine#38815) * c01465a18 Add wasm_release build to linux_host_engine.json (flutter/engine#38755) * Add MSYS2 detection on Windows Terminal (#117612) As the results of "uname -s" command is like the below on MSYS2 on Windows Terminal, MSYS_NT-10.0-22621 This patch fixes the Flutter command working on this kind of systems. Signed-off-by: Deokgyu Yang <[email protected]> Signed-off-by: Deokgyu Yang <[email protected]> * Add documentation for drag/fling offset in WidgetController. (#118288) * Documentation for drag/fling offset * Fix typo * Fix typo 2 * Fix the docs_test * Fix the grammar * 688015782 fixed glfw example for arm64 (flutter/engine#38426) (#118413) * Use correct API docs link in create --sample help message (#118371) * Use correct API doc link in create --sample help message * Verify Flutter and Dart website links in tool help messages use https * Adjust test failure reasoning message * Roll Flutter Engine from 688015782762 to 35cfe9158648 (2 revisions) (#118415) * e9b7a2d38 [macOS] Do not block raster thread when shutting down (flutter/engine#38777) * 35cfe9158 Roll Fuchsia Mac SDK from gZ6xbsp2MRsoXfKgY... to nIPtQ59jG1pxyatOq... (flutter/engine#38819) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <[email protected]> * 8aa26baa9 Roll Dart SDK from edd406c07399 to 20cca507d98b (1 revision) (flutter/engine#38823) (#118420) * add generated_plugins.cmake (#116581) Added files to the .gitignore that are generated on each "flutter pub get", so it's useless to ever commit these to a git repository. * Enable xcode cache cleanup for a few days. (#118419) This is to ensure the xcode caches get back to a normal state as they seem to have gotten into a bad state after updating the xcode version. Bug: #118324 Bug: #118327 Bug: #118328 * 99509a7e4 Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) (#118425) * Roll Flutter Engine from 99509a7e4275 to f3f05368033b (2 revisions) (#118429) * 091c785a4 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) * f3f053680 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (#118432) * a62d25326 Roll Skia from dfb838747295 to cc983d28f3bf (27 revisions) (flutter/engine#38830) (#118435) * dfa0327f8 Roll Skia from cc983d28f3bf to fd54be29a3cc (3 revisions) (flutter/engine#38833) (#118436) * 07603c6d4 Roll Dart SDK from 20cca507d98b to 3d629d00a8d7 (2 revisions) (flutter/engine#38834) (#118439) * Fix copying/applying font fallback with package (#118393) * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * dec608917 Roll Fuchsia Mac SDK from nIPtQ59jG1pxyatOq... to 21nYb648VWbpxc36t... (flutter/engine#38839) (#118445) * 970889b87 Roll Skia from fd54be29a3cc to c72c7bf7e45b (3 revisions) (flutter/engine#38840) (#118448) * a512cebdc Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (#118454) * Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (#118457) * b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter/plugins#6948) * 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter/plugins#6635) * be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter/plugins#6952) * 92a5367d5 [tool] Fix false positives in update-exceprts (flutter/plugins#6950) * Added LinearBorder, an OutlinedBorder like BoxBorder (#116940) * Marks Mac_ios spell_check_test to be unflaky (#117743) * [Linux] Add a 'flutter run' console output test (#118279) * Add Linux support for the UI integration test project * Add Linux run console test * Add Info.plist from build directory as input path to Thin Binary build phase (#118209) * Add Info.plist from build directory as input path to Thin Binary build phase * fix directive ordering * migrate benchmark, integration, and example tests * [flutter_tools] re-enable web shader compilation (#118461) * [flutter_tools] re-enable web shader compilation * update test cases * Bump github/codeql-action from 2.1.37 to 2.1.38 (#118482) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.37 to 2.1.38. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@959cbb7...515828d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove whitespace * add newline * newline fixes * newline fix * test fix * Update documentation about accent color (#116778) * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * Reland "Add support for double tap and drag for text selection #109573" (#117502) * Revert "Revert "Add support for double tap and drag for text selection (#109573)" (#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <[email protected]> * roll packages (#117940) * roll packages (#118001) * [EMPTY] Commit to refresh the tree that is currently red (#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * [Impeller Scene] Add SceneC asset importing (#118157) * roll packages (#118117) * roll packages (#118272) * Align `flutter pub get/upgrade/add/remove/downgrade` (#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * Bump github/codeql-action from 2.1.35 to 2.1.37 (#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move debug error message from failed pub to logger.printTrace (#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <[email protected]> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <[email protected]> * reduce pub output from flutter create (#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (#118277) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <[email protected]> * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (#118432) * [flutter_tools] re-enable web shader compilation (#118461) * [flutter_tools] re-enable web shader compilation * update test cases * remove whitespace * fix rebase mess * fix time picker tests * whitespace fix * actual whitespace fix --------- Signed-off-by: Morris Kurz <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Deokgyu Yang <[email protected]> Co-authored-by: Pierre-Louis <[email protected]> Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Jesús S Guerrero <[email protected]> Co-authored-by: Darren Austin <[email protected]> Co-authored-by: Ahmed Ashour <[email protected]> Co-authored-by: Michael Goderbauer <[email protected]> Co-authored-by: Greg Price <[email protected]> Co-authored-by: CicadaCinema <[email protected]> Co-authored-by: Tae Hyung Kim <[email protected]> Co-authored-by: Renzo Olivares <[email protected]> Co-authored-by: Renzo Olivares <[email protected]> Co-authored-by: Sam Rawlins <[email protected]> Co-authored-by: Peixin Li <[email protected]> Co-authored-by: Callum Moffat <[email protected]> Co-authored-by: Vyacheslav Egorov <[email protected]> Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: Flutter GitHub Bot <[email protected]> Co-authored-by: Camille Simon <[email protected]> Co-authored-by: LongCatIsLooong <[email protected]> Co-authored-by: Drew Roen <[email protected]> Co-authored-by: Jason Simmons <[email protected]> Co-authored-by: Nehal Patel <[email protected]> Co-authored-by: gmackall <[email protected]> Co-authored-by: Gray Mackall <[email protected]> Co-authored-by: Mohammed CHAHBOUN <[email protected]> Co-authored-by: Alex Wallen <[email protected]> Co-authored-by: a-wallen <[email protected]> Co-authored-by: Morris Kurz <[email protected]> Co-authored-by: Lucas.Xu <[email protected]> Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Helin Shiah <[email protected]> Co-authored-by: Taha Tesser <[email protected]> Co-authored-by: Nicholas Shahan <[email protected]> Co-authored-by: Yegor <[email protected]> Co-authored-by: Bruno Leroux <[email protected]> Co-authored-by: Brandon DeRosier <[email protected]> Co-authored-by: Loïc Sharma <[email protected]> Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: Youchen Du <[email protected]> Co-authored-by: Sigurd Meldgaard <[email protected]> Co-authored-by: Rydmike <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suhwan Cha <[email protected]> Co-authored-by: Andrew Kolos <[email protected]> Co-authored-by: Qun Cheng <[email protected]> Co-authored-by: joshualitt <[email protected]> Co-authored-by: Deokgyu Yang <[email protected]> Co-authored-by: Peixin Li <[email protected]> Co-authored-by: Parker Lougheed <[email protected]> Co-authored-by: Ivo Beckers <[email protected]> Co-authored-by: godofredoc <[email protected]> Co-authored-by: Bernardo Ferrari <[email protected]> Co-authored-by: Dennis Kugelmann <[email protected]> Co-authored-by: Hans Muller <[email protected]> Co-authored-by: Victoria Ashworth <[email protected]>
3 tasks
3 tasks
rjansen
added a commit
to indaband/flutter_plugins
that referenced
this pull request
Mar 24, 2023
* [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (#6597) * [quick_actions]migrate shortcut state manager, deprecate OCMock and use POP * remove objc proj settings * rename shortcut state manager * bump version * run swift-format * nit * remove public_header_files * use shortcut item parser instead of shortcut state manager * some nit * rename AppShortcutControlling to ShortcutItemProviding * nit * do not crash if no type or title * update license * [quick_actions] Fix Android integration test flake (#6688) * Make fix * Formatting * [google_sign_in] Correctly passes `serverClientId` to native libs (#6691) * Correctly passes serverClientId to native libs * Bumps versions * Revert "[ci]Temporarily disable starqlteue on firebase device lab (#6657)" (#6710) This reverts commit f8122dc89ad3e76e8018d113c40b3cb3ccdb3e51. * [ci] Manually Roll Flutter from 61e927d22fe6 to d2e6dfefa5ca (143 revisions) (#6723) * Slow down link_widget_test scroll extent so test passes (framework/engine regression?) * Manually Roll Flutter from 61e927d22fe6 to d2e6dfefa5ca (143 revisions) * Roll Flutter from d2e6dfefa5ca to 46d868c52517 (5 revisions) (#6724) * 22e1ac762 b32c3a307 Roll Skia from ab054a88d7c7 to 345bceacd298 (3 revisions) (flutter/engine#37745) (flutter/flutter#115658) * 01c1e8e58 Allows pushing page based route as pageless route (flutter/flutter#114362) * 0e57147db nav drawer (flutter/flutter#115668) * cf2c9f6ed Remove package:image dependency (flutter/flutter#115674) * 46d868c52 Roll Flutter Engine from b32c3a307bb5 to 7a390f97c798 (14 revisions) (flutter/flutter#115672) * [camera] Export VideoCaptureOptions so that implementers can use it (#6666) * Export VideoCaptureOptions so that it is accessible to other packages Also added tests so that missing exports can be more easily tested in the future. * Fix dart analyze warnings * Roll Flutter from 46d868c52517 to 633d7ef046c8 (8 revisions) (#6725) * 0fc4a3efa Revert "Remove package:image dependency (#115674)" (flutter/flutter#115680) * c69fbf150 a77dfaff3 Remove `Linux Web Engine` from recipes CQ (flutter/engine#37758) (flutter/flutter#115675) * c95b69354 f81ac3b19 Fix glyph sampling overlap (flutter/engine#37764) (flutter/flutter#115683) * be0c3a799 cef11cb9a Roll Skia from 12f01bc5b57e to c53d8cf5b823 (4 revisions) (flutter/engine#37767) (flutter/flutter#115684) * ae18d7b07 6da59402e Roll Skia from c53d8cf5b823 to 0c1fcbe97b1f (1 revision) (flutter/engine#37771) (flutter/flutter#115685) * a17b4c369 91bc694eb Roll Fuchsia Mac SDK from tklUfTsSOVKk49tYq... to UcfQiA4PBOCs_7GEK... (flutter/engine#37773) (flutter/flutter#115686) * 1bee3574b 2d5e0667e Roll Fuchsia Linux SDK from WdtwlLEce90PjFJ9z... to qc20R_3e8PoqMQWgw... (flutter/engine#37775) (flutter/flutter#115687) * 633d7ef04 916fd798d Roll Skia from 0c1fcbe97b1f to ad354e712b96 (2 revisions) (flutter/engine#37776) (flutter/flutter#115689) * [ci] Improve analysis_options alignment with flutter/packages (#6728) * Add more options that are in flutter/packages * Fix unnecessary awaits * More option alignment * Add and locally supress avoid_implementing_value_types * Fix release-info for test-only changes * Fix update-release-info handling of 'minimal' * Update release metadata * Roll Flutter from 633d7ef046c8 to 29622285dd9e (13 revisions) (#6730) * 271a1bf86 Roll Flutter Engine from 916fd798deb3 to 9a7336dce837 (2 revisions) (flutter/flutter#115701) * d8a091ce9 e9bdd5ef5 Roll Fuchsia Linux SDK from qc20R_3e8PoqMQWgw... to Cg4pM7Agigl6gZqq5... (flutter/engine#37782) (flutter/flutter#115703) * b556cc591 79bc94539 Roll Fuchsia Mac SDK from C8_lxtWKA4MIKeAu2... to KqMuhIlNeJZpycJLZ... (flutter/engine#37784) (flutter/flutter#115713) * 05683182d bb283b4ba Roll Fuchsia Linux SDK from Cg4pM7Agigl6gZqq5... to 2T1QqkhI-ef8AXGgn... (flutter/engine#37785) (flutter/flutter#115716) * afb479b46 c653da351 Roll Skia from 80b3e3d24a99 to dd5f384ae62a (1 revision) (flutter/engine#37786) (flutter/flutter#115717) * 20fa32e12 774bce877 Roll Skia from dd5f384ae62a to 1d7f785e3679 (1 revision) (flutter/engine#37787) (flutter/flutter#115718) * ee9bc784b Roll Flutter Engine from 774bce877488 to 271461837e78 (4 revisions) (flutter/flutter#115735) * f365c0632 4affb2af4 Roll Skia from db7a810dba5d to 645605735772 (1 revision) (flutter/engine#37796) (flutter/flutter#115742) * d9fb0dd8c 18a5b3596 Roll Skia from 645605735772 to ae61b83805e3 (3 revisions) (flutter/engine#37797) (flutter/flutter#115746) * 809ee4418 Roll Flutter Engine from 18a5b3596094 to 46a6b5429516 (2 revisions) (flutter/flutter#115758) * a9858ec52 Roll Plugins from b2fe01bc0f29 to 475caa00130d (5 revisions) (flutter/flutter#115761) * e2f84b596 Roll Flutter Engine from 46a6b5429516 to 5c3b8956d50b (2 revisions) (flutter/flutter#115769) * 29622285d 55b089131 Roll Fuchsia Linux SDK from EyQx0yUqK5TJxeHF7... to xBfEjlXUsix6Wka-i... (flutter/engine#37804) (flutter/flutter#115772) * [sign_in]: Bump play-services-auth from 20.3.0 to 20.4.0 in /packages/google_sign_in/google_sign_in_android/android (#6726) * [sign_in]: Bump play-services-auth Bumps play-services-auth from 20.3.0 to 20.4.0. --- updated-dependencies: - dependency-name: com.google.android.gms:play-services-auth dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump version Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: camsim99 <[email protected]> * [ci] Import flutter/packages install_chromium.sh (#6727) * [ci] Import flutter/packages install_chromium.sh Brings over the newer flutter/packages version of install_chromium.sh as part of pre-aligning the repositories for later merging. Part of https://github.com/flutter/flutter/issues/113764 * Update .cirrus.yml Co-authored-by: David Iglesias <[email protected]> Co-authored-by: David Iglesias <[email protected]> * Switch `ios_platform_tests` from Cirrus to LUCI (#6729) * move to prod * remove cirrus * Roll Flutter from 29622285dd9e to 06d90b8b9e26 (17 revisions) (#6742) * 504f697d6 4a4df4bd6 [Impeller] Format shader sources. (flutter/engine#37770) (flutter/flutter#115773) * 7045a8b57 Add Spell Check to Editable Text (iOS) (flutter/flutter#110193) * 567d0045b Add clip option for navigator (flutter/flutter#115775) * 073cefad0 [RawKeyboard] Fix Linux remapped CapsLock throws (flutter/flutter#115009) * bd0115f04 [cirrus] Disable outside of tip of tree (flutter/flutter#115774) * ce2fa9a56 Roll Flutter Engine from 4a4df4bd685d to cc0ad66907b6 (4 revisions) (flutter/flutter#115777) * 0b9d18f8f [flutter_tools] Add flutter update-packages --synthetic-package-path (flutter/flutter#115665) * 13012082a 9ea061bd7 [macOS] Add explicit weak/strong/copy annotations (flutter/engine#37768) (flutter/flutter#115783) * 2b0c895fa Updated the kotlinlang version url. (flutter/flutter#115782) * 3bd53b084 2a8ac1e0c [Linux] Synthesize modifier keys events on pointer events (flutter/engine#37491) (flutter/flutter#115788) * 9827d0fc8 44f22ac39 Roll Dart SDK from 68291f382fb6 to 756f835dd84d (1 revision) (flutter/engine#37815) (flutter/flutter#115792) * eed385132 Support Host only bots apple signing (flutter/flutter#115780) * 0d7a3b7f4 Roll Flutter Engine from 44f22ac39f54 to 981fe92ab998 (2 revisions) (flutter/flutter#115798) * 3fe779425 BouncingScrollPhysics should propagate decelerationRate. (flutter/flutter#115797) * 182d6c4c9 ddf6a20b8 Roll Skia from 500aae3f2761 to 57b4252cf211 (7 revisions) (flutter/engine#37819) (flutter/flutter#115802) * 2921ca0c4 8dd8e092e Roll Dart SDK from 756f835dd84d to 6b8e98070f26 (1 revision) (flutter/engine#37825) (flutter/flutter#115810) * 06d90b8b9 c3645c3b8 [impeller] Remove declare_undefined_values (flutter/engine#37829) (flutter/flutter#115812) * [path_provider] Remove unused Guava dependency (#6744) * Remove unused Guava dependency * Metadata * Update Nullable import * [google_sign_in] Roll Guava dependency to 31.1 (#6746) * Roll guava * Metadata * [ios_platform_images] remove deprecated APIs (#6693) * [ios_platform_images] remove deprecated APIs * ++ * ++ * ++ * Update pubspec.yaml * Update CHANGELOG.md * Roll Flutter from 06d90b8b9e26 to 0eb2d51ec991 (17 revisions) (#6750) * f4ee61a39 Roll Plugins from 475caa00130d to 5d847ef391a5 (3 revisions) (flutter/flutter#115837) * 91aeda7bf Use the new pushImageFilter offset parameter to fix the transform of the children (flutter/flutter#113673) * 9bb07b5f7 Revert "Use the new pushImageFilter offset parameter to fix the transform of the children (#113673)" (flutter/flutter#115861) * 14754a261 roll packages (flutter/flutter#115764) * dfdec8984 [flutter_tools] Remove package:image (flutter/flutter#115848) * da963a902 Roll Flutter Engine from c3645c3b8947 to 37e2aaa901e8 (9 revisions) (flutter/flutter#115842) * b9caef58e Remove dev/md random file (flutter/flutter#115855) * 94b9fa411 Provide an option to update `Focus's semantics under `FocusableActionDetector` (flutter/flutter#115833) * 6a26305d1 Update documentation for `PlatformException.stacktrace` (flutter/flutter#114028) * 73024eb70 [flutter_tool] Adds --enable-dart-profiling flag (flutter/flutter#115863) * 259373d62 [flutter_tools] Add --dump-info, --no-frequency-based-minification flags (flutter/flutter#115862) * d95eab877 Roll Flutter Engine from 37e2aaa901e8 to a805efffba54 (12 revisions) (flutter/flutter#115881) * 7bb1d1b35 Roll Flutter Engine from a805efffba54 to 4bf16c369bfc (2 revisions) (flutter/flutter#115888) * b7023e843 Roll Flutter Engine from 4bf16c369bfc to f75287af0b19 (2 revisions) (flutter/flutter#115891) * a780a007e a43142d77 Roll Dart SDK from 27c45cd51796 to d2766b385c2a (5 revisions) (flutter/engine#37859) (flutter/flutter#115895) * 4edb76817 Roll Flutter Engine from a43142d77a58 to e6d9fffe8609 (2 revisions) (flutter/flutter#115897) * 0eb2d51ec Use the new pushImageFilter offset parameter to fix the transform of the children (#113673) (flutter/flutter#115884) * b8f7f1f98 [flutter_releases] Flutter stable 3.3.9 Framework Cherrypicks (flutter/flutter#115856) (#6751) * Roll Flutter from 0eb2d51ec991 to cb234730a11d (13 revisions) (#6755) * 16fb711f7 Roll Plugins from 5d847ef391a5 to a431b35bfa0b (7 revisions) (flutter/flutter#115930) * a27e3f2e8 94cdce89c Roll Dart SDK from d2766b385c2a to c32f12ffbef2 (2 revisions) (flutter/engine#37869) (flutter/flutter#115938) * 65168d17e 7959ffd2e Fix DomProgressEvent constructor (flutter/engine#37849) (flutter/flutter#115941) * e96fc9973 Roll Flutter Engine from 7959ffd2ee6d to e74cecbf830e (2 revisions) (flutter/flutter#115949) * f5c14807f Roll Flutter Engine from e74cecbf830e to 8a40e8324b48 (3 revisions) (flutter/flutter#115952) * a9f9293d9 3925231ea Call focus on input after detecting a tap (flutter/engine#37863) (flutter/flutter#115953) * 108f88c7c 96bbe3c5f Roll Skia from c098e3c5d932 to e3c0b382b072 (12 revisions) (flutter/engine#37875) (flutter/flutter#115954) * b52f0b6f9 d4fe02ab0 Roll Skia from e3c0b382b072 to 805fd7443f42 (3 revisions) (flutter/engine#37879) (flutter/flutter#115956) * d0352f55d Roll Flutter Engine from d4fe02ab0366 to 9b2895724c4d (2 revisions) (flutter/flutter#115957) * 09e2c67e4 Roll Flutter Engine from 9b2895724c4d to 497a485751a9 (2 revisions) (flutter/flutter#115966) * a7f8b31be 06e5e6ac5 Roll Skia from 665ae344c8ec to f45e40d01dac (4 revisions) (flutter/engine#37888) (flutter/flutter#115969) * 013179f55 05b8d011f Roll Fuchsia Mac SDK from i-NY382Y0Y8m9OqNp... to dxhpLq8MRsVs0e7OD... (flutter/engine#37891) (flutter/flutter#115972) * cb234730a c46300a66 Roll Dart SDK from 71241dd55373 to bb6aa5a412d7 (2 revisions) (flutter/engine#37893) (flutter/flutter#115975) * Roll Flutter from cb234730a11d to ff59250dbeb0 (3 revisions) (#6757) * 0b3b31e5b 0930a7633 Roll Skia from f45e40d01dac to a01af64f5cec (1 revision) (flutter/engine#37896) (flutter/flutter#115982) * a41376ede ad21c5adf Roll Dart SDK from bb6aa5a412d7 to eddf73d66119 (1 revision) (flutter/engine#37897) (flutter/flutter#115986) * ff59250db 7665ae518 Roll Fuchsia Mac SDK from dxhpLq8MRsVs0e7OD... to NvafPMjJLQ0fBSSAc... (flutter/engine#37898) (flutter/flutter#115991) * Roll Flutter from ff59250dbeb0 to 17c1dbc47378 (31 revisions) (#6764) * 96d7f9cb1 Updated tokens to v0_143. (flutter/flutter#115890) * 2703a2bcd Fix current day not being decorated when it was disabled for picking. (flutter/flutter#115240) * d841d3214 TabBar should adjust scroll position when Controller is changed (flutter/flutter#116019) * 7faacb5f7 Marks Windows_android channels_integration_test_win to be unflaky (flutter/flutter#115939) * 511c5341b Add test target for release scheduler (flutter/flutter#115781) * 224fae506 Fix iOS selectWordEdge doesn't account for affinity (flutter/flutter#115849) * 4a5dd9c9f Roll Flutter Engine from 7665ae51846f to 867214c062ee (20 revisions) (flutter/flutter#116121) * 215f6372c Refactor Message class to hold all translations (flutter/flutter#115506) * beaabb70c Add `IndicatorShape` to `NavigationRailTheme` and fix indicator ripple. (flutter/flutter#116108) * 3cafeb3e9 e612c3d75 Roll Skia from 3ab92e777da1 to 6f65f0631e5a (3 revisions) (flutter/engine#37941) (flutter/flutter#116133) * b22ab5117 Reland Cupertino text input padding (flutter/flutter#115164) * ccc277c38 Fix LayoutExplorer cycle (flutter/flutter#115526) * 202891cbe Roll Flutter Engine from e612c3d75676 to f326b630dd3a (2 revisions) (flutter/flutter#116140) * 9fba4296e Tiny code cleanup: remove unnecessary comparisons (flutter/flutter#114488) * db631f149 bd1400ef6 Roll ICU from da0744861976 to 1b7d391f0528 (4 revisions) (flutter/engine#37945) (flutter/flutter#116143) * 0cb9f7046 Menu bar accelerators (flutter/flutter#114852) * 9e2a27112 8417e2f52 [fuchsia] arm64 Dart runner (flutter/engine#37399) (flutter/flutter#116147) * 4c3b642f2 372ec3259 Roll Skia from 4a4cfedd1c20 to ddddafb88280 (2 revisions) (flutter/engine#37947) (flutter/flutter#116151) * f777c9f65 [flutter_tools] use absolute path for shader lib (flutter/flutter#116123) * dfa3d3332 [devicelab] track performance of animated image filter (flutter/flutter#115850) * 8535e716d ab8f921c4 Roll Fuchsia Mac SDK from CUPWWG1rEmonxuLpv... to 7NnCHy_b8ZWxdAtEU... (flutter/engine#37949) (flutter/flutter#116152) * d6995aa24 Ignore NullThrownError deprecation (flutter/flutter#116135) * 39a73cabe Add Escaping Option for ICU MessageFormat Syntax (flutter/flutter#116137) * a2fd68809 cc2f55d74 [Impeller] Cleanup shader generation and specify min macOS version. (flutter/engine#37952) (flutter/flutter#116158) * 61376de9b Generate local metadata even when not publishing. (flutter/flutter#116087) * 1c6526240 9fbd5bf4a [impellerc] speculative fix for include errors with impellerc shader lib (flutter/engine#37939) (flutter/flutter#116161) * 853b3080e ee8023432 Roll Dart SDK from eddf73d66119 to 962cd6e0d20a (1 revision) (flutter/engine#37954) (flutter/flutter#116166) * f8745c596 bc51ab52d Roll Skia from ddddafb88280 to 38cdadb76f51 (3 revisions) (flutter/engine#37956) (flutter/flutter#116171) * e66968367 46e9afaf1 Roll Skia from 38cdadb76f51 to d16a6bdb9542 (3 revisions) (flutter/engine#37957) (flutter/flutter#116172) * 24db45e79 Disable backspace/delete handling on iOS & macOS (flutter/flutter#115900) * 17c1dbc47 7c4b01fe9 Roll Skia from d16a6bdb9542 to 514203395396 (1 revision) (flutter/engine#37958) (flutter/flutter#116178) * [in_app_purchase_storekit] Add support for macOS (#6517) * Initial commit of adding MacOS support. Heavily inspired by https://github.com/flutter/plugins/pull/5854/ * Updated version and changelog. * Updated documentation. * Added missing license comments. * Fixed podspec lint issue. * Moved native tests to a shared location. * Decreased minimum macOS version from 10.15 to 10.11. This seems wrong to me, since StoreKit is only properly supported on MacOS 10.15+. However, now all existing tests should pass. * Added RunnerTests target to macos example. * Unified macOS capitalization. * Deleted generated macOS icon assets. * Removed empty function overrides. * Enabled tests for macOS. * Added OCMock to RunnerTests target. * Adapted tests for macOS. * Reverted relative path dependencies. * Updated to a proper version bump. * Make macOS no-op tests run only on iOS. * Replace directory symlinks with file symlinks. * Marked iOS-only API as iOS-only. Previously they were no-ops on macOS. * Re-worded doc-comment. * Formatted code. * Roll Flutter from 17c1dbc47378 to b2672fe8355f (26 revisions) (#6766) * d58855c49 Update SnackBar to support Material 3 (flutter/flutter#115750) * 8b32ac7a5 Revert "Update SnackBar to support Material 3" (flutter/flutter#116199) * 3219da9b5 Use Isolate.run as implementation for compute (flutter/flutter#115779) * 33f3c5350 Roll Flutter Engine from 7c4b01fe9a1f to e9dc20ed05c9 (2 revisions) (flutter/flutter#116197) * c37c0cc2e fbf31015f [gn] embed mac codesign metadata in android artifacts (flutter/engine#37951) (flutter/flutter#116209) * e5e5e6854 05e2de7e3 Build platform dills with unevaluated constants (flutter/engine#37940) (flutter/flutter#116215) * 7966d5584 Roll Flutter Engine from 05e2de7e3e67 to d85707af0987 (2 revisions) (flutter/flutter#116217) * 1cb16a1e3 iOS 16 context menu (flutter/flutter#115805) * 8b86d238b Create `DropdownMenu` Widget to Support Material 3 (flutter/flutter#116088) * 900b39545 Add Material 3 support for `TabBar` (flutter/flutter#116110) * e438a1205 [tools]build ipa validate app icon size (flutter/flutter#115594) * 50f101acd 3956f6d02 Roll Skia from 829527b29b32 to 6d759de2e5b2 (2 revisions) (flutter/engine#37967) (flutter/flutter#116228) * a9c2f8b9e Add onFocusChange property for ListTile widget (flutter/flutter#111498) * 9532b91c7 [flutter_tools] normalize windows file path cases in flutter validator (flutter/flutter#115889) * 6b98f2ca4 labeledTapTargetGuideline should passe if textfield does not have label (flutter/flutter#116221) * fa063eb4c 25a2ac85f [Impeller Scene] Wire up pipelines (flutter/engine#37961) (flutter/flutter#116233) * afda8153f Adjust Material 3 textfield padding to align with specs (flutter/flutter#116225) * 322dd06d6 Updated the M3 textTheme to use `onSurface` color for all styles. (flutter/flutter#116125) * 333397a0e Fix Material 3 `BottomSheet` example (flutter/flutter#116112) * 8473da22c Fix `Slider` semantic node size (flutter/flutter#115285) * 31ea315c3 Add offline docs, up the h2 size (flutter/flutter#116241) * b30eb6c54 Updated `useMaterial3` documentation to include missing M3 components. (flutter/flutter#116234) * 06979d4e2 shrinkWrap nuke (flutter/flutter#116236) * db8ded7a5 Roll Flutter Engine from 25a2ac85f6aa to e20362343564 (2 revisions) (flutter/flutter#116243) * 02de12947 Roll Flutter Engine from e20362343564 to d5690468da0f (2 revisions) (flutter/flutter#116244) * b2672fe83 Revert "Add Material 3 support for `TabBar` (#116110)" (flutter/flutter#116273) * enable test (#5312) * Revert "enable test (#5312)" (#6782) This reverts commit 89ad5a9d6a337ab63ee8c122a59b9302f454a40f. * Roll Flutter from b2672fe8355f to 33f3e13dfff6 (72 revisions) (#6787) * ef999051d Roll Flutter Engine from d5690468da0f to 1bda5f8c094d (5 revisions) (flutter/flutter#116290) * a52293843 [Reland] Add Material 3 support for `TabBar` (flutter/flutter#116283) * c461f4f66 0f17acdaf Roll Skia from 8f4f340f830c to bd9a7f3485b4 (3 revisions) (flutter/engine#37978) (flutter/flutter#116291) * 24b3c384c add debug trace when compiling dart2js (flutter/flutter#116238) * 29422d25f M3 snackbar [re-land] (flutter/flutter#116218) * d2af13457 Revert "Fix `Slider` semantic node size (#115285)" (flutter/flutter#116294) * 71139099c e00aeef24 Roll Fuchsia Mac SDK from ECusE22sNK6IbnL6L... to C4DamROwkxoF0YXyS... (flutter/engine#37983) (flutter/flutter#116295) * fcc8ea117 ff3a7789f ubuntu version (flutter/engine#37948) (flutter/flutter#116300) * a29796e33 [flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP clients (flutter/flutter#116275) * 2ef2cc89e [flutter_tools] add deprecation message for "flutter format" (flutter/flutter#116145) * e62b6e799 Track entire web build directory size in web_size__compile_test (flutter/flutter#115682) * 3b89c981b Roll Flutter Engine from ff3a7789f45a to d8f151e24fda (2 revisions) (flutter/flutter#116301) * 0d0febc94 Add release_build parameter (flutter/flutter#116307) * 43d5cbb15 Roll Flutter Engine from d8f151e24fda to f8dc855ddb40 (2 revisions) (flutter/flutter#116305) * 7802c7acd [gen_l10n] Improvements to `gen_l10n` (flutter/flutter#116202) * 97195d1d5 Update CupertinoContextMenu to iOS 16 visuals (flutter/flutter#110616) * 762348630 be4c7e295 Roll Skia from d378c7817d8a to 2a75bac61922 (2 revisions) (flutter/engine#37989) (flutter/flutter#116309) * aaa4a5283 Add Material 3 `Slider` example (flutter/flutter#115638) * e5e21c983 Roll Flutter Engine from be4c7e2955c8 to 99b000e1e111 (2 revisions) (flutter/flutter#116310) * 6bb412e35 Added `controller` and `onSelected` properties to DropdownMenu (flutter/flutter#116259) * e93532748 3c1de6882 Fix typo on avoid_backing_store_cache param doc (flutter/engine#37985) (flutter/flutter#116313) * 014b441dd Revert "iOS 16 context menu (#115805)" (flutter/flutter#116312) * 4878f26ab 441229a95 Roll Skia from 2a75bac61922 to 767175530c11 (4 revisions) (flutter/engine#37994) (flutter/flutter#116318) * 7572ce907 51356bf89 [Impeller] Implement 'ui.Image.toByteData()' (flutter/engine#37709) (flutter/flutter#116321) * 8a806d675 677549602 Roll Skia from 767175530c11 to 4418e5468ee2 (3 revisions) (flutter/engine#37999) (flutter/flutter#116335) * 6e8ebb377 Reland "Upgrade targetSdkVersion and compileSdkVersion to 33" (flutter/flutter#116146) * 415545397 Roll Plugins from a431b35bfa0b to 89ad5a9d6a33 (7 revisions) (flutter/flutter#116356) * 929003e49 52054a327 Roll Fuchsia Mac SDK from C4DamROwkxoF0YXyS... to hODX8Qi_7J5kwKp4S... (flutter/engine#38002) (flutter/flutter#116354) * e86d0b3b8 31f099c21 Roll Skia from 4418e5468ee2 to 06801a30fc86 (1 revision) (flutter/engine#38003) (flutter/flutter#116361) * 458f129b8 d75b7ce37 Roll Skia from 06801a30fc86 to bfc7c3a83dc0 (4 revisions) (flutter/engine#38004) (flutter/flutter#116365) * 49f598097 Suggest Rosetta when x64 binary cannot be run (flutter/flutter#114558) * 3b15d6a50 Removes retries from "dart pub get" and un-buffers its stdout/stderr output (flutter/flutter#115801) * 6bd5e4798 303e26e96 [Impeller] Use glyph bounds to compute the max glyph size instead of font metrics (flutter/engine#37998) (flutter/flutter#116372) * 0bb71df75 Add clarification to CupertinoUserInterfaceLevel docs (flutter/flutter#116371) * 10c049da7 ec5de9b81 Roll Skia from bfc7c3a83dc0 to 6f6793b298ff (4 revisions) (flutter/engine#38007) (flutter/flutter#116378) * 75f61903e [flutter_tools] disable web compilation (flutter/flutter#116368) * f6224f368 [gen_l10n] keys can contain dollar sign (flutter/flutter#114808) * 4e8dacac8 Bump github/codeql-action from 2.1.32 to 2.1.35 (flutter/flutter#116379) * 5b8e36023 Roll Flutter Engine from ec5de9b810ef to abb68f40be70 (3 revisions) (flutter/flutter#116384) * b02a9c241 Roll Flutter Engine from abb68f40be70 to 1603fa1bb412 (2 revisions) (flutter/flutter#116387) * 0234b18f8 Tweak directional focus traversal (flutter/flutter#116230) * be81e9eae [tools]build ipa validate launch image using template files (flutter/flutter#116242) * 94e11624a 9463b5d19 Made responses to platform methods threadsafe in linux (flutter/engine#37689) (flutter/flutter#116397) * 9497dd8f5 025aefc7a Update Firefox to 106.0 (flutter/engine#38019) (flutter/flutter#116399) * ce9423028 [flutter_tools] Pin path_provider_android and roll pub packages (flutter/flutter#116377) * 7c0f882a9 Revert "[flutter_tools] Pin path_provider_android and roll pub packages (#116377)" (flutter/flutter#116424) * 748212afc 4c72d5c82 [Impeller] Add rect cutout (flutter/engine#38020) (flutter/flutter#116401) * 4a55eefa3 [conductor] Add instructions to update oncall logs (flutter/flutter#115871) * 5c9754302 Roll Flutter Engine from 4c72d5c82152 to 8e0747cc306f (7 revisions) (flutter/flutter#116426) * e065c7fea [framework] make ImageFiltered a repaint boundary (flutter/flutter#116385) * a1b8dc9ea Marks Linux_android animated_complex_image_filtered_perf__e2e_summary to be unflaky (flutter/flutter#116423) * e59a388b9 Roll Flutter Engine from 8e0747cc306f to 6bbf3e0e3c8b (2 revisions) (flutter/flutter#116432) * 22cbef305 [CP] Fix Snackbar TalkBack regression (flutter/flutter#116417) * 162be5933 [tools]build IPA validation bundle identifier using the default "com.example" prefix (flutter/flutter#116430) * 4643f833d a8a08d107 [web] Remove outdated information in web_ui/README (flutter/engine#38006) (flutter/flutter#116435) * 08a2635e2 [devicelab] add benchmark for complex non-intersecting widgets with platform views (flutter/flutter#116436) * db1c3e208 Platform binaries reland (flutter/flutter#115502) * 7751ec0fd 98b947a54 Fix typo in Animator comment (flutter/engine#38040) (flutter/flutter#116438) * c3e561236 Zip api docs using the repo under test script. (flutter/flutter#116437) * b75f1a941 afdc32933 Roll Fuchsia Mac SDK from aHgLxcRDjOQNKL7zH... to BDTULRXL5gDEHXmRA... (flutter/engine#38043) (flutter/flutter#116441) * dd5f96bfd Roll Flutter Engine from afdc32933be7 to f7df812d26b7 (5 revisions) (flutter/flutter#116447) * f36874cb8 6d0ff37a4 Documentation and other cleanup in dart:ui, plus a small performance improvement. (flutter/engine#38047) (flutter/flutter#116449) * 934e69008 Add widget of the week videos (flutter/flutter#116451) * e59081887 d746877f7 [web] use a permanent live region for a11y announcements (flutter/engine#38015) (flutter/flutter#116452) * 0f462d305 7a35191aa Roll Skia from 6fdf7181e374 to d0e3902c97b3 (6 revisions) (flutter/engine#38051) (flutter/flutter#116455) * 73822f82c f9067ed20 [Impeller Scene] Rename mesh importer to scenec (flutter/engine#38049) (flutter/flutter#116458) * 599ceb999 cf05ab426 [embedder] Ensure FlutterMetalTexture cleanup call (flutter/engine#38038) (flutter/flutter#116460) * a85222ea5 9b484713f Roll Fuchsia Mac SDK from BDTULRXL5gDEHXmRA... to w333oMghC5jK9C-YE... (flutter/engine#38054) (flutter/flutter#116465) * 9a7d8a1a9 b3e86c31c [Impeller] Make perspective transform resolve to left handed clip space (flutter/engine#38052) (flutter/flutter#116467) * 6e5582da9 662c5f8df [Impeller Scene] Wire up camera (flutter/engine#38053) (flutter/flutter#116468) * 964422c0d e10bf9c2c [Impeller] Add Quaternion to Matrix conversion (flutter/engine#38056) (flutter/flutter#116472) * 33f3e13df 5ac98f8a7 Roll Fuchsia Mac SDK from w333oMghC5jK9C-YE... to N9nk_ceXcPxQEjGEL... (flutter/engine#38057) (flutter/flutter#116475) * [camera] Handle empty grantResults on permission request (#6758) * [camera] Handle empty grantResults on permission request * update changelog and add test * fix typo * format * Update packages/camera/camera_android/CHANGELOG.md Co-authored-by: Camille Simon <[email protected]> Co-authored-by: Camille Simon <[email protected]> * Roll Flutter from 33f3e13dfff6 to 30fc993caed5 (6 revisions) (#6791) * [gh_actions]: Bump github/codeql-action from 2.1.27 to 2.1.35 (#6788) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.27 to 2.1.35. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/807578363a7869ca324a79039e6db9c843e0e100...b2a92eb56d8cb930006a1c6ed86b0782dd8a4297) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [camera] Add ability to concurrently record and stream video (#6290) * Implement interface methods to allow concurrent stream and record There will be a subsequent change to the `camera` package to make use of these implementations. * Fix android test * Format android_camera_test.dart * Resolve analyze failures * Fix version bumps * Fix MethodChannelCameraTest * Fix comment on FLTCam * Add tests to confirm can't stream on windows or web * CHANGELOG updates * Fix analyze errors * Fix dart analyze warnings for web * Formatted * Revert "[camera] Add ability to concurrently record and stream video (#6290)" (#6796) This reverts commit 374e59804a6c544873209b3da30ea207f9d6aff4. * [ci] Fix macOS LUCI merge base (#6798) Currently the repo tooling relies on `FETCH_HEAD` being set to `origin/main` in CI, which is done in `prepare_tool.sh` for LUCI bots. Longer term we should restructure the CI scripts to be explicit about the base SHA instead of relying on `FETCH_HEAD`, but for now this adds the missing `prepare_tool.sh` step to the new iOS LUCI tests so that they compute diffs correctly. Fixes https://github.com/flutter/flutter/issues/116448 * Roll Flutter from 30fc993caed5 to e2fb672a440e (25 revisions) (#6802) * d52e2de5b 878fc6fc0 Roll Fuchsia Mac SDK from 1ZS93HM4ImgmL2EPK... to SDbR-S_A_fv-v_Sbb... (flutter/engine#38069) (flutter/flutter#116524) * 56cad89b1 Speed up first asset load by encoding asset manifest in binary rather than JSON (flutter/flutter#113637) * e54e73ab5 Roll Flutter Engine from 878fc6fc022e to b4de17db2552 (2 revisions) (flutter/flutter#116535) * 06e7c7a61 Incrementally update gradle to AGP 7.2.0 and 7.3.3 in some `integration_tests` (flutter/flutter#116201) * 27281dab8 [flutter_tools] dont include material shaders in web builds (flutter/flutter#116538) * 49d0b5b39 a14d15f07 Roll Dart SDK from 6b7e44ae494b to 52599799b666 (19 revisions) (flutter/engine#38076) (flutter/flutter#116542) * 05c6df6d1 Improve Flex layout comment (flutter/flutter#116004) * 55bcb784a Do not parse stack traces in _findResponsibleMethod on Web platforms that use a different format (flutter/flutter#115500) * 5d042eb35 Bump dessant/lock-threads from 3.0.0 to 4.0.0 (flutter/flutter#116545) * 9dc5b9e29 Roll Flutter Engine from a14d15f07a1a to e2b1919a7596 (2 revisions) (flutter/flutter#116547) * 1b05653ab use deploy suffix (flutter/flutter#116533) * 0a8e92a11 d82c8ad7a Bump buildroot (flutter/engine#38062) (flutter/flutter#116550) * e0a0190c5 Roll Flutter Engine from d82c8ad7ac7f to 0efb0ef40513 (2 revisions) (flutter/flutter#116552) * 174d3be86 a309d239c [Impeller Scene] Parse GLTF primitives (flutter/engine#38064) (flutter/flutter#116556) * 520185680 Use file:/// style uris when passing platform to the compiler. (flutter/flutter#116553) * c834b1d60 012826e19 Roll Skia from e9c0d4b83ca4 to ad85f404b97d (3 revisions) (flutter/engine#38089) (flutter/flutter#116564) * eaf625448 5d8530f79 Roll Fuchsia Mac SDK from SDbR-S_A_fv-v_Sbb... to 8p38Xk7Z7OLI7OA7R... (flutter/engine#38090) (flutter/flutter#116566) * 5993a613f Roll Flutter Engine from 5d8530f79009 to a588dbe8b3c5 (2 revisions) (flutter/flutter#116571) * 921f07768 6d05ea479 Roll Skia from ad85f404b97d to e2244ea470c0 (5 revisions) (flutter/engine#38096) (flutter/flutter#116579) * 1e696d304 Support theming `CupertinoSwitch`s (flutter/flutter#116510) * b78323c19 Roll Plugins from 2a330bc0afd5 to 374e59804a6c (4 revisions) (flutter/flutter#116591) * 09c921c34 ec211d21e Roll Skia from e2244ea470c0 to b63a254727f3 (1 revision) (flutter/engine#38098) (flutter/flutter#116592) * 09d489391 e6e6a0210 implement targetWidth and targetHeight (flutter/engine#38028) (flutter/flutter#116598) * a8b36c7da Fix windows version validator under Chinese (flutter/flutter#116282) * e2fb672a4 Roll Flutter Engine from e6e6a02106c6 to 86d7cbf09e09 (2 revisions) (flutter/flutter#116601) * [google_maps_flutter] Add support to request map renderer for Android (#6619) * [google_maps_flutter] support to request a specific map renderer for android * [google_maps_flutter] Minor fixes to comments and error messages * [google_maps_flutter] fix linting issues * Roll Flutter from e2fb672a440e to a570fd25d83b (15 revisions) (#6804) * 21f3ce8b6 [gen_l10n] Multiline descriptions (flutter/flutter#116380) * cd87e094e Allow creating packages for master/main. (flutter/flutter#116557) * ee8ba7010 12ad3d766 Disable an extension in Xvfb to work around errors seen when running Impeller/Vulkan unit tests (flutter/engine#38092) (flutter/flutter#116604) * 98d241387 4ff8cc3ef Add gradle option to allow/show System.out.print logs (flutter/engine#38104) (flutter/flutter#116612) * 76f03359b Update dartdoc to 6.1.3 (flutter/flutter#116474) * 577a88b22 Fix MenuAnchor padding (flutter/flutter#116573) * 30c575140 [Android] Refactor the `flutter run` Android console output test (flutter/flutter#115023) * 91568cc9b Adjust upper Dart SDK constraint (flutter/flutter#116586) * 676229f33 Roll Flutter Engine from 4ff8cc3ef53b to 4f22c2789023 (3 revisions) (flutter/flutter#116620) * 609fe35f1 [Android] Fix Linux Android flavors_test (flutter/flutter#116129) * fb9133b88 Add ListenableBuilder with examples (flutter/flutter#116543) * 31719941c Time picker precursors (flutter/flutter#116450) * 8bce55d1e Roll Flutter Engine from 4f22c2789023 to 185e2f3d451c (3 revisions) (flutter/flutter#116632) * ef6ead440 Roll Flutter Engine from 185e2f3d451c to 67254d6e4b03 (2 revisions) (flutter/flutter#116633) * a570fd25d Date picker special labeling for currentDate with localization and te… (flutter/flutter#116433) * [google_maps_flutter] Roll cupertino_icons for compatibility with Dart 3 (#6807) * [camera] Re-enable ability to concurrently record and stream video (#6808) * Re-enable stream and record This re-commits the content from https://github.com/flutter/plugins/pull/6290. Will make a subsequent commit to try and fix the broken integ tests. * Fix broken integration test for streaming The `whenComplete` call was sometimes causing a race condition. It is also isn't needed for the test (to reset the value of isDetecting, given it's local), so removing it makes the test reliable. * Trivial CHANGELOG change to trigger full CI tests Co-authored-by: stuartmorgan <[email protected]> * [video_player] Fix file URI construction (#6803) * Fix bug in file constructor * Fix comment in interface package * Fix minicontroller for examples/tests/ * Version bumps * Skip file tests on web * Don't use file source in non-file tests, since web doesn't support it * Roll Flutter from a570fd25d83b to 521028c80827 (11 revisions) (#6810) * e07240e68 Update docs_deploy builder with the real name. (flutter/flutter#116631) * 182f9f666 Roll Plugins from 374e59804a6c to 7b5d8323efe3 (3 revisions) (flutter/flutter#116660) * 352ad3a9e Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (flutter/flutter#110730) * 7673108d7 Revert "Speed up first asset load by encoding asset manifest in binary rather than JSON (#113637)" (flutter/flutter#116662) * 68ce1aeae Reland "Use semantics label for backbutton and closebutton for Android" (flutter/flutter#115776) * cc256c3e3 Revert "Use semantics label for backbutton and closebutton for Android" (flutter/flutter#116675) * 297f094c0 LookupBoundary (flutter/flutter#116429) * 7b458e5af Implement Linux part of examples (flutter/flutter#108068) * 3f1fb1b96 Update assets_for_android_views git dependency pins (flutter/flutter#116639) * 8b80552a3 Fix language version check logic to determine nullsafe soundness. (flutter/flutter#116679) * 521028c80 Reland "Use semantics label for backbutton and closebutton for Android" (flutter/flutter#116676) * Roll Flutter from 521028c80827 to eefbe85c8bd4 (10 revisions) (#6820) * [tools] Recognize Pigeon tests in version-check (#6813) Pigeon has an usual test structure since it generates test code to run in a dummy plugin; add that structure to the list of recognized tests so that changes to its platform tests won't be flagged by `version-check`. * [camera] Attempt to fix flaky new Android test (#6831) The recently added "recording with image stream" test is very flaky, often throwing on `stop`. This is a speculative fix for that flake based on the documentation of `stop` indicating that it will throw if nothing has been recorded. * [google_maps_flutter] Modified `README.md` to fix minor syntax issues (#6631) * Refactored Reaadme using code excerpts * Fixes * Updated Upstream and Fixed Test Errors * Re-added temp_exclude_excerpt.yaml back due to Failing Test * Restore deleted changelog entries Co-authored-by: stuartmorgan <[email protected]> * Roll Flutter from eefbe85c8bd4 to bd0791be3ff2 (25 revisions) (#6832) * 48cfe2eb0 Opt dashing_postprocess.dart out of null safety until we figure out why (flutter/flutter#116786) * b4304dadc Update the Dart language version in the pubspec generated by the dartdoc script (flutter/flutter#116789) * 55e750115 Roll Plugins from 51434ec83dde to 6ab7d710d2fb (3 revisions) (flutter/flutter#116781) * e57b7f4ea Add Material 3 support for `ListTile` - Part 1 (flutter/flutter#116194) * 73cb7c2fc Squashed MediaQuery InheritedModel (flutter/flutter#114459) * 1da8f4edc Several fixes to packaging builders. (flutter/flutter#116800) * 86fa9e511 Roll Flutter Engine from 8d83b98c55b3 to 030950f3070c (29 revisions) (flutter/flutter#116802) * ca3ce3945 89fd33c62 Don't use sync*, as it is unimplemented in dart2wasm. (flutter/engine#38149) (flutter/flutter#116808) * 332032dda Roll Flutter Engine from 89fd33c62f2c to a259613ab871 (2 revisions) (flutter/flutter#116811) * 9dd30878d Add LookupBoundary to Material (flutter/flutter#116736) * cbdc763cf Roll Flutter Engine from a259613ab871 to 8b56b5a98ed4 (2 revisions) (flutter/flutter#116813) * c4b8046d9 Floating cursor cleanup (flutter/flutter#116746) * 7d7848aba d64a5129a [const_finder] Ignore constructor invocations from generated tear-off declarations (flutter/engine#38131) (flutter/flutter#116814) * be5c389e6 faae28965 Roll Skia from 44062eff3e25 to 1b194c67700e (2 revisions) (flutter/engine#38166) (flutter/flutter#116817) * 7549925c8 Revert "Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (#110730)" (flutter/flutter#116839) * 68f02dd2e Roll Flutter Engine from faae28965a94 to fbb79e704b0a (6 revisions) (flutter/flutter#116843) * ec02f3bfb 656b67796 Roll Dart SDK from 0940b5e6ccd5 to 21f2997a8fc6 (9 revisions) (flutter/engine#38172) (flutter/flutter#116844) * c02d53fc0 More gracefully handle license loading failures (flutter/flutter#87841) * 4a1511166 0795bccae Roll Skia from 0d482f9fa8b3 to 80d9e679f909 (2 revisions) (flutter/engine#38195) (flutter/flutter#116853) * 1fc166a51 3ca497ebb Roll Skia from 80d9e679f909 to 29791c73ae16 (1 revision) (flutter/engine#38200) (flutter/flutter#116859) * 9fdb64b7e Taboo the word "simply" from our API documentation. (flutter/flutter#116061) * 92aebc953 922546c91 [Impeller] Fix asset names used for the generated entrypoint name can contain invalid identifiers for the target language (flutter/engine#38202) (flutter/flutter#116868) * 437f6f86e 9e37c9883 Roll Skia from 29791c73ae16 to 7bd37737e35d (1 revision) (flutter/engine#38207) (flutter/flutter#116871) * d19f77674 62a5de2ef Roll Skia from 7bd37737e35d to 0cb546781e89 (4 revisions) (flutter/engine#38213) (flutter/flutter#116880) * bd0791be3 Pass drone_dimensions as part of the main target. (flutter/flutter#116812) * Reland "[google_maps_flutter] ios: re-enable test with popup #5312" (#6783) * reland fix fix test for iOS 16 fix fix typos * format * update changelog * Update FlutterFire link (#6835) * Roll Flutter from bd0791be3ff2 to 15af81782e19 (27 revisions) (#6837) * d1436d1df Roll Plugins from 6ab7d710d2fb to 0609adb457fd (2 revisions) (flutter/flutter#116891) * 84ed058b4 [flutter_tools] Add remap sampler support (flutter/flutter#116861) * a8c9f9c6f Fix `NavigationBar` ripple for non-default `NavigationDestinationLabelBehavior` (flutter/flutter#116888) * 5a229e282 Add LookupBoundary to Overlay (flutter/flutter#116741) * d19047d8a [framework] make opacity widget create a repaint boundary (flutter/flutter#116788) * 882e105a4 Revert "Add Material 3 support for `ListTile` - Part 1 (#116194)" (flutter/flutter#116908) * 7a743c881 [flutter_tools] Pin and roll pub (flutter/flutter#116745) * 558b7e004 Adjust test to tolerate additional trace fields (flutter/flutter#116914) * c420562ef Fix output match (flutter/flutter#116912) * 8e1f8352b Fix MediaQuery.paddingOf (flutter/flutter#116858) * 8cfc6061e Roll Flutter Engine from 62a5de2efc9c to 2148fc003077 (5 revisions) (flutter/flutter#116920) * 601f48cd9 InteractiveViewer discrete trackpad panning (flutter/flutter#112171) * 41625b662 Test flutter run does not have unexpected engine logs (flutter/flutter#116798) * 9b46f2a69 ff2fe8381 [cpp20] Fix incompatible aggregate initialization (flutter/engine#38165) (flutter/flutter#116927) * 15939b477 Remove duped fix rules (flutter/flutter#116933) * e331dcda1 [framework] make transform with filterQuality a rpb (flutter/flutter#116792) * 6432fd1b1 6c190ea1e Roll Skia from bb9378b61c4f to 788fe69e7ade (6 revisions) (flutter/engine#38226) (flutter/flutter#116935) * 97df2b319 Fix scroll jump when NestedScrollPosition is inertia-cancelled. (flutter/flutter#116689) * ca7fe3348 Roll Flutter Engine from 6c190ea1e8df to e144f81e92d8 (3 revisions) (flutter/flutter#116939) * b713edcee 290f3a35e Roll Skia from 788fe69e7ade to 2e417d4f7993 (3 revisions) (flutter/engine#38235) (flutter/flutter#116941) * 04ee5926a Remove RenderEditable textPainter height hack (flutter/flutter#113301) * 7211ca09d a33e699de Roll Skia from 2e417d4f7993 to 08dc0c9e4e70 (1 revision) (flutter/engine#38239) (flutter/flutter#116952) * f5249bcb0 Remove use of NullThrownError (flutter/flutter#116122) * 9ccfb87ad 64a661d6d Roll Skia from 08dc0c9e4e70 to 9abf4b1bf242 (4 revisions) (flutter/engine#38240) (flutter/flutter#116955) * 256d54e17 47417ce80 [Impeller Scene] Node deserialization (flutter/engine#38190) (flutter/flutter#116959) * db26f486e afc2f9559 Roll Skia from 9abf4b1bf242 to c83eef7dc2a3 (3 revisions) (flutter/engine#38243) (flutter/flutter#116970) * 15af81782 74a9c7e0f Roll Fuchsia Mac SDK from aMW0DjntzFJj4RoR3... to Cd_ZtrDVcpQ85HRL3... (flutter/engine#38242) (flutter/flutter#116973) * [local_auth]: Bump fragment from 1.5.4 to 1.5.5 in /packages/local_auth/local_auth_android/android (#6826) * [local_auth]: Bump fragment Bumps fragment from 1.5.4 to 1.5.5. --- updated-dependencies: - dependency-name: androidx.fragment:fragment dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Version bump * Empty-Commit * Empty-Commit Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: camsim99 <[email protected]> * Roll Flutter from 15af81782e19 to 028c6e29e0ca (13 revisions) (#6843) * dbb9aa8b9 Roll Plugins from 0609adb457fd to ec2041f82584 (6 revisions) (flutter/flutter#116996) * cd9a439c3 Roll Flutter Engine from 74a9c7e0f9b1 to 9872cc7addce (2 revisions) (flutter/flutter#116997) * 4e1372080 dd1dc7258 Always set orientation preferences on iOS 16+ (flutter/engine#38230) (flutter/flutter#117005) * 51945a0df Roll Flutter Engine from dd1dc7258b99 to 82dafdfc1c3d (2 revisions) (flutter/flutter#117015) * 96597c25e Bump Dartdoc version to 6.1.5 (flutter/flutter#117014) * 0c7d84aa7 Add AppBar.forceMaterialTransparency (#101248) (flutter/flutter#116867) * a59dd83d7 a327b48ca Roll Skia from 280ac8882cff to 537e1e8c1ca6 (9 revisions) (flutter/engine#38264) (flutter/flutter#117025) * fae458b92 Convert TimePicker to Material 3 (flutter/flutter#116396) * ba917d615 Remove workaround because issue is closed (flutter/flutter#110854) * 60635be59 984ec305a Run Mac Host clang-tidy on 12 cores (flutter/engine#38261) (flutter/flutter#117028) * f0ea37646 Roll Flutter Engine from 984ec305a0dd to 14194c40ec00 (2 revisions) (flutter/flutter#117031) * f07db4018 `NavigationBar` improvements (flutter/flutter#116992) * 028c6e29e [Android] Fix the `run_debug_test_android` device lab test (flutter/flutter#117016) * [camera_android_camerax] `unnecessary_parenthesis` lint fix (#6841) * fixed `unnecessary_parenthesis` * fmt * [various] Enable avoid_print (#6842) * [various] Enable avoid_print Enables the `avoid_print` lint, and fixes violations (mostly by opting example files out of it). * Version bumps * Add tooling analysis option file that was accidentally omitted * Fix typo in analysis_options found by adding tool sub-options * Revert most version bumps * Fix ios_platform_images * [webview_flutter_platform_interface] Updates platform interface to new interface (#6846) * Set new interface in main * update pubspec changelog and readme * exclude from all plugins app test * delete all of platform interface * add all back to platform interface * Roll Flutter (stable) from b8f7f1f9869b to 135454af3247 (6 revisions) (#6850) * 199c4bf4c CP: ci.yaml changes for packaging (flutter/flutter#117038) * 8461df291 Add release_build parameter (#116307) (flutter/flutter#117088) * 1545b041b Zip api docs using the repo under test script. (#116437) (flutter/flutter#117093) * f3bc66195 [flutter_releases] Flutter stable 3.3.10 Framework Cherrypicks (flutter/flutter#117041) * 3778e3c76 Revert "CP: ci.yaml changes for packaging (#117038)" (flutter/flutter#117132) * 135454af3 CP: ci.yaml changes for packaging (flutter/flutter#117133) * [webview_flutter_android] Copies Android implementation of webview_flutter from v4_webview (#6851) * new android release * Version bump * update all plugins config * fix lints and add action item to changelog * [webview_flutter_wkwebview] Copies iOS implementation of webview_flutter from v4_webview (#6852) * new ios release * version bump * add breaking change change * update excludes file * fix lints and add to changelog * [local_auth] Fix failed biometric authentication not throwing error (#6821) * fix failed biometric authentication not throwing error + tests * fix test names * Revert "fix test names" This reverts commit 89ba69ccc33c37b98092a5fbfa5c71ebc23cd468. * Revert "fix failed biometric authentication not throwing error + tests" This reverts commit 684790a7c7756c963ac3aa3b6e4de48cc9b33df5. * fix authentication not throwing error + tests * fix test name * auto format * cr fixes * addressed pr comments * formatting * formatting * formatting * format attempt * format attempt * formatting fixes * change incorrect versionning * fix test * add back macro * fixed up tests, removed unnecessary assertions, replaced isAMemberOf * add back error for unknown error codes * tests * changed enum to something thats not deprecated * remove redundant test * [webview_flutter_web] Copies web implementation of webview_flutter from v4_webview (#6854) * v4 web impl * add breaking change * fix lints * exclude web plugin * [image_picker] Don't store null paths in lost cache (#6678) If the user cancels image selection on Android, store nothing in the lost image cache rather than storing an array with a null path. While we could potentially keep this behavior and instead handle it differently on the Dart side, returning some new "cancelled" `LostDataResponse`, that would be semi-breaking; e.g., the current example's lost data handling would actually throw as written if we had a new non-`isEmpty`, non-exception, null-`file` response. Since nobody has requested the ability to specifically detect a "lost cancel" as being different from not having started the process of picking anything, this doesn't make that potentially-client-breaking change. If it turns out there's a use case for that in the future, we can revisit that (but should not do it by storing a null entry in a file array anyway). Fixes https://github.com/flutter/flutter/issues/114551 * [webview_flutter_android] Fix timeouts in the integration tests (#6857) * fix timeouts * remove broadcast instead * just use completers like a lame person * [flutter_plugin_tools] If `clang-format` does not run, fall back to other executables in PATH (#6853) * If clang-format does not run, fall back to other executables in PATH * Review edits * [video_player] Add compatibility with the current platform interface (#6855) * Relax version constraints * Update app-facing * Version bumps * [image_picker] Improve image_picker for iOS to handle more image types (#6812) * Improve image picker for ios to handle more image types * Update release info * different svg, remove raw test * change pro raw image * change pro raw image * add error log * fix formatting * fix image identifiers in test * get image type identifier from itemProvider in test * [webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview (#6856) * copy code from v4_webview * version bump and readme update * work towards better readme * improvements * more readme progress * improvements * fix main and update more readme * excerpt changes and more 3.0 diffs * cookie manager update * remove packages from exclude list * lint * better range * isForMainFrame * load page after waiting for widget * fix integration tests * improve readme a bit * collapse changelong. update platform-specific wording. include in excerpt tests * use platform implementation packages * include missing exports * PR comments * correct spelling * interface dev dependency * move other usage above migration * remove interface classes * [image_picker_ios] Pass through error message from image saving (#6858) * [image_picker_ios] Pass through error message from image saving * Review edits * Format * addObject * [local_auth] Bump `intl` from ^0.17.0 to ">=0.17.0 <0.19.0" (#6848) * Update intl from 0.17.0 to 0.18.0 * [local_auth] Bump `intl` from ^0.17.0 to ">=0.17.0 <0.19.0" * [local_auth] improve changelog description * [local_auth] improve changelog description * [local_auth] removes unused `intl` dependency * [gh_actions]: Bump github/codeql-action from 2.1.35 to 2.1.37 (#6860) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/b2a92eb56d8cb930006a1c6ed86b0782dd8a4297...959cbb7472c4d4ad70cdfe6f4976053fe48ab394) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [camera] Remove deprecated Optional type (#6870) * Remove Optional * Undo accidental order change * Fix examples analyze * Remove unused import * Bump versions * Correct version * [in_app_purchase] Add support for macOS (#6519) * Updated version and changelog. * Updated readme to mention MacOS as a supported platform. * Minor fixup. * Fixed capitalization in readme. * Added macos to example. * Updated MacOS example. * Unified macOS capitalization. * Removed generated app icons. * Updated version and deployment target. * Updated version to a minor version change. Was previously only a patch. * Roll Flutter from 028c6e29e0ca to dbc9306380d8 (11 revisions) (#6849) * 8e452be2f Marks Windows run_release_test_windows to be unflaky (flutter/flutter#117071) * 0e0f29fc8 Run packaging builders only on beta and stable. (flutter/flutter#117037) * ef3fe6a05 10c029399 [local_auth]: Bump fragment from 1.5.4 to 1.5.5 in /packages/local_auth/local_auth_android/android (flutter/plugins#6826) (flutter/flutter#117078) * 7a801f766 0baa4b5b3 Generate font fallback data to be const. (flutter/engine#38259) (flutter/flutter#117080) * c63d797f9 Upgrade dependencies (flutter/flutter#117007) * 57fb36ee0 [reland] Add Material 3 support for `ListTile` - Part 1 (flutter/flutter#116963) * f9acb1e88 -- unnecessary parens (flutter/flutter#117081) * aa0b68119 flutter/[email protected] (flutter/flutter#117083) * d8b7eb6e2 Updated token templates to sync with master code. (flutter/flutter#117097) * 7b19b4d38 Fix CupertinoTextSelectionToolbar showing unnecessary pagination (flutter/flutter#104587) * dbc930638 Failure to construct ErrorWidget for build errors does not destroy tree (flutter/flutter#117090) * [webview_flutter_wkwebview] Adds support for `WKNavigationAction.navigationType` (#6863) * add navigation type to navigation action * version bump and export * remove import * ios unit test * lint warning * formatting * add readme change to CHANGELOG * remove unused method * undo mocks change * last mocks change * mention pigeon dependency * [webview_flutter_android] Adds support for selecting Hybrid Composition (#6864) * add displayWithHybridComposition flag * move duplicate method * unit tests * adds * update docs * create platformviewsserviceproxy * use proxy for platformviewsservice * remove usused code * update display mode * use clever imports * [webview_flutter_android] Fixes bug where a `AndroidNavigationDelegate` was required to load a request (#6872) * fix bug * comment * another test * fix spelling * Roll Flutter from dbc9306380d8 to 9fb1ae839e0a (106 revisions) (#6876) * 9aa2ea150 Roll Flutter Engine from 0a6a4a58f4f7 to db5605ea7115 (11 revisions) (flutter/flutter#117109) * 409a39dae remove debugPrint from timePicker test (flutter/flutter#117111) * 169b49fba Revert "[framework] make transform with filterQuality a rpb (#116792)" (flutter/flutter#117095) * 47300e0a6 Roll Plugins from 10c029399b3a to 78de28ca21c7 (4 revisions) (flutter/flutter#117145) * dcd2170d1 Fix typos in scale gesture recognizer docs (flutter/flutter#117116) * fc3571eff Improve documentation of `compute()` function (flutter/flutter#116878) * b122200d4 Roll Flutter Engine from db5605ea7115 to 29196519c124 (13 revisions) (flutter/flutter#117148) * f1d157bc2 Add an integration test to plugin template example (flutter/flutter#117062) * ada446050 Audit `covariant` usage in tool (flutter/flutter#116930) * 1eaf5c0f0 [flutter_tools] tree shake icons from web builds (flutter/flutter#115886) * 91c1c70bd Bump ossf/scorecard-action from 2.0.6 to 2.1.0 (flutter/flutter#117170) * c98978ae3 Update Navigator updatePages() (flutter/flutter#116945) * 0916375f4 [tools]Build IPA validation UI Polish (flutter/flutter#116744) * a41c447c8 Pass dimension explicitly to mac x64 packaging. (flutter/flutter#117172) * 86b62a3c2 Tiny fix about outdated message (flutter/flutter#114391) * a34e41948 Inject current `FlutterView` into tree and make available via `View.of(context)` (flutter/flutter#116924) * c7cb5f3f5 [flutter_tools] pin package intl and roll pub packages (flutter/flutter#117168) * 7336312b0 Do not filter the stderr output of "flutter run" in the devicelab run tests (flutter/flutter#117188) * fa711f77e Run packaging on presubtmit. (flutter/flutter#116943) * 76bb8ead5 Reland "Fix text field label animation duration and curve" (#114646)" * 80e1008cb fix: #110342 unable to update rich text widget gesture recognizer (flutter/flutter#116849) * da7b8327e Bottom App Bar M3 background color fix (flutter/flutter#117082) * ab47fc304 Roll Plugins from 78de28ca21c7 to cbcf50726fb9 (3 revisions) (flutter/flutter#117213) * 23a2fa31d Reland "Adds API in semanticsconfiguration to decide how to merge chi… (flutter/flutter#116895) * 9102f2fe0 Revert "Inject current `FlutterView` into tree and make available via `View.of(context)` (#116924)" (flutter/flutter#117214) * 3d0607b54 Defer `systemFontsDidChange` to the transientCallbacks phase (flutter/flutter#117123) * ecf9b2d20 Update localization of shortcut labels in menus (flutter/flutter#116681) * 0604a0e1e Add a recursive flag to the zip command - currently it is zipping nothing (flutter/flutter#117227) * 98e9032ca [web] Allow shift + left/right keyboard shortcuts to be handled by framework on web (flutter/flutter#117217) * ebeb49189 Use the name of errors, not the diagnostic messages. (flutter/flutter#117229) * 93c581a72 Formatted and removed lints from devicelab README.md (flutter/flutter#117239) * 5018a6c1f Roll Flutter Engine from 29196519c124 to d91e20879a67 (29 revisions) (flutter/flutter#117242) * 36d536a32 Roll Flutter Engine from d91e20879a67 to 60cf34e2abf1 (4 revisions) (flutter/flutter#117246) * c9dd45847 42689eafb Sped up FlutterStandardCodec writing speed. (flutter/engine#38345) (flutter/flutter#117249) * 0a2a1d91c d45d375ae [iOS, macOS] Migrate from assert to FML_DCHECK (flutter/engine#38368) (flutter/flutter#117256) * bf5fdb9f9 Reland "Inject current FlutterView into tree and make available via `View.of(context)` (#116924)" (flutter/flutter#117244) * 427b2fb42 901b455d0 Roll Fuchsia Mac SDK from bn5VF1-xDf-wKjIw8... to qYE6uXjRtAxy7p5HB... (flutter/engine#38373) (flutter/flutter#117258) * cee3e6cc3 b10769998 Even though the file is pure C code, it's useful to use a C++ or Objective-C++ filename in order to use FML (assertions) in the implementation. (flutter/engine#38365) (flutter/flutter#117260) * 7b850ef37 f74dd5331 Roll Fuchsia Linux SDK from H6B0UgW07fc1nBtnc... to PqyqxdbUFyd8xoYIP... (flutter/engine#38377) (flutter/flutter#117262) * b20a9e0a3 imporve gesture recognizer semantics test cases (flutter/flutter#117257) * a82c556a1 3626c487a Add a missing include to display_list_matrix_clip_tracker.h (flutter/engine#38371) (flutter/flutter#117269) * 9daf2a67e Roll Flutter Engine from 3626c487a610 to 7e296985f426 (2 revisions) (flutter/flutter#117270) * d0d13c545 51b84d69b Roll Fuchsia Mac SDK from qYE6uXjRtAxy7p5HB... to qk9nUlw83EeMMaWmE... (flutter/engine#38380) (flutter/flutter#117273) * 725049f2b 794370b9c Roll Fuchsia Linux SDK from PqyqxdbUFyd8xoYIP... to bloqad357AGI6lnOb... (flutter/engine#38381) (flutter/flutter#117276) * 49f3ca400 eeae936f9 Use canvaskit `toByteData` for unsupported videoFrame formats (flutter/engine#38361) (flutter/flutter#117279) * c0dddacb8 Fix is canvas kit bool (flutter/flutter#116944) * d88d52405 276327f7e Roll Fuchsia Mac SDK from qk9nUlw83EeMMaWmE... to DdU--deE0Xl4TQ2Bm... (flutter/engine#38383) (flutter/flutter#117286) * b7d9be0a7 747a9d8c7 Roll Skia from 7b0a9d9a3008 to 0362c030efa7 (9 revisions) (flutter/engine#38385) (flutter/flutter#117289) * 1233fc979 37387019b Roll Fuchsia Linux SDK from bloqad357AGI6lnOb... to mRBUNknZk43y-LHGS... (flutter/engine#38386) (flutter/flutter#117290) * a3a0048d7 3c6cab032 Roll Fuchsia Mac SDK from DdU--deE0Xl4TQ2Bm... to NLb_T58g0l_X46JEN... (flutter/engine#38387) (flutter/flutter#117295) * 420c6d6cc Roll Flutter Engine from 3c6cab03274f to 58ab5277a7c4 (2 revisions) (flutter/flutter#117312) * d238bedf4 Roll Plugins from cbcf50726fb9 to 840a04954fa0 (8 revisions) (flutter/flutter#117314) * 3eefb7af0 a9491515f Roll Skia from 0362c030efa7 to fc0ac31a46f8 (4 revisions) (flutter/engine#38399) (flutter/flutter#117317) * 9f9010f5e [flutter_tools] Update DAP progress when waiting for Dart Debug extension connection (flutter/flutter#116892) * 32da25053 a12dadfda Roll Fuchsia Mac SDK from NLb_T58g0l_X46JEN... to NS4fVXM2KhKcZ1uyD... (flutter/engine#38400) (flutter/flutter#117319) * cb988c7b6 Add `indicatorColor` & `indicatorShape` to `NavigationRail`, `NavigationDrawer` and move these properties from destination to `NavigationBar` (flutter/flutter#117049) * 5fcb48d59 Fix `NavigationRail` highlight (flutter/flutter#117320) * 70f391db7 7bc519375 Roll Skia from fc0ac31a46f8 to 46af4ad25426 (1 revision) (flutter/engine#38403) (flutter/flutter#117322) * 9f2c5d8e2 Support `flutter build web --wasm` (flutter/flutter#117075) * 55584ad50 Roll Flutter Engine from 7bc519375b7b to 45713ea10510 (2 revisions) (flutter/flutter#117330) * 4daff0857 Roll Flutter Engine from 45713ea10510 to cba3a3990138 (5 revisions) (flutter/flutter#117336) * 1adc27503 Bump min SDK to 2.19.0-0 (flutter/flutter#117345) * efadc3458 Roll Flutter Engine from cba3a3990138 to 6de29d1cba70 (3 revisions) (flutter/flutter#117354) * b30947bef roll packages (flutter/flutter#117226) * e625e5f46 3330cce60 Roll Fuchsia Linux SDK from yGQvkNl85l1TSeuo9... to uKNwsaf92uZcX_QiY... (flutter/engine#38411) (flutter/flutter#117358) * 50a23d962 339791f19 Roll Skia from 8876daf17554 to e8c3fa6d7d2f (3 revisions) (flutter/engine#38413) (flutter/flutter#117366) * 7f7a8778d Implemented Scrim Focus for BottomSheet (flutter/flutter#116743) * 38e3930f3 Exposed tooltip longPress action when available (flutter/flutter#117338) * 61fb6ea2d Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (flutter/flutter#117372) * c64dcbefa Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (flutter/flutter#117396) * 8289ea624 Move a comment where it belongs (flutter/flutter#117385) * fa3777bd3 Enable `sized_box_shrink_expand` lint (flutter/flutter#117371) * e0742ebb2 [Android] Add spell check suggestions toolbar (flutter/flutter#114460) * 0220afdd3 enable use_enums (flutter/flutter#117376) * d71fa885e Bump ossf/scorecard-action from 2.1.0 to 2.1.1 (flutter/flutter#117337) * 4591f057f roll packages (flutter/flutter#117357) * 46bb85376 Revert "Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (#117396)" (flutter/flutter#117402) * 81bc54be7 Enable `use_colored_box` lint (flutter/flutter#117370) * fdd2d7d64 Sync analysis_options.yaml & cleanups (flutter/flutter#117327) * de357647b [Android] Bump template AGP and NDK versions (flutter/flutter#116536) * b308555ed Enable `dangling_library_doc_comments` and `library_annotations` lints (flutter/flutter#117365) * b3c7fe32e enable test_ownership in presubmit (flutter/flutter#117414) * 014b8f735 Roll Flutter Engine from 7ee3bf518036 to 75d75575d0ea (12 revisions) (flutter/flutter#117421) * cd0f15a77 Add support for double tap and drag for text selection (flutter/flutter#109573) * e8e26b684 c7eae2901 [Impeller] Remove depth/stencil attachments from imgui pipeline (flutter/engine#38427) (flutter/flutter#117425) * a3e7fe3ff de59f842a Roll Dart SDK from 35f6108ef685 to 1530a824fd5f (6 revisions) (flutter/engine#38431) (flutter/flutter#117429) * 169935168 4724a91af Roll Skia from 09d796c0a728 to a60f3f6214d3 (5 revisions) (flutter/engine#38432) (flutter/flutter#117433) * 9024c9543 28f344ceb Roll Dart SDK from 1530a824fd5f to 8078926ca996 (1 revision) (flutter/engine#38434) (flutter/flutter#117435) * cae784649 c9ee05b68 use min/max sandwich test on unit test bounds (flutter/engine#38435) (flutter/flutter#117442) * 6819f72a9 Roll Flutter Engine from c9ee05b68e6e to 2404db80ae80 (3 revisions) (flutter/flutter#117443) * f5c071659 4910ff889 Roll Fuchsia Mac SDK from nJJfWIwH5zElheIX8... to UsYNZnnfR_s0OGQoX... (flutter/engine#38444) (flutter/flutter#117454) * a7a5d14d2 Roll Plugins from 840a04954fa0 to 54fc2066d636 (6 revisions) (flutter/flutter#117456) * 51a…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for double tap + drag, to select word by word when double tapping and then dragging the mouse.
This change also adds a new gesture recognizers that will be specifically useful for text selection:
TapAndDragGestureRecognizerThis recognizer makes use of a
_TapStatusTrackerMixinto keep track of the tap count.TextSelectionGestureDetectorno longer uses aTapGestureRecognizerorPanGestureRecognizer.TapUp,TapDown,TapCancel,onStart,onUpdate,onEnd, andonCancelare now handled by the new recognizer.Currently our text selection system does not support double tap + drag (selects word by word) and triple tap + drag (selects line by line). This PR adds support for this behavior by bundling the handling of tap up and tap down with a drag gesture recognizer and long press gesture recognizer. This helps us avoid having to pass state around to accomplish the same behavior. For example, this behavior could also be accomplished by having the TapGestureRecognizer.onTapDown callback, save the tap count, then this tap count can be used by the DragGestureRecognizer.onUpdate callback to determine if the selection should be updated character by character, word by word, or line by line. Some disadvantages of passing state around between gesture recognizers are that you can't accomplish this behavior in a classes initializer (Trying to build a default mapping of gesture recognizers for text selection https://github.com/Renzo-Olivares/flutter/blob/3dbffa3922c656e5c2f97fb6ff8d42b4573d152c/packages/flutter/lib/src/widgets/default_selection_gestures.dart#L24).
Will be handled in separate PR:
Selection area #104552
Fixes #99071, #64550, #23973
Pre-launch Checklist
///).