Update accessibility contrast test coverage #109784
Conversation
Update the accessbility test to cover all Elements with same semantic label to get better coverage on contrast test.
Nit fix.
Add a test with multiple nodes with same semantic label. but one of the label is excluded from semantic tree and has failing contrast (white on white) but this should pass a11y contrast test.
There was a problem hiding this comment.
My concern with the ignored semantics + repeats has been address, so I'm marking this tenatively as LGTM.
I would also ask @chunhtai and @goderbauer to take a quick look. This will need to run through a google3 test run before we can land it though.
This reverts commit f477c8b.
|
change reverted due to internal migration applied too soon. |
|
I left a pending cl which fixes the internal tests. Should be on Flutter ROB. |
|
@ankur2136 is it the one that removes skipA11yLabelUpcomingFixFromPr109784 ? |
|
Hey @chunhtai In one of my last cls I refactored the original set into 2 separate sets. This PR would have broken 669 individual tests which should be the ones refactored into the set. The changes there were fixing all tests as of Friday but things might have changed slightly here and there in a few tests since then. Please contact leizi@ who is taking ownership from me to fix this in G3. |
This reverts commit 41b50c2.
Update the accessibility test to cover all Elements with same semantic label to get better coverage on contrast test.
#109465 Improve flutter contrast test coverage
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.