remove passing --debugger-module-names to frontend server #109791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 18, 2022 11:05
The flag is true by default so the behavior does not change.
Next steps:
Use the flag for updated debugger module names:
- Frontend server: make the current behavior controlled
by the flag non-conditional
- Frontend server: add more debugging names changes under
the same flag, false by default
- Dwds: make changes required for the new module names.
- Flutter tools: when matching dwds changes roll to flutter,
pass the flag to the frontend server again.
- Cleanup:
- Frontend server: make new behavior default
- Flutter tools: remove uses of the flag.
- Frontend server: remove the flag.
Towards: dart-lang/webdev#1692
Helps: flutter#106727
…ove-use-of-debugger-module-names
|
@zanderso can we remove the debug flag? I see you have a TODO in the code |
zanderso
approved these changes
Aug 18, 2022
I am planning to use it for a bit longer to fix #106727 (dart-lang/webdev#1692) and then I will remove the flag (see my description of next steps in this PR) |
This was referenced Aug 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Remove passing of
--debugger-module-namesflag to the frontend serverThe flag is true by default so the behavior does not change.
Next steps
Use the flag for updated debugger module names:
by the flag non-conditional
the same flag, false by default
pass the flag to the frontend server again.
Cleanup:
Towards: dart-lang/webdev#1692
Helps: #106727
Tests
Behavior does not change so the existing tests should match.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.