Temporarily remove a bogus warning until fixed by dwds update #109793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Aug 18, 2022
| @@ -1042,7 +1042,9 @@ void log(logging.LogRecord event) { | |||
| if (event.level >= logging.Level.SEVERE) { | |||
| globals.printError('${event.loggerName}: ${event.message}$error', stackTrace: event.stackTrace); | |||
| } else if (event.level == logging.Level.WARNING) { | |||
| globals.printWarning('${event.loggerName}: ${event.message}$error'); | |||
| if (!event.message.contains('No module for')) { | |||
There was a problem hiding this comment.
If the need for this check is temporary, please add a TODO with issue/PR after which this can be removed.
There was a problem hiding this comment.
Done! This is already fixed in dwds master, so I added a link to the "release new version of dwds" issue.
zanderso
approved these changes
Aug 18, 2022
This was referenced Aug 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 20, 2022
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Oct 4, 2022
…r#109793) * Temporarily remove a bogus warning until fixed by dwds update * Addressed CR feedback
christopherfujino
added a commit
that referenced
this pull request
Oct 5, 2022
… (#112887) * Temporarily remove a bogus warning until fixed by dwds update * Addressed CR feedback Co-authored-by: Anna Gringauze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #109792
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.