Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Re-Land "Refactor StrokeAlign to allow double values." (#109591) #109805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2022
Merged

Re-Land "Refactor StrokeAlign to allow double values." (#109591) #109805

merged 2 commits into from
Aug 19, 2022

Conversation

gspencergoog
Copy link
Contributor

This reverts commit 370fc48 so that it can be re-landed.

The G3Fix for this is in cr/468540281 (Google-internal).

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 18, 2022
HansMuller
HansMuller approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 19, 2022
@auto-submit auto-submit bot merged commit b3aba4d into flutter:master Aug 19, 2022
This was referenced Aug 20, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 20, 2022
@engine-flutter-autoroll
b3aba4d Re-Land "Refactor StrokeAlign to allow double values." (#1095…
73533e0 
…91) (flutter/flutter#109805)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 20, 2022
@engine-flutter-autoroll
b3aba4d Re-Land "Refactor StrokeAlign to allow double values." (#1095…
9facda0 
…91) (flutter/flutter#109805)
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Aug 21, 2022
@gspencergoog
Revert "Re-Land "Refactor StrokeAlign to allow double values." (flutt…
e9fd46e 
…er#109805)"

This reverts commit b3aba4d because it breaks Google tests.
CaseyHillers pushed a commit that referenced this pull request Aug 21, 2022
@gspencergoog
Revert "Re-Land "Refactor StrokeAlign to allow double values." (#109805…
957a8da 
…)" (#109955)

This reverts commit b3aba4d because it breaks Google tests.
bernaferrari pushed a commit to bernaferrari/flutter that referenced this pull request Aug 22, 2022
@gspencergoog @bernaferrari
Revert "Revert "Re-Land "Refactor StrokeAlign to allow double values." (
7da8292 
flutter#109805)" (flutter#109955)"

This reverts commit 957a8da.
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Aug 25, 2022
@gspencergoog
Re-Land "Refactor StrokeAlign to allow double values." (flutter#109805)
5e9262b 
This reverts commit 957a8da to try again at landing it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gspencergoog @HansMuller