Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix flutter not finding custom device (#108884) #109957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zanderso
Copy link
Member

CP of #108884 for #108883

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-3.2-candidate.5 to master August 21, 2022 19:27
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-3.2-candidate.5. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot added engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 21, 2022
@zanderso zanderso changed the base branch from master to flutter-3.2-candidate.5 August 21, 2022 19:27
@XilaiZhang
Copy link
Contributor

Shall we add autosubmit label for this pull request @itsjustkevin ?

@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 22, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 22, 2022

Validations Fail.

Copy link
Contributor

@itsjustkevin itsjustkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2022
@itsjustkevin itsjustkevin merged commit f35bf40 into flutter:flutter-3.2-candidate.5 Aug 22, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
ToRvaLDz pushed a commit to ToRvaLDz/flutter that referenced this pull request Jul 16, 2023
* fix flutter not finding custom device (flutter#108884)

* Update doctor_test.dart

Co-authored-by: Hannes Winkler <[email protected]>
ToRvaLDz added a commit to ToRvaLDz/flutter that referenced this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants