Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[flutter_tools] unpin path_provider_android and roll #110216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

christopherfujino
Copy link
Contributor

Fixes #109397 by unpinning path_provider_android and picking up the new release from flutter/plugins#6231

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 24, 2022
@christopherfujino
Copy link
Contributor Author

@GaryQian & @camsim99 actually, it looks like version 2.0.20 from https://github.com/flutter/plugins/pull/6231/files wasn't published to pub https://pub.dev/packages/path_provider_android. Is there some other action we need to take to publish?

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Aug 24, 2022

@GaryQian & @camsim99 actually, it looks like version 2.0.20 from https://github.com/flutter/plugins/pull/6231/files wasn't published to pub https://pub.dev/packages/path_provider_android. Is there some other action we need to take to publish?

Looks like the release action failed post-submit: https://github.com/flutter/plugins/runs/7813700106?check_suite_focus=true

android-platform_tests CHANNEL:master PLUGIN_SHARDING:--shardIndex 0 --shardCount 5: completed (failure)

@camsim99
Copy link
Contributor

@GaryQian & @camsim99 actually, it looks like version 2.0.20 from https://github.com/flutter/plugins/pull/6231/files wasn't published to pub https://pub.dev/packages/path_provider_android. Is there some other action we need to take to publish?

@stuartmorgan brought this issue to my attention: #92675. Seems like it failed to publish silently.

@christopherfujino
Copy link
Contributor Author

hmm, not sure how but 2.0.20 is now published, so i think i'm unblocked.

@christopherfujino christopherfujino force-pushed the unpin-path-provider-android branch from f261dd0 to cd7d402 Compare August 25, 2022 18:41
@stuartmorgan-g
Copy link
Contributor

hmm, not sure how but 2.0.20 is now published

I reran the flaky post-submit test on the old PR after @camsim99 flagged the problem, so it published.

@christopherfujino
Copy link
Contributor Author

hmm, not sure how but 2.0.20 is now published

I reran the flaky post-submit test on the old PR after @camsim99 flagged the problem, so it published.

Thanks Stuart!

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2022
@auto-submit auto-submit bot merged commit db51e5d into flutter:master Aug 25, 2022
@christopherfujino christopherfujino deleted the unpin-path-provider-android branch August 25, 2022 19:44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 25, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade of package:path_provider_android broke flutter_engine_group_performance test
3 participants